Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp6570728rwj; Wed, 21 Dec 2022 17:58:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXt3ByDRBkmgYOvRlCBZ0ncNkeh4AX6VzhVwpAgV23OBqGcNufaUAQrOEX7swjhOR6/qbqDr X-Received: by 2002:a17:906:eb8f:b0:7ae:7e6:3a87 with SMTP id mh15-20020a170906eb8f00b007ae07e63a87mr2843016ejb.41.1671674324759; Wed, 21 Dec 2022 17:58:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671674324; cv=none; d=google.com; s=arc-20160816; b=x7C5IO6Vn5kUpVNy3jD+AjB4MOUuqCQI91Jc3ejO0u6jyYt3Y8SXYNPiguA+Id4la3 qUmrtY96jOsq/8/seGZrVS/CgJzVEYshpxyDinnqt0i1vtUGiYqIasi/SEA5kDxNp9rv mAEU7IZWIayJRscoysctqM0GEjj2flglRMovdar7KLOjmURjRiKyeY5LIrV1/3XlbM5f 2WY87amT8SCSFLpLK1wpz3ooObTsTOWXJ5c4xFRdTbD/7KxcF3f2qhHFQXddm0qqbiTn xZCDEILrNi7CarlY+sZ73O9tW5L6y7+Hs6g/wq52Yc3j6P0+MwrvHyvEEmaNi7K+4uqG X2Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=DQPD596bi7SFQsca/rtQVUxoKujB2836+GAwSQyxiCc=; b=RaFoKP50y13cEJHnEAYLIHzTCQbCGb43eoQcQsTjpJm0GK5T+AE5we/5/3h/+r1wxj 2DU5H2YjteiD1oHUDFUuYlqca2OjRhl3PQUHRcGVS3CcNT4Z+4rfBpa9E2Y2o67F2VD+ jxNqP3E72wLC4MppQxwRD016bb7Sv7A4KllU0sEjPsHxBcPeJ/09NfkHjhdnU4B3S8Vm NKpdEKyPXj4+IvVHrXe4Z09bG/aKpKQySL/qtK6mDOBgKPcPy7jQtGHr+ycDNrpsGk9T Tb0wb2JV43KzyESJhyFOpN2p2gyNYymyQDnuoFz1H89V3/Z/B4E+TMJfkaYNuTP8AgRl otGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IT6jl8cq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020a5099c2000000b0046d21bc9750si5830545edb.532.2022.12.21.17.58.22; Wed, 21 Dec 2022 17:58:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IT6jl8cq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234943AbiLVBku (ORCPT + 68 others); Wed, 21 Dec 2022 20:40:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbiLVBks (ORCPT ); Wed, 21 Dec 2022 20:40:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D6FE1175; Wed, 21 Dec 2022 17:40:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F3497B81BE6; Thu, 22 Dec 2022 01:40:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C92AC433D2; Thu, 22 Dec 2022 01:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671673244; bh=5hnA9BOPvRCsr9HRqNX8XNegYPB26+FLi9Rn2nGpnu8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IT6jl8cqpjRGnzQEgdfuC1lW2fi3DyceeTn/hkCvrPqc+ukKQREJM4a53K++ZiOp4 PFaOlXJ9RIuyOnAxfUIUx5R0J4O0nWy8T8v1HajJLwMx5+4s7EfTgECyb7rNHE2ZBY c0WpvbBBNMZJfTUjc6yLo5pRogzaeyiAXlqJbY1404kJAP1ch5rXxFqiSPjInfW6UQ XvPxLkIIrQz+a00VqaYW0tnS4ycvFRmlnVUAMspYu0x/VUx186w6cyjmy+Fu1hOxQ6 q/RkGWObwvza4i7ghZxfdHJN1YewXvGWaV8efRbKHFeLAQhBNDtMRvG5uTeyK0NXZV z6wWox25Z2rjw== Date: Wed, 21 Dec 2022 17:40:43 -0800 From: Jakub Kicinski To: Christophe JAILLET Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Taku Izumi , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net] fjes: Fix an error handling path in fjes_probe() Message-ID: <20221221174043.1191996a@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Dec 2022 21:57:06 +0100 Christophe JAILLET wrote: > A netif_napi_add() call is hidden in fjes_sw_init(). It should be undone > by a corresponding netif_napi_del() call in the error handling path of the > probe, as already done inthe remove function. Ah, now I see why Michal asked about netif_napi_del() in the other driver :S free_netdev() cleans up NAPIs.