Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a82092f5-abc8-584f-b2ba-f06c82ffbe7d@redhat.com>
Date:   Wed, 21 Dec 2022 22:39:53 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [RFC PATCH] clocksource: Suspend the watchdog temporarily when
 high read lantency detected
Content-Language: en-US
To:     paulmck@kernel.org
Cc:     Feng Tang <feng.tang@intel.com>, John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>, x86@kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, Tim Chen <tim.c.chen@intel.com>
References: <20221220082512.186283-1-feng.tang@intel.com>
 <6fb04ee9-ce77-4835-2ad1-b7f8419cfb77@redhat.com>
 <20221220183400.GY4001@paulmck-ThinkPad-P17-Gen-1>
 <Y6Ja+kYQAi4pppV6@feng-clx> <8a9bed0d-c166-37e9-24c3-8cea7a336c76@redhat.com>
 <20221222004032.GI4001@paulmck-ThinkPad-P17-Gen-1>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <20221222004032.GI4001@paulmck-ThinkPad-P17-Gen-1>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/21/22 19:40, Paul E. McKenney wrote:
> commit 199dfa2ba23dd0d650b1482a091e2e15457698b7
> Author: Paul E. McKenney<paulmck@kernel.org>
> Date:   Wed Dec 21 16:20:25 2022 -0800
>
>      clocksource: Verify HPET and PMTMR when TSC unverified
>      
>      On systems with two or fewer sockets, when the boot CPU has CONSTANT_TSC,
>      NONSTOP_TSC, and TSC_ADJUST, clocksource watchdog verification of the
>      TSC is disabled.  This works well much of the time, but there is the
>      occasional system that meets all of these criteria, but which still
>      has a TSC that skews significantly from atomic-clock time.  This is
>      usually attributed to a firmware or hardware fault.  Yes, the various
>      NTP daemons do express their opinions of userspace-to-atomic-clock time
>      skew, but they put them in various places, depending on the daemon and
>      distro in question.  It would therefore be good for the kernel to have
>      some clue that there is a problem.
>      
>      The old behavior of marking the TSC unstable is a non-starter because a
>      great many workloads simply cannot tolerate the overheads and latencies
>      of the various non-TSC clocksources.  In addition, NTP-corrected systems
>      often seem to be able to tolerate significant kernel-space time skew as
>      long as the userspace time sources are within epsilon of atomic-clock
>      time.
>      
>      Therefore, when watchdog verification of TSC is disabled, enable it for
>      HPET and PMTMR (AKA ACPI PM timer).  This provides the needed in-kernel
>      time-skew diagnostic without degrading the system's performance.
>      
>      Signed-off-by: Paul E. McKenney<paulmck@kernel.org>
>      Cc: Thomas Gleixner<tglx@linutronix.de>
>      Cc: Ingo Molnar<mingo@redhat.com>
>      Cc: Borislav Petkov<bp@alien8.de>
>      Cc: Dave Hansen<dave.hansen@linux.intel.com>
>      Cc: "H. Peter Anvin"<hpa@zytor.com>
>      Cc: Daniel Lezcano<daniel.lezcano@linaro.org>
>      Cc: Feng Tang<feng.tang@intel.com>
>      Cc: Waiman Long <longman@redhat.com
>      Cc:<x86@kernel.org>

As I currently understand, you are trying to use TSC as a watchdog to 
check against HPET and PMTMR. I do have 2 questions about this patch.

First of all, why you need to use both HPET and PMTMR? Can you just use 
one of those that are available. Secondly, is it possible to enable this 
time-skew diagnostic for a limit amount of time instead running 
indefinitely? The running of the clocksource watchdog itself will still 
consume a tiny amount of CPU cycles.

Cheers,
Longman