Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH] f2fs: drop useless initializer and unneeded local variable
Date:   Thu, 22 Dec 2022 16:18:55 +0800
Message-Id: <20221222081855.81553-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Cq0HoCfrIssMpwj4vOMmvPuRBe2Cs597OJ4ByWid+gDLmO0nmORxMpmfSutZ?=
 =?us-ascii?Q?Dfu0+Bw467T44LBUoPfTk6pmFUzmzwahCvmVRaAnvJc2Pd4K8On0/CYxEKMf?=
 =?us-ascii?Q?QTt8jecJVN5ffO6n5cbwElY0m2k4dL/U4GMXV4/wIqnXCzO2j9Xg9U4m5SXb?=
 =?us-ascii?Q?ifl2W2UUqv2IztCpWWZR21RP4vgEKyqCzlmVLmcphLUG0jjJFrKhXlkBFzBh?=
 =?us-ascii?Q?83cqnTwQwflyHq5qkujqheFLfilVVw+Fa5m8Mx+vsQPUXNHj37pRIRkvbykd?=
 =?us-ascii?Q?S4pQ7jIowZ5AJsLsrdU40greEnMqVFaU7YWl9ZfWG0v8HHkj0wR5sJ/8vgBJ?=
 =?us-ascii?Q?CyBgt7xmHYt0yQyXMzHfkZV9rZ5i+c9sxAfqWSdj6eNac9HukrkTrvOiAAl4?=
 =?us-ascii?Q?UGbL5MaIwxWHgU9+3vTH1gF6DZ8E/gZsYmNZR34oUbSBbGjFWzw2aCOd5B8/?=
 =?us-ascii?Q?aoDuvs3w4yJ+VA/UDQIG7L6Bd+wYqNPvYJ8Dj/mt9gSIq9dEIHkoWi3dAPeW?=
 =?us-ascii?Q?Mpu2UhKGuzMumJOQtSnu8lWV5h4mxGS+d1KjYjBr3fg1p6+PhH/Kmy3CLRJD?=
 =?us-ascii?Q?otFTY8RJrr3G2PtsKosHCuj8NsuPxDrUwx5Dz07NGWKlWGFoOEtVJRn6SoJb?=
 =?us-ascii?Q?VyvSe2izkbQI/5Z2bKb2Gh9cgdLX0eg5PtuiiVeXX8hN6REIQgQqpRGHBoc1?=
 =?us-ascii?Q?0yp+6PNVtsFhhg/5WbwprfRYnZPYiF0+XDoj21ibQtbBTXg/QAFoo/tuUQjF?=
 =?us-ascii?Q?b4BPw9mlb26qzAYtt+NIolIsjL+15n/VA5cR+1cAX2PLbwIOvXWrrIxIDic7?=
 =?us-ascii?Q?Xy5Kz72weZn8nuraARQm9f57T90Jtng5SG3pc2x87LDsIPN4n1wzfB6vCEMI?=
 =?us-ascii?Q?X+Zvy2LL49u9PUsCDDLtYoKrgXvyjY2W59cCBwQJw8Q7xyJ2YAUtU7EaCePX?=
 =?us-ascii?Q?e9oJDmRJ2Mz6x15UVzgzWQg8q4zxTKx/H7cwJwW0WM77XL/OtL5Tpi0g8hqs?=
 =?us-ascii?Q?dEJ9V6NWJi/EAa+so9CVQ+/AS8hGCDKjGIvw171OUDix7lsezwL/u6Ro2YRf?=
 =?us-ascii?Q?M07M3rVhek5QqsrXSB7WoVUHDNeG1nwW491f3VFSchAs8Spj8c26fnmowolA?=
 =?us-ascii?Q?PI3tL+K9EnsiUBLQS/t8nlF//GzLOiD5QtlNuQZRVWWR9UoWDtBFxCg94Xnu?=
 =?us-ascii?Q?Vfq2tjdWtjyGNwaG3c7ROCfnay4eORm8ky4FffR4EWM630trU2U9i7+Kfoee?=
 =?us-ascii?Q?ZBs1akkf3kzjdVNkDe9IuZ5OFaXTi510GlxBlOb1EP2L68PVwOuAXlM2C5gY?=
 =?us-ascii?Q?zD4PXPcPdwqspWwRQR1IYp7XwG5riGzfQC6hSlXDB4jJ3jt3kcpsv2gmauG4?=
 =?us-ascii?Q?IKLmxNrz0JR1mYBt2dB9ThbsgIY2zLGNwnwLI1WavAWhNaaPrX5nmenWjmWY?=
 =?us-ascii?Q?bSbrHh5KoEl1PexShxk7515KYHEu7LGm9ZaU9+2jrvxVbP5DjiQpnWKCxq5Q?=
 =?us-ascii?Q?JaTWGeXl/DTsEjvmTx/NmiLJagX/XT+2gQzP3l31X3Uh8bhmqaJw8W6Da55g?=
 =?us-ascii?Q?XX4toYZYa7BYYWXfVN9co6y14UN86phWQVlT819o?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1713597b-c6d9-42cc-b0b7-08dae3f5312e
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2022 08:19:06.0182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WGzqahqgcY7IZZCpvp8O99IRD1AfBPEPqNRzafp2dIz+HP1VZ9Ggmfxfb8HdxJ6E/IUMvVUrf9RYCiSejzF/ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4280
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

No need to initialize idx twice. BTW, remove the unnecessary cnt variable.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/iostat.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/f2fs/iostat.c b/fs/f2fs/iostat.c
index 3166a8939ed4..335b055ffe7d 100644
--- a/fs/f2fs/iostat.c
+++ b/fs/f2fs/iostat.c
@@ -97,8 +97,7 @@ int __maybe_unused iostat_info_seq_show(struct seq_file *seq, void *offset)
 
 static inline void __record_iostat_latency(struct f2fs_sb_info *sbi)
 {
-	int io, idx = 0;
-	unsigned int cnt;
+	int io, idx;
 	struct f2fs_iostat_latency iostat_lat[MAX_IO_TYPE][NR_PAGE_TYPE];
 	struct iostat_lat_info *io_lat = sbi->iostat_io_lat;
 	unsigned long flags;
@@ -106,12 +105,11 @@ static inline void __record_iostat_latency(struct f2fs_sb_info *sbi)
 	spin_lock_irqsave(&sbi->iostat_lat_lock, flags);
 	for (idx = 0; idx < MAX_IO_TYPE; idx++) {
 		for (io = 0; io < NR_PAGE_TYPE; io++) {
-			cnt = io_lat->bio_cnt[idx][io];
 			iostat_lat[idx][io].peak_lat =
 			   jiffies_to_msecs(io_lat->peak_lat[idx][io]);
-			iostat_lat[idx][io].cnt = cnt;
-			iostat_lat[idx][io].avg_lat = cnt ?
-			   jiffies_to_msecs(io_lat->sum_lat[idx][io]) / cnt : 0;
+			iostat_lat[idx][io].cnt = io_lat->bio_cnt[idx][io];
+			iostat_lat[idx][io].avg_lat = iostat_lat[idx][io].cnt ?
+			   jiffies_to_msecs(io_lat->sum_lat[idx][io]) / iostat_lat[idx][io].cnt : 0;
 			io_lat->sum_lat[idx][io] = 0;
 			io_lat->peak_lat[idx][io] = 0;
 			io_lat->bio_cnt[idx][io] = 0;
-- 
2.25.1