Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221222050052.20785-1-jasowang@redhat.com>
In-Reply-To: <20221222050052.20785-1-jasowang@redhat.com>
From:   Eugenio Perez Martin <eperezma@redhat.com>
Date:   Thu, 22 Dec 2022 09:50:08 +0100
Message-ID: <CAJaqyWc5WtnP1K0JALvBV7Q_aiD5id=gjAC+n+hKLBVJaePx-Q@mail.gmail.com>
Subject: Re: [PATCH V2 0/4] Vendor stats support in vdpasim_net
To:     Jason Wang <jasowang@redhat.com>
Cc:     mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Dec 22, 2022 at 6:01 AM Jason Wang <jasowang@redhat.com> wrote:
>
> Hi All:
>
> This series implements vendor stats in vdpasim_net. Please review.
>
> Thanks
>

Apart from the commented blanks,

Acked-by: Eugenio P=C3=A9rez <eperezma@redhat.com>

Thanks!

> Changes since V1:
> - typo fixes
> - move the duplicated get_vendor_vq_stats() in
>   vdpasim_batch_config_ops to vdpa_sim_config_ops
> - use -EOPNOTSUPP instead of -EINVAL in vdpasim_get_vq_stats
> - introdce a dedicated variable to record the successful cvq request
>   and track the number of requests correctly
>
> Jason Wang (4):
>   vdpa_sim: switch to use __vdpa_alloc_device()
>   vdpasim: customize allocation size
>   vdpa_sim: support vendor statistics
>   vdpa_sim_net: vendor satistics
>
>  drivers/vdpa/vdpa_sim/vdpa_sim.c     |  33 +++-
>  drivers/vdpa/vdpa_sim/vdpa_sim.h     |   4 +
>  drivers/vdpa/vdpa_sim/vdpa_sim_blk.c |   1 +
>  drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 221 ++++++++++++++++++++++++++-
>  4 files changed, 248 insertions(+), 11 deletions(-)
>
> --
> 2.25.1
>