Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Dec 2022 09:59:39 +0100
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>,
        <linux@armlinux.org.uk>
Subject: Re: [PATCH net] net: lan966x: Fix configuration of the PCS
Message-ID: <Y6QcSh8zQMKRKbJp@praczyns-desk3>
References: <20221221093315.939133-1-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221221093315.939133-1-horatiu.vultur@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qniXMGuToCKaJ1chn5eAoWRVd3qcDCy9zskKdmVQIIptIKen8Zz+qAsE6bqt?=
 =?us-ascii?Q?giGkNKPlhqzol+cn1SmF6cwxWkqHm5Xt8oGjp8QkJ/eu0etuZDu9J975Hovn?=
 =?us-ascii?Q?ILEPEm323gvwj4XPRSEDzENimH6bH64eE+6g2y/jo1lNTuwSW32zytv9UCac?=
 =?us-ascii?Q?uXF+K9Lo7Dg1EyyXW/rI3uw06IeHfCJQatnkLItB6AchYiaYyqWoLG+DJJb3?=
 =?us-ascii?Q?7cC/ySFyqz+4ftRI51LcQUQXYElT+j3ABpzqc8nQedw17G+310hCktNS7Vy2?=
 =?us-ascii?Q?KMhOYXVKOsklv5Lf3CQiXXBaQ25WWClMRuh5cFCF7IrMp0/kL4m9/I0g19z+?=
 =?us-ascii?Q?nLBUFeWDPkKM4IyhLlLmDz7RGycviMOW7M1LZBYjfeANz2B5xnk3WTyxWjd7?=
 =?us-ascii?Q?LWrphtLzdNhQPv30Asa0wgAIr7kNwWFWnaZRpO8MUs3H7HX0vNhp8s8BuqqK?=
 =?us-ascii?Q?6T2puM7QyK8l2/Yvl78BlWnn/m3PBQRiuWLo1wteCupbBoATI7YHp8yf3qIB?=
 =?us-ascii?Q?GWm/o/YexVNdWzPT/P7eVRDwJw8NY3QRgfs8EueshcaL3Zyzg+FyijGNmNTy?=
 =?us-ascii?Q?Hku9QJlhC0J8m2rF3h77iyrXx6qu/ZRrfhx1AuYCHgBylBgwcHmfWH1CCycG?=
 =?us-ascii?Q?gZf+f14aYD40zenHzDr/y2W0XzWDjE2GUToRu58Udogp5p4AhVoVUT8HltrI?=
 =?us-ascii?Q?aQyA5Wpw/xmQBx5ewyoFR0CoVOWQK6CcH78CV8puRofWjpDevA4fXlmTdjS2?=
 =?us-ascii?Q?2zC8wU7usoNo0o/Rt7VKGJFiAc2qzsV8eIyP2tB+AGUKcAtKXmX4swDvMhAT?=
 =?us-ascii?Q?8PxwqcShEWqPT5VAX0KlP67bkqV8ycVWLFiCqaB2/sTtbohxk3zQ1IjpNK/V?=
 =?us-ascii?Q?LbOJhpEgwBNNENROzeRlTn/onGzrF+r4QZw2H0BfIgq37k8fFvDp8e1/J1h7?=
 =?us-ascii?Q?H4grtNgbNSlzydcCt63mB7Z5Yqxx4JzW6ukmGDDvrWUHpNO5b7ScnwhqdJs0?=
 =?us-ascii?Q?d39AHe3/OnQpidPnmQdjjv3Nl57GxH68zaj3BP2YoXrcgrzSELnGxVao+LcH?=
 =?us-ascii?Q?BkxZ+gymGdTchxKk5uQc7vc9L1AlXIeMhxoXRDfq5yMVVxQYvTCr7PbW8wFZ?=
 =?us-ascii?Q?yyinJmNoNl0z8DchSa/5d5edxLinXEBykfPZ0k5N90NjonrK8KrQeHsQslfF?=
 =?us-ascii?Q?Bkjde6W7XiHjl1Mw+r5886HWv/cwr3MC/0AKz9lWKscRGRwkPnZvgN2WLBuz?=
 =?us-ascii?Q?DhyBCFH7LMp/N1EISbs3wJtKDvxFcBfqvOKFoDXAJBDbYqSPjPF8b5H/8FQw?=
 =?us-ascii?Q?+PFe1PKK1t+tXreyhGlo1fk9nHSm85d/gdfGqVj3d+W2lJ04yXZnXjRHHm4B?=
 =?us-ascii?Q?jTRoAAW1MU17MjS7fI57x2r9vUCsUYynRwlWbXrg42jGRAbmRnqzPr6zc+5W?=
 =?us-ascii?Q?dFug1WHR0WRX8z2ENCgtOMql04ZVDISjWluq1L7/eEkP0PWd5I/NYGB1TGGu?=
 =?us-ascii?Q?TfSPPo8xTvy4bQ4b+xg+KtK5LESqET1e/c0ZGPWj4HrjWu47rT1aV4btqV1Z?=
 =?us-ascii?Q?AfboAWr0owg6mrdPSmlVgthexK60hCuUqAO5SnthHwEBFT1OPGTxa1xNfMGQ?=
 =?us-ascii?Q?AQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25ea452f-0533-4401-25b3-08dae3fadf03
X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2227.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2022 08:59:45.2013
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0an42wtPzSs69S8/RFCHk1M9gCi7K7giZYFCRoYCYN79mrS4LH7gRil7Dx53FA0ifeAmpiVbmtVBaIvsZaY2Tdq/qKHv7wA6t9N6GrhKnBI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5598
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 21, 2022 at 10:33:15AM +0100, Horatiu Vultur wrote:
> When the PCS was taken out of reset, we were changing by mistake also
> the speed to 100 Mbit. But in case the link was going down, the link
> up routine was setting correctly the link speed. If the link was not
> getting down then the speed was forced to run at 100 even if the
> speed was something else.
> On lan966x, to set the speed link to 1G or 2.5G a value of 1 needs to be
> written in DEV_CLOCK_CFG_LINK_SPEED. This is similar to the procedure in
> lan966x_port_init.
> 
> The issue was reproduced using 1000base-x sfp module using the commands:
> ip link set dev eth2 up
> ip link addr add 10.97.10.2/24 dev eth2
> ethtool -s eth2 speed 1000 autoneg off
> 
> Fixes: d28d6d2e37d1 ("net: lan966x: add port module support")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  drivers/net/ethernet/microchip/lan966x/lan966x_port.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_port.c b/drivers/net/ethernet/microchip/lan966x/lan966x_port.c
> index 1a61c6cdb0779..0050fcb988b75 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_port.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_port.c
> @@ -381,7 +381,7 @@ int lan966x_port_pcs_set(struct lan966x_port *port,
>  	}
>  
>  	/* Take PCS out of reset */
> -	lan_rmw(DEV_CLOCK_CFG_LINK_SPEED_SET(2) |
> +	lan_rmw(DEV_CLOCK_CFG_LINK_SPEED_SET(LAN966X_SPEED_1000) |
>  		DEV_CLOCK_CFG_PCS_RX_RST_SET(0) |
>  		DEV_CLOCK_CFG_PCS_TX_RST_SET(0),
>  		DEV_CLOCK_CFG_LINK_SPEED |
> -- 
> 2.38.0
> 
LGTM, thanks for getting rid of a magic number here.

Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>