Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Tao Lan <taolan@huawei.com>
To:     <mturquette@baylibre.com>, <sboyd@kernel.org>
CC:     <j.neuschaefer@gmx.net>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, taolan <taolan@huawei.com>
Subject: [PATCH] clk: fix memory leak in hisi_clk_init.
Date:   Thu, 22 Dec 2022 09:12:21 +0000
Message-ID: <20221222091221.28308-1-taolan@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

From: taolan <taolan@huawei.com>

when clk_data create fail, we also need to release base.

Signed-off-by: taolan <taolan@huawei.com>
---
 drivers/clk/hisilicon/clk.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/clk/hisilicon/clk.c b/drivers/clk/hisilicon/clk.c
index 54d9fdc93599..9ca4fc05fa57 100644
--- a/drivers/clk/hisilicon/clk.c
+++ b/drivers/clk/hisilicon/clk.c
@@ -82,6 +82,10 @@ struct hisi_clock_data *hisi_clk_init(struct device_node *np,
 	of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data->clk_data);
 	return clk_data;
 err_data:
+	if (base) {
+		iounmap(base);
+		base = NULL;
+	}
 	kfree(clk_data);
 err:
 	return NULL;
-- 
2.17.1