Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Dec 2022 12:34:35 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Marc Zyngier <maz@kernel.org>
Cc:     James Morse <james.morse@arm.com>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Oliver Upton <oliver.upton@linux.dev>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
        kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: arm64: Remove use of ARM64_FEATURE_MASK()
Message-ID: <Y6RO29H8AmnswBN7@sirena.org.uk>
References: <20221221-kvm-sysreg-cleanup-v1-0-112ddb14fb4e@kernel.org>
 <20221221-kvm-sysreg-cleanup-v1-2-112ddb14fb4e@kernel.org>
 <86h6xnbp9m.wl-maz@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uTei0FHqHVjcuC9J"
Content-Disposition: inline
In-Reply-To: <86h6xnbp9m.wl-maz@kernel.org>
Precedence: bulk


--uTei0FHqHVjcuC9J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 22, 2022 at 12:23:49PM +0000, Marc Zyngier wrote:
> Mark Brown <broonie@kernel.org> wrote:

> > the users to directly use the generated mask macros, writing
> >=20
> > 	#define ARM64_FEATURE_MASK(x)	(x##_MASK)
> >=20
> > obviously looks redundant and if we look at the users updating them tur=
ns

> If the two are strictly equivalent, then let's use the former as it
> results in a tiny diff.

They are.  I'm tempted to move the define to a KVM header to discourage
new use.

> Constantly repainting these files causes no end of conflicts when
> rebasing large series (pKVM, NV...), and makes backporting of fixes
> much harder than it should be. Specially considering that there is a
> single occcurence of an ID register with non-4bit fields.

> Just put a FIXME in the various files so that people do the repainting
> as they change this code.

OK.  It does result in the half transitioned files looking really messy
which for the main arm64 code I'd expect to generate complaints but like
you say the conversions have their disadvantages too so if you're OK
with it.

--uTei0FHqHVjcuC9J
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOkTtoACgkQJNaLcl1U
h9CX2wf+Mr0zawe5JO17RyNpOixFQbndFDrQ6JzyoyjinZK+cBjbADY3prZW16hp
CCFP/ftgz2YyhtWB0KLmg4fEu8uFNSpigJTgp6QBQrcNMwxTmw7deXNhBjO4XmUi
wkI0k5icx1lAMKAL3GtzQ7iIJx/t7N1SfesN5O+cbc84JLERXCu+lceQMXDWaz7C
qcCFkE6623GbytuBg3w6OOUmqB8SlRYQ9n8AMk8NEZ2YC+Urc6XokKfsnkPx5byR
tAN5rOLxRp7XZ27Ej3GWRxOWt/Gyu2AhY+X+9Ikqv+91Qs9nFhtCO1eBpXCQW8J7
QmS1xDMeVtlehDH+1w1XUdDXVh5dGg==
=Jggo
-----END PGP SIGNATURE-----

--uTei0FHqHVjcuC9J--