Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1110c180e6586e213ea180920cbe6215b68a42be.camel@ndufresne.ca>
Subject: Re: [PATCH] media: v4l2-ctrls: Fix doc for
 v4l2_ctrl_request_hdl_find
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Miaoqian Lin <linmq006@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 22 Dec 2022 09:01:04 -0500
In-Reply-To: <20221222115638.768143-1-linmq006@gmail.com>
References: <20221222115638.768143-1-linmq006@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Le jeudi 22 d=C3=A9cembre 2022 =C3=A0 15:56 +0400, Miaoqian Lin a =C3=A9cri=
t=C2=A0:
> We should call v4l2_ctrl_request_hdl_put() instead of
> v4l2_ctrl_request_put_hdl(). Fix the typo.
>=20
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  include/media/v4l2-ctrls.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index e59d9a234631..7788eeb3e2bb 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -1343,7 +1343,7 @@ void v4l2_ctrl_request_complete(struct media_reques=
t *req,
>   * @parent: The parent control handler ('priv' in media_request_object_f=
ind())
>   *
>   * This function finds the control handler in the request. It may return
> - * NULL if not found. When done, you must call v4l2_ctrl_request_put_hdl=
()
> + * NULL if not found. When done, you must call v4l2_ctrl_request_hdl_put=
()
>   * with the returned handler pointer.
>   *
>   * If the request is not in state VALIDATING or QUEUED, then this functi=
on