Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp316635rwj; Thu, 22 Dec 2022 08:06:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/1zIh8wZGTEE3yss5nu708mZOgmIu3Joh/zVBfBgi3Mm8fz2mLHLcegjKMK1swsWvx4PM X-Received: by 2002:a05:6a20:939a:b0:af:9539:a29e with SMTP id x26-20020a056a20939a00b000af9539a29emr7724769pzh.16.1671725174522; Thu, 22 Dec 2022 08:06:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671725174; cv=none; d=google.com; s=arc-20160816; b=uRgHOQt/8ugz6NfD3fI5dWuzouBqnGEPSE891I5aaP60AUYUTmxZ5ujNWyQJeqjyqZ EdhGDxmDbCjbIr/1QA07nBFKMd2vJrCpNPX1T0qdg6DGLWnimh3Z979DPfVVs4vd38T+ Q4PlpwckWlzaB+M8TJ5Z0QlOcA1JpaLii5i3zQ4B4ErBZXqE7CNmXJ3bIBb8d3tU7RYE rWsC0JZgzvzV3E4w7s6LovpH6bvewX7jsUJ+8EqfhBB0wlFOhzemd8TX+gWsCqZJUR+F hDGvzoTsk5VUCeNaq+JEaa9pCuDFwZjytDeHFeLO7LQsGTfoHc02aYbwSw1V9bEYBCHL hTXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=Ih6VrsxX6xsnaFe2iTJFmjZ8gev/py4lccLRL328Eog=; b=p0q9pTIe0iFY5TxhfOEVCeZYq2slwif+9mn+pD4lUdjbEOLFuQBf8w6z45XYTWWxJt 2LRl7uiGmQf7P+n8Rxcc7uxR/ZXXSFAzyc1Or63cekrYZIgzUyjW1+eM9GYowU37KPIy S6DVH1BAY5Qqsy0+UjFOtVrJArzn2wNpCRdB+BvkIHdq3jo93DjM7KOA3Lf/bFadVvcu TBvcxcKfm4gxp2TLzzl14zOfMKnEco/SQB5tc9eVmxV6Ru4Tleev8coPlo/IynJo/yLt A+JGCjluZpJeiYlSsobn0lFQDmbUJClIt/xWLCzEcH4NxWHgXAVSp3chNVVJzeRdYAV1 VuYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=m5QvS6b9; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i16-20020a63e450000000b0046f583c8c4asi1121849pgk.315.2022.12.22.08.06.04; Thu, 22 Dec 2022 08:06:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=m5QvS6b9; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235502AbiLVPnH (ORCPT + 67 others); Thu, 22 Dec 2022 10:43:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235579AbiLVPmo (ORCPT ); Thu, 22 Dec 2022 10:42:44 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AF282876F for ; Thu, 22 Dec 2022 07:42:14 -0800 (PST) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1671723731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ih6VrsxX6xsnaFe2iTJFmjZ8gev/py4lccLRL328Eog=; b=m5QvS6b9UKW2jepjYsi3E0HInhHFejWF2drz8QgMtDuhrvSswjAHKO0z/iHqWQZnGsW/mn JWClHzqHotLspB1Jfr/G71iuoMqduk5l6elswZ5wXBviT0ijZXg940f7dz9nUZ29gTQ6fk dCe0xJDnGP4rXGC/vbUzDffElvS6xFms76zvc5qTQ1aBxtvbt7PnugHwyTmwRKMmgl3o8M GZRaRnYQRXtI3mcDSswD4RkgB9URrBzjFbhtI7OhSwdz6s6hAQgt0lgwWA42qYr9DxPRMm Un72SIHYzKaQUhsSgVsj/ZdYkrnxMwpD0sZ8drOLfDOT3v9RRjvn2n+YJNv1BA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1671723731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ih6VrsxX6xsnaFe2iTJFmjZ8gev/py4lccLRL328Eog=; b=xP3mL+OXBh4Dh0FeGyUo6iIcfmh+DAxj71xS5EKEsw6EzX8jcoafqU/uc2oJAXRQyTj1ez hrrZdjXCy+hI9mCg== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v3 5/6] printk: introduce console_get_next_message() and console_message In-Reply-To: <20221221202704.857925-6-john.ogness@linutronix.de> References: <20221221202704.857925-1-john.ogness@linutronix.de> <20221221202704.857925-6-john.ogness@linutronix.de> Date: Thu, 22 Dec 2022 16:47:39 +0106 Message-ID: <87bknva1jg.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,INVALID_DATE_TZ_ABSURD, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-12-21, John Ogness wrote: > +static bool console_emit_next_record(struct console *con, bool *handover, int cookie) > +{ > + bool is_extended = console_srcu_read_flags(con) & CON_EXTENDED; > + static char dropped_text[DROPPED_TEXT_MAX]; > + static struct console_buffers cbufs; > + static struct console_message cmsg = { > + .cbufs = &cbufs, > + }; @cmsg should not be static. The whole point of the console_message wrapper struct is so that it can sit on the stack. John Ogness