Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cb3c3a1e-ec10-1e7b-1b21-3cb250f92ecf@denx.de>
Date:   Thu, 22 Dec 2022 16:21:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] dt-bindings: leds: Mark label property as deprecated
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Christoph Niedermaier <cniedermaier@dh-electronics.com>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Rob Herring <robh@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        kernel <kernel@dh-electronics.com>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
References: <20221122111124.6828-1-cniedermaier@dh-electronics.com>
 <Y3y/S5COG7VPbsqL@duo.ucw.cz> <3f4c89a3-8955-ce41-ac2a-cee9b0ed5210@denx.de>
 <20221130191905.GA2631320-robh@kernel.org>
 <4043d693-7739-4709-8551-9f476031db70@denx.de>
 <38c9aae4-0cae-a5a6-7c76-f23edf259dab@gmail.com>
 <e6b166b399314a91bc97db591c8ec5a7@dh-electronics.com>
 <Y6RgjV4FT57SaTQw@duo.ucw.cz> <3c555cae-999f-ccd2-d114-00b92abd19ba@denx.de>
 <Y6RwAcXnfY/zjk/b@duo.ucw.cz>
Content-Language: en-US
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <Y6RwAcXnfY/zjk/b@duo.ucw.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/22/22 15:56, Pavel Machek wrote:
> On Thu 2022-12-22 15:01:44, Marek Vasut wrote:
>> On 12/22/22 14:50, Pavel Machek wrote:
>>> Hi!
>>>
>>>>>> This part I understand. What is not clear to me is, why is 'label' being
>>>>>> un-deprecated.
>>>>>
>>>>> It shouldn't be. It seems to be Pavel's ad-hoc decision.
>>>>
>>>> Is there a majority agreement that the "label" property remains
>>>> deprecated?
>>>
>>>
>>>> If so, I would say we can mark the label as deprecated.
>>>>
>>>> On the other hand, the new generated standardized sysfs name does not seem
>>>> to provide a full replacement for the "label" property.
>>>> What is still missing?
>>>
>>> Having reasonable naming of the LEDs is pre-requisite for deprecating
>>> label property.
>>
>> As far as I can tell, function and function-enumerator is the reasonable
>> naming. Jacek seem to confirm that. I would say, label can be deprecated .
>> What is the counter-argument for why it should NOT be deprecated ?
> 
> When the label is no longer neccessary for naming leds, it can be
> deprecated. AFAICT, that is currently not the case.

I'm sorry, this is not a counter-argument, this is hand-waving .

Do you have anything to back your claim that the label is currently 
still needed, contrary to what the DT bindings document claims for 
years? "This property is deprecated - use 'function' and 'color' 
properties instead. function-enumerator has no effect when this property 
is present."

"
commit c5d18dd6b64e09dd6984bda9bdd55160af537a8c
Date:   Sun Jun 9 20:19:04 2019 +0200

     dt-bindings: leds: Add properties for LED name construction

     Introduce dedicated properties for conveying information about
     LED function and color. Mark old "label" property as deprecated.

     Additionally function-enumerator property is being provided
     for the cases when neither function nor color can be used
     for LED differentiation.
"

It seems the function and function-enumerator is very much the 
replacement for label, except standardized. If that's not the case, do 
elaborate. If there is a special case that is not covered by it, do 
point it out.