Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i9e814621:Fastmail
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Peter Delevoryas <peter@pjd.dev>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 0/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command
Date:   Thu, 22 Dec 2022 09:13:57 -0800
Message-Id: <9D98FD36-FA3B-4C9C-A470-69A52FD80677@pjd.dev>
References: <8a0a90511222d3161bfe2984f6b14f82206b8930.camel@redhat.com>
Cc:     sam@mendozajonas.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, joel@jms.id.au, gwshan@linux.vnet.ibm.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <8a0a90511222d3161bfe2984f6b14f82206b8930.camel@redhat.com>
To:     Paolo Abeni <pabeni@redhat.com>
Precedence: bulk


> On Dec 22, 2022, at 2:44 AM, Paolo Abeni <pabeni@redhat.com> wrote:
>=20
> =EF=BB=BFOn Tue, 2022-12-20 at 21:22 -0800, Peter Delevoryas wrote:
>> NC-SI 1.2 isn't officially released yet, but the DMTF takes way too long
>> to finalize stuff, and there's hardware out there that actually supports
>> this command (Just the Broadcom 200G NIC afaik).
>>=20
>> The work in progress spec document is here:
>>=20
>> https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.2W=
IP90_0.pdf
>>=20
>> The command code is 0x58, the command has no data, and the response
>> returns a variable-length array of MAC addresses for the BMC.
>>=20
>> I've tested this out using QEMU emulation (I added the Mellanox OEM Get
>> MAC Address command to libslirp a while ago [1], although the QEMU code
>> to use it is still not in upstream QEMU [2] [3]. I worked on some more
>> emulation code for this as well), and on the new Broadcom 200G NIC.
>>=20
>> The Nvidia ConnectX-7 NIC doesn't support NC-SI 1.2 yet afaik. Neither
>> do older versions in newer firmware, they all just report NC-SI 1.1.
>>=20
>> Let me know what I can do to change this patch to be more suitable for
>> upstreaming, I'm happy to work on it more!
>=20
> This series is targeting the net-next tree, you should include such tag
> into the patch subjected.
>=20
> We have already submitted the networking pull request to Linus
> for v6.2 and therefore net-next is closed for new drivers, features,
> code refactoring and optimizations. We are currently accepting
> bug fixes only.
> Please repost when net-next reopens after Jan 2nd.

I see, thanks, I=E2=80=99ll resubmit later.

>=20
> RFC patches sent for review only are obviously welcome at any time.

Oh good point, I should have submitted it as an RFC.

>=20
> Thanks,
>=20
> Paolo
>=20