Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Thu, 22 Dec 2022 18:40:54 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Michael Rodin <mrodin@de.adit-jv.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Dave Airlie <airlied@redhat.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        michael@rodin.online, erosca@de.adit-jv.com,
        laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH] drm: override detected status for connectors which are
 forced on
Message-ID: <20221222174054.tsj4rfzejrl3cc7g@penduick>
References: <20221107123657.24vbgep3jqeklb2s@houat>
 <20221215170359.92422-1-mrodin@de.adit-jv.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="p37xnirrqan5m5yb"
Content-Disposition: inline
In-Reply-To: <20221215170359.92422-1-mrodin@de.adit-jv.com>
Precedence: bulk


--p37xnirrqan5m5yb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Dec 15, 2022 at 06:03:59PM +0100, Michael Rodin wrote:
> The detected status of a connector should be ignored when a connector is
> forced as hinted in the commit d50ba256b5f1 ("drm/kms: start
> adding command line interface using fb."). One negative side effect of
> not ignoring this is observed on the RCar3 SoCs which use the dw-hdmi
> driver. It continues executing drm_helper_hpd_irq_event even if its
> connector is forced to ON. As consequence drm_helper_hpd_irq_event calls
> "detect" so the connector status is updated to "disconnected":
>=20
> [  420.201527] [drm:drm_helper_hpd_irq_event] [CONNECTOR:76:HDMI-A-1] sta=
tus updated from connected to disconnected
>=20
> This status is corrected by drm_helper_probe_single_connector_modes short=
ly
> after this because this function checks if a connector is forced:
>=20
> [  420.218703] [drm:drm_helper_probe_single_connector_modes] [CONNECTOR:7=
6:HDMI-A-1] status updated from disconnected to connected
>=20
> To avoid similar issues this commit adapts functions which call "detect"
> so they check additionally if a connector is forced and override the stat=
us
> returned by "detect".
>=20
> Fixes: 816da85a0990 ("drm: handle HPD and polled connectors separately")
> Signed-off-by: Michael Rodin <mrodin@de.adit-jv.com>

As reported here, this breaks vc4, and probably i915:
https://lore.kernel.org/dri-devel/20221107123657.24vbgep3jqeklb2s@houat/

Maxime

--p37xnirrqan5m5yb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY6SWpgAKCRDj7w1vZxhR
xRloAQDBPrPvSE361m058JRvYOTalUo/1dvgEQncDKUjTGzGkwEArxTusD7G9wLm
INu9zWHVV0EzE8s9rPJ1rnmAq2ukAAQ=
=0ovf
-----END PGP SIGNATURE-----

--p37xnirrqan5m5yb--