Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Dec 2022 12:08:30 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>,
        linux-renesas-soc@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        John Crispin <john@phrozen.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Marek Vasut <marex@denx.de>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Woojung Huh <woojung.huh@microchip.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        George McCollister <george.mccollister@gmail.com>
Subject: Re: [PATCH v5 net-next 04/10] dt-bindings: net: dsa: utilize base
 definitions for standard dsa switches
Message-ID: <Y6S5Ple5SURq0QSU@colin-ia-desktop>
References: <20221210033033.662553-1-colin.foster@in-advantage.com>
 <20221210033033.662553-5-colin.foster@in-advantage.com>
 <1df417b5-a924-33d4-a302-eb526f7124b4@arinc9.com>
 <Y5TJw+zcEDf2ItZ5@euler>
 <c1e40b58-4459-2929-64f3-3e20f36f6947@arinc9.com>
 <20221212165147.GA1092706-robh@kernel.org>
 <Y5d5F9IODF4xhcps@COLIN-DESKTOP1.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Y5d5F9IODF4xhcps@COLIN-DESKTOP1.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHh5Vi9uczJCZS9tV1BadGprWkVFVVUxNzFJZ2tMRUkrb2VWTHA1cjNRUjhK?=
 =?utf-8?B?UEJiR3JHdHBJQWY1YTZOQnlrWit4VWFMKzFyNmZKZ3BSTDFaQzdVeEZXVGhI?=
 =?utf-8?B?dUY4THR5Y0hqMEdTdDZ2M3FCQU9SaEpOMGE3azlqWk5OZFV2Qmp2dTVtYjd5?=
 =?utf-8?B?RWg2aldhbU9PaTVsMEVPenYzWVFoVUxSdjE2aEQ5aDl5VXNOenFqL014aFYx?=
 =?utf-8?B?cFBZUE53Z3F2LzF0Y0V0SUZtbXdWUi9kd25neEFtbG5VcGltK2RMNHBSVzJx?=
 =?utf-8?B?TUlQN1EzQ1pBTlFCNVVQSGhobTB4bUFOWTlVN2NYTC9mQnhWNXQzaUVDWUNJ?=
 =?utf-8?B?ZER3ZkJYYkpaaUlLSGZuSmJ4WldCd0dta1VwYytnR1p4UjdGVGxHOVNINzVV?=
 =?utf-8?B?VHVyMXMwLzRiR0FWa1QvM1NOcUZhTG1NbDRSdk51bm54L3hMNjN0MUo3WDZG?=
 =?utf-8?B?MnpqVjhUeDgvc3RrMlNnazMyZ2d6enFWSXpicGlTZFZJamFJVUlCbVEvTmhh?=
 =?utf-8?B?TWVvM1QxU3lKZEVMbEVGU003akF0U3pDWENncVdRcVZTNmhyRVlVRkhLS1pZ?=
 =?utf-8?B?MGMvb01QdEpqcFBnRGszZ2tFbWVTMklTRW10RFNsZ0FEMFR1M211cXNDWWZh?=
 =?utf-8?B?eldDdHp2aTl5bTNhZ1AyVlpKbFJRRGhXVzFoSWxuUi9KTUJweEZJaHpGNTlJ?=
 =?utf-8?B?Q00vejZmeFJGQ1ZCdlNZc0hZSlJNM05yTS9PVkw3eVJJSFdqV1lSSE1zWmM2?=
 =?utf-8?B?L21jdEQ4N2I5ZVZ0anVVY252bmhOVysyUmRJRmYraEZHb01WTTd6dlBWemxY?=
 =?utf-8?B?dUl4Tnp6U0hZVzhvdjNqNHozK0VkOExmTUdkVSsrKy8wNVkxSUt6U2ZHTnk0?=
 =?utf-8?B?bVF4eThEeUsxY3ZPR0pYK2RJd0ZHTWdVYzl3QS9EdzZJMUl6Q1g2aHNPZ3pG?=
 =?utf-8?B?OEoxczB0RVgwYXdnMEpqTTVPR1VsSmJ0U3ZaMUVVNzNUVDFJMzRib1VSVXR3?=
 =?utf-8?B?OTVFeERDM0E2RHRrN3JCaHBhaWpNY3kzdDRoelhITzdZWGIzanhQR29vQlVl?=
 =?utf-8?B?SHkyaHV2d2ZCNy8wUW9RZXV5WDRZRlNYZzJyaGRkQnlMMzd2WXdGYWplUERj?=
 =?utf-8?B?T0VYa1Mycmtxdyt5UEd1ZHV4aXcvNFBES0xLWkk0azZsQXFRWFhkN2xQRmxX?=
 =?utf-8?B?blBORjNZVFlRMlZLV0RoZW05OC9oL01WNjc2VGN3NHUyZ0MzbTF4bWZ0U3I3?=
 =?utf-8?B?RVNYb1JjSUdIanRhRi9WNE56b3NkWFl5MUpBQytYRnJPV2xWcUFCbmlqL1JC?=
 =?utf-8?B?YzhLV0tRaWdvUHplYUwwcnhvKy9VTGQxOGtSZzU5ZlZacjV4TzRqM01LSTM0?=
 =?utf-8?B?eDRoKzh2RWcyMVBIYUpodHMyZjA5Q2FaUUdLWjRqc05sV3IyNzRZbnZXTzRW?=
 =?utf-8?B?Nk9NNW5zY1JUdklyQ2NoNFVyNXkwVUNIMFJTcDNQeHU5QmJpRlUyMzdqZG9n?=
 =?utf-8?B?QnF4dGNlZyt5YUZ1NVpLOHdkWC9NUHBNcG1SQVkyaGt1dFZJVXJzdWJYaTQz?=
 =?utf-8?B?SkZ0ZXpDYXhpVndLYmdVMTBsK2xLVUdjNGF5UGwxL1V5My90c0N3UUVpeDRH?=
 =?utf-8?B?WDlQb3YvSGtlSWN4ck45eGZGNzBvbmlpVEova2JtNUxUYzdrWFBTWnRXMHNp?=
 =?utf-8?B?WUFZek51YUVsT3BQWDl3dFFITGJyTHlGWCtXMTBuaW1UbVhwb01YMkVrMUMx?=
 =?utf-8?B?L3RYSGgwMXhwM1ZnWkIwcHBDYm9CVUxEVzY2cWZqOHljVndUc2YvbVNCS1pr?=
 =?utf-8?B?aUxNS0ZlZGVTcXlIZUV6ZlJmKzk2RHE4bitnWnA4TGoyUlMzTW5CYkxaSVR3?=
 =?utf-8?B?d0FtMklBYW1ZSVppY2EzWUFkOFNBM0FsZ2lkb1FQSyt5d202M3dhQzZxaXJI?=
 =?utf-8?B?Umd0VXJsV3BIajE3ZDNBalZVRlZDZitoNkY1aUJ6b0o4Rk9Ic3ZqaTdBVDhi?=
 =?utf-8?B?MHRnaTdQYnlJNkR6RnBzRVlFTU9yNldhMTZTblJsOW5hUmtpMXdDLzl3ck1l?=
 =?utf-8?B?aWFxZmozRVZhU1hja09meEdPbjFMWGFpazhZa1pXWS9HVjk2NGxwUkJrUDc3?=
 =?utf-8?B?TUNuZUxwZ2FUMU5tcGE2UWZiU1htUGg1NDUzQnlDdU1qc2dnaGVEQ3VLb2tN?=
 =?utf-8?Q?Rpq0riHBB9rxk4fJ8Xj/abQ=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d86bba6-8d35-43e3-e4ba-08dae4584faa
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2022 20:08:37.5107
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ai9vfrbp6cSfJfw//lmqY9wHry4EwmB78YFFOmb9dfcU3Mi0NP91wogPcRv9Udh/JE17os98Dqv+fWxZkStnKI+ncmUp4WYeG/NAjWE1X4g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6610
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 12, 2022 at 10:55:19AM -0800, Colin Foster wrote:
> Hi Rob, Arınç,
> 
> On Mon, Dec 12, 2022 at 10:51:47AM -0600, Rob Herring wrote:
> > On Mon, Dec 12, 2022 at 12:28:06PM +0300, Arınç ÜNAL wrote:
> > > On 10.12.2022 21:02, Colin Foster wrote:
> > > > Hi Arınç,
> > > > On Sat, Dec 10, 2022 at 07:24:42PM +0300, Arınç ÜNAL wrote:
> > > > > On 10.12.2022 06:30, Colin Foster wrote:
> > > > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > > > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yam
> > > > @@ -156,8 +156,7 @@ patternProperties:
> > > > 
> > > >       patternProperties:
> > > >         "^(ethernet-)?port@[0-9]+$":
> > > > -        type: object
> > > > -
> > > > +        $ref: dsa-port.yaml#
> > > >           properties:
> > > >             reg:
> > > >               description:
> > > > @@ -165,7 +164,6 @@ patternProperties:
> > > >                 for user ports.
> > > > 
> > > >           allOf:
> > > > -          - $ref: dsa-port.yaml#
> > > >             - if:
> > > >                 required: [ ethernet ]
> > > >               then:
> > > > 
> > > > 
> > > > 
> > > > This one has me [still] scratching my head...
> > > 
> > > Right there with you. In addition to this, having or deleting type object
> > > on/from "^(ethernet-)?ports$" and "^(ethernet-)?port@[0-9]+$" on dsa.yaml
> > > doesn't cause any warnings (checked with make dt_binding_check
> > > DT_SCHEMA_FILES=net/dsa) which makes me question why it's there in the first
> > > place.
> > 
> > 
> > That check probably doesn't consider an ref being under an 'allOf'. 
> > Perhaps what is missing in understanding is every schema at the 
> > top-level has an implicit 'type: object'. But nothing is ever implicit 
> > in json-schema which will silently ignore keywords which don't make 
> > sense for an instance type. Instead of a bunch of boilerplate, the 
> > processed schema has 'type' added in lots of cases such as this one.
> > 
> > Rob
> 
> What do you suggest on this set? I think this is the only outstanding
> issue, and Jakub brought up the possibility of applying end of today
> (maybe 5-6 hours from now in the US).
> 
> It seems like there's an issue with the dt_bindings_check that causes
> the "allOf: $ref" to throw a warning when it shouldn't. So removing the
> "type: object" was supposed to be correct, but throws warnings.
> 
> It seems like keeping this patch as-is and updating it when the check
> gets fixed might be an acceptable path, but I'd understand if you
> disagree and prefer a resubmission.

Heads up on my plan for this. I plan to re-submit this on Monday after
the merge window with the change where I move the $ref: dsa-port.yaml#
to outside the allOf: section, and remove the object type as the above
code suggests. Hopefully that's the right step to take.