Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Dec 2022 22:21:41 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Jean Delvare <jdelvare@suse.de>
Cc:     Sean Young <sean@mess.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pwm@vger.kernel.org
Subject: Re: [PATCH] media: rc: Drop obsolete dependencies on COMPILE_TEST
Message-ID: <20221222212141.yhn7xazsphtmiint@pengutronix.de>
References: <20221121170911.7cd72bfc@endymion.delvare>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y5vizb7n5hvnx3ao"
Content-Disposition: inline
In-Reply-To: <20221121170911.7cd72bfc@endymion.delvare>
Precedence: bulk


--y5vizb7n5hvnx3ao
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Mon, Nov 21, 2022 at 05:09:11PM +0100, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>=20
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
>=20
> As a minor optimization, this also lets us drop of_match_ptr(), as we
> now know what it will resolve to, we might as well save cpp some work.
>=20
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Sean Young <sean@mess.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: "Uwe Kleine-K=F6nig" <u.kleine-koenig@pengutronix.de>

FTR: I discard this patch from the PWM patchwork as "handled elsewhere".

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--y5vizb7n5hvnx3ao
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmOkymIACgkQwfwUeK3K
7An8NAf/Z6B3fRFOKcJStjrDLjG8JX6fW3yclViwo4hKEHsODYu5PiEMkd+vo9Q5
EAHYY3k5hHJO3RBvhZ9Pz9srXZhVazyskV/0OToryX9GOiYxYd4VzB8/1+AoPN1D
gqF35c0idYMwf9oiU9Wer9alm89Sy7I0+V/QsFZpN/DH8cdpx5AISP0Q2OhKmc9T
UerviITyf387X+Gxy/xLiZ7ayuu+OWolFaB9i215sIoa81vUOdqv5bgeeNE9YoP6
YlQ8fzJvEiJzczZ8NUnBTcxduXWLpye9TD1qxBEwOetWYVKfxZ7fluksg5L5053q
8nMMy6cBt+c0XLwck9fno1ukKw1QiA==
=rGaE
-----END PGP SIGNATURE-----

--y5vizb7n5hvnx3ao--