Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Dec 2022 15:20:54 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Xu <peterx@redhat.com>,
        Muchun Song <muchun.song@linux.dev>,
        Miaohe Lin <linmiaohe@huawei.com>, stable@vger.kernel.org
Subject: Re: [PATCH v1 2/2] mm/hugetlb: fix uffd-wp handling for migration
 entries in hugetlb_change_protection()
Message-ID: <Y6TmVtE0gYqWStez@monkey>
References: <20221222205511.675832-1-david@redhat.com>
 <20221222205511.675832-3-david@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221222205511.675832-3-david@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JggGe55zZNbSOrvY0ziRkXhLr5rcSNzTmJLhw/Rc4d8+wtHE/gFk9jBGsP0h?=
 =?us-ascii?Q?plW/LajKsBaOYY/HcwAW6KyfMz5BtdFloxf2qo3kHT4005LK/rhpcbOCu3Yo?=
 =?us-ascii?Q?UWzi5cpcxuuZ5zBnSeYGO36/hgrQraZbszS/W5mmpATpUcZlqQ1j3oYFd+th?=
 =?us-ascii?Q?JERJtv2JUKso4q4rPNbPznjw7Izcm/iRM0xUq1OdOXCV8n+WTYtX5fdv+uWU?=
 =?us-ascii?Q?4YVMQu6lnEVFQGuua+AAom+7Yp2KmT75fERiL7m7R36iNV30pXI0zMogdZgJ?=
 =?us-ascii?Q?MDuBFRb50yrl7Va45U8M8XkYz5CyKWUJnAvcq3zQqw/mZn0u2A6GU3WyQStE?=
 =?us-ascii?Q?Pkn9a7RlQQhBUZPXrhnhX52gsqf2jp3x0YVbB7W26IS6Qs34/L1hf7uKaT4Z?=
 =?us-ascii?Q?tcmnIhBuPS7ZI4mIrH0cf3nouWCryIbRfKJF4ECp7KMWLJeFaIbCwsQBbEHO?=
 =?us-ascii?Q?rumVH1J/HL44geL+aNxoe/3yZC74gyAhAJcBFeErRBxdSwHqBy1xtlpQWYl6?=
 =?us-ascii?Q?o/2UiILvGH+vSr/bmqnzGOFdLRwfOHD2+4WjWml689FL2OEwlmpxEbt//QpK?=
 =?us-ascii?Q?9xLAI3OFTEX0hk5DQ66LjcSVu+9mnht6BShYI6LHUKjf0i/txyCNEZPTY0nq?=
 =?us-ascii?Q?1yXnb4f539yxC6m/Oup1PX+QTpFaBAgE45Aa0H80m86CR9QpiHTq4yW1+M3n?=
 =?us-ascii?Q?H8CegtXFP7ZKNqKZO3T3vFP9mBTX/eqaz+Cz2lwXpGAhzvHjsfNXOPpgEce1?=
 =?us-ascii?Q?q55Q8Wcwy71pZP/YOpzGQHa1av8v6t05U0RQuVYBBmW3luO2ParvmSutwPQ7?=
 =?us-ascii?Q?u19EPgRXmVyDojSfeaQALeLK9NiFMZPwal7LEYhZAFWSk+vXVVFYPwIl3yDW?=
 =?us-ascii?Q?HNL6VoWPd8k2laA+0gDRrDDSOMGyhAr/PZMA8NmDxeV3vhE3V+k40fuNuSQ8?=
 =?us-ascii?Q?hSPwCdJHjXk3EBOLdPiOc9bUWM61x4IKnL3YU3/zTW/lNt1JRS/KzRN1kyLd?=
 =?us-ascii?Q?wMlRYjVt70etG6XiUNB3Z4+TLOyp0zTMNFRIrfQPtWFiejyJUcl9Cjc50jfu?=
 =?us-ascii?Q?vdyMmJC+4cODSv38z+e3W19X+8jIoBxs2R5RhXumxuJNvX94iQqx9Yegoc5T?=
 =?us-ascii?Q?dtXhkCTYMIxYkXeF+6HFcjFYA89Ek1Tb0dF3yZHLIGQF0eK8lKUHefEQUyxW?=
 =?us-ascii?Q?tHYIPa+ulLBPwRF7oC2FUgp0EEmcSzB4UXqlqJL7Z0/nN3h2nbHx3a4VWXeM?=
 =?us-ascii?Q?NvgBZGvUZ2xsFtEOB0tEzXbthkl86hzFt/xME8xXrGq8uTktuy0MiIGrwrsp?=
 =?us-ascii?Q?fqtVawnhj7tAbUXW0BTA9Ywy+DgrzrSUCQ4SuXPb0TOYJ/BsmWQEvDvzKMEC?=
 =?us-ascii?Q?gLEyq1xCjUZFBY17fCHdWvOh44IgNs8rxZxTikqkWV/qSkzBpd8xhILns8ty?=
 =?us-ascii?Q?xOU8KGUxZ6P3XTO+SkjvdF6ZXRiVEeUrbLgKyHgWOUxIuKqo6Ty20kEznILt?=
 =?us-ascii?Q?D1keOAZ28p2pYXhBfO+g0qIOkGQY1x5YVzLTU5nN0h38GKtpJE8fXr2nmPXq?=
 =?us-ascii?Q?vKYLk+EaE6cHeNrDfkFBTcL79xiFrxsPN34ocCo6ccSq0LphgXe1+L4Zu93Z?=
 =?us-ascii?Q?og=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c568290c-7262-402d-019a-08dae4732e12
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2022 23:20:57.3212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ma1JtNkmM8kIGV2fWVdaeXkdPFISNcUbfvCg/BQyLy1Gbt/oUQ1BkoLqKxeIvkIMCOytAhvd65trki8t8IPUng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5210
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-22_10,2022-12-22_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 mlxscore=0
 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212220196
X-Proofpoint-ORIG-GUID: 8Z7sOiV_TqGvl2Wlz8gUZ8hKCaKrdLoP
X-Proofpoint-GUID: 8Z7sOiV_TqGvl2Wlz8gUZ8hKCaKrdLoP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/22/22 21:55, David Hildenbrand wrote:
> We have to update the uffd-wp SWP PTE bit independent of the type of
> migration entry. Currently, if we're unlucky and we want to install/clear
> the uffd-wp bit just while we're migrating a read-only mapped hugetlb page,
> we would miss to set/clear the uffd-wp bit.
> 
> Further, if we're processing a readable-exclusive
> migration entry and neither want to set or clear the uffd-wp bit, we
> could currently end up losing the uffd-wp bit. Note that the same would
> hold for writable migrating entries, however, having a writable
> migration entry with the uffd-wp bit set would already mean that
> something went wrong.
> 
> Note that the change from !is_readable_migration_entry ->
> writable_migration_entry is harmless and actually cleaner, as raised by
> Miaohe Lin and discussed in [1].
> 
> [1] https://lkml.kernel.org/r/90dd6a93-4500-e0de-2bf0-bf522c311b0c@huawei.com
> 
> Fixes: 60dfaad65aa9 ("mm/hugetlb: allow uffd wr-protect none ptes")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  mm/hugetlb.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz