Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b4185b9-1226-a547-3ef2-c9dc9310a2cc@intel.com>
Date:   Thu, 22 Dec 2022 15:50:30 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [RFC Patch net-next v5 01/13] net: dsa: microchip: ptp: add the
 posix clock support
Content-Language: en-US
To:     Arun Ramadoss <arun.ramadoss@microchip.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
CC:     <woojung.huh@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <andrew@lunn.ch>, <vivien.didelot@gmail.com>,
        <f.fainelli@gmail.com>, <olteanv@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <linux@armlinux.org.uk>, <Tristram.Ha@microchip.com>,
        <richardcochran@gmail.com>, <ceggers@arri.de>
References: <20221221094612.22372-1-arun.ramadoss@microchip.com>
 <20221221094612.22372-2-arun.ramadoss@microchip.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20221221094612.22372-2-arun.ramadoss@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWN3d3YrdXFiR1BRamYyTUhrbVcyenBrVmw4dlJtaVBVMWZrLzBZa3J3aTVq?=
 =?utf-8?B?eU0zNXpRSWRyaFFhVWxOZUIvUzEzMmNxM24xNzl3R09XLzF4VGN5NzE5SnRL?=
 =?utf-8?B?WU5YWTNQUDh5YTlkT01SdWVWMFBsMEY1SFBkYnAwRkphQnJYL29FdnovWmdo?=
 =?utf-8?B?d01qak9LOXowWWFRM29SQ0hJZmZUZFIrengwTUIrdHFDblMyZm5aVUlhUjhi?=
 =?utf-8?B?Z1JMTC9ZTll6dVdzemg3akdFR2l5SXkxdXN5N2I5MEQwYndWZ3kyM1MycUtL?=
 =?utf-8?B?Mi9SNnppNFh1WlBXUjJ4Y0JHWnVGK0E3eXlOUDlZZG9iYm85MDZvSkt1ZzVn?=
 =?utf-8?B?UWlmOWJTemNyVk9NYStKUEFRT1llMW1qU0RMM1hYZkNVQno5STRWbG9MMDBP?=
 =?utf-8?B?cWJubGoxdFF2cWdLY1N0YTZhMHhtRGVuSnBmQlpJa2lpN0VCKzNZVXhNeVRi?=
 =?utf-8?B?QUJmd2hvSWp4bndQOHBNMHpybnk0Z0s4UEt6RExha3c1R2pxL25kS3hwbXZ5?=
 =?utf-8?B?dzR3TGgxVEhudWtZUC9wc2xCU3FWSndnWG5Db2FIZWc5RzR3MlNUeWxueGMv?=
 =?utf-8?B?M1JkemEvK3dJVGZLS0FXNE5pb2VNM1BmeDB4V3U1ekZqOFF1dnVjc2xmdURy?=
 =?utf-8?B?d05ONWJYMC93clBWT3VJVGlCMmxVVWJ6clVnZExlTTNzL2g5dWE0Q0JCQlVY?=
 =?utf-8?B?azZSTE0xRHhsWkxZN3RHZlRtOTlVN1FCZW5TTUpPaVQ4UDdWM3J4M1VsQzRB?=
 =?utf-8?B?a1F0Z3BlamlEVWZFL1c4TGtBSkVzNVdXbzRJdjNrdTIyZC9YKzJvaFIrTlkx?=
 =?utf-8?B?Rm9ZV3ZrUVdYRTc3UlExMGJIVGxnN2dBOXJwb2hGbHpTM3JuRUs2NWJSUWtw?=
 =?utf-8?B?RUhvUUZGTnhCclAra0VWQWcybDIrVU5KcENxc1BPaTY3TEFvV1ZlbGtob0xt?=
 =?utf-8?B?N2xkaW1YbDgzV2pOMTlYcXNWR3VPeXgxbkY3allHS0tuZXh1M1dHdFhFL0E0?=
 =?utf-8?B?VVRiSURiQUMyUjB6cjNPSmdrRmpycEJZbE1uRlNMTHFZZmNBeU5hOUNPTndv?=
 =?utf-8?B?cnd1UTNoY28wUGRkZjhLUXB6Rnc0V1JqUWxtcmhVOFpDTWUzbkxxWGF6L2R1?=
 =?utf-8?B?Vll2L0MxZWlqUFdVMzF6cU0vMVN2QkVMaU9wTzVYUHVXcVVYZ2VId0NCNnk5?=
 =?utf-8?B?TUJMeDRtNFNnVE95a25HWWNPK0lEdVh6dzI4K2R5UnFyaDJ2WFpZUFVjd1JV?=
 =?utf-8?B?aE5GU2lYaUJwRVhTSktmYVRCSlZmUGNyYmdmNndDQmt0a0RqdEd3TkVrK1JF?=
 =?utf-8?B?OGtzQmpObWZiYjZoTlhtRllBR1lDbjZOUVV6YldPenkwNWFMK2RPTXhsSXc3?=
 =?utf-8?B?UlpxRXhUMTFPMUZObVZWZTh2bEljN2N1R0lTNUdabkVxK00xd3NBUldyK3U4?=
 =?utf-8?B?NHhYK2d2K1JMSTlxK25DZk1ER1JTUzBLOWpsT0QrdUlzNXA4NWtlRks3clhy?=
 =?utf-8?B?dnFEci9LTSswZEZCamlZMCtBM1ZPRHoxelhMRjlLeU9VU29waE8zc3VDR0ph?=
 =?utf-8?B?d0ZIdURrTXhwbnJLQnNrVithQUlRRGZTNTRTMXlGcVB3L0syYzRtRmV3RHFh?=
 =?utf-8?B?NXNqK2pESVIwdFJ1enExalYzb3JnZnZBNG5XbXIzTDl1clRFNnU3blh5dlJL?=
 =?utf-8?B?MlhqYk51cTE5TlhrSmhOQUZKNUZMYUhTb1F3OUhCbEhjKzRBR0QycGFUSUpp?=
 =?utf-8?B?elVGa0lMbVRjVUY4aTdaL3JnNkN3bDlVeWRwd2ZvdnFiNjY4U0c0NHU0YTFq?=
 =?utf-8?B?L29RMkY5SGxvZEIyZGhMS0NROSs1NFBuZWZWeFZDZE1mUGdxTXNoQ3dTdU9a?=
 =?utf-8?B?UTh5QUtLdExMaDFONjd6dmFRek5QaW52cWlJd2pDZU8yQTduR25SdkJIbkRJ?=
 =?utf-8?B?Sk1GS0pVS09yUFlTbXczNCtOSTV4bFpZN0VWakFGMGlrckdFY2xwYU5ibmJp?=
 =?utf-8?B?aEtGOWdKaFZnZGgvQllUaGY0NWdXbCt2ZnNMZzRxYnFMVE9udHdUNXJaOGFu?=
 =?utf-8?B?V1YyZm1pblUrQ0x3YU5CaUlpRTE4aWFyMkxlcVZvN05NK3QwNmFlWm1PSTJk?=
 =?utf-8?B?bDNxZTZxMEhLWEJBdWJkclJQc2xrWGVESjUyaTQySzJnVlp4ZDA2SkJXMUdv?=
 =?utf-8?B?SGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a45e126-18f2-4675-71fd-08dae477510d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2022 23:50:33.9842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YqKsI5t9tBSiK+ALQ7P2NgisWsGavXqkwFs8zNNo3JU3o+yuiYtaJkD7h0evLXjX1hCjwVm/R/NvC3BiXAVWvvBrR79hGA+y4TXY9CwFomk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7606
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/21/2022 1:46 AM, Arun Ramadoss wrote:
> From: Christian Eggers <ceggers@arri.de>
> 
> This patch implement routines (adjfine, adjtime, gettime and settime)
> for manipulating the chip's PTP clock. It registers the ptp caps
> to posix clock register.
> 
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> Co-developed-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com> # mostly api
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> v4 -> v5
> - Used the diff_by_scaled_ppm helper function in adjfine
> 

Thanks! This version looks good to me.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>