Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp962750rwj; Thu, 22 Dec 2022 18:12:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXuqMDGbJvtYzDBnvK59tqTqNwy9fmivPKwZZ4wXW2zSRz26Lawm68WEmp5Lfb59nDGmIl4m X-Received: by 2002:a05:6402:6c9:b0:46c:2c94:d30b with SMTP id n9-20020a05640206c900b0046c2c94d30bmr7970069edy.33.1671761569883; Thu, 22 Dec 2022 18:12:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671761569; cv=none; d=google.com; s=arc-20160816; b=isUy89aJUk0AKJH3KS3UjAQSlkVZ/8qKhyRFEunIKuwx72oCJcCiZdMWQszilw3wI8 7aRdpcCasspSBEKjWd2Tqm9Sfqm8bW84A1cz1rHmV5uEXmZ2z+67Apzb0sT1QSXzYhw8 3+8bsxqG3Mght5E/qtBksok5poOR2GhVEkJY9tfA0z8YpqUOg5LnvLHWu+sGizKcnkky rn2JXNfl0NVC0/S7Qr7XSS37LLv2CCt2BDpgySXpCpFPPzU3+TqHLhAwylzVNwXbwIVr 7RJr15TWVtnYi+s1qhLhMujiSYkN3oMZHVPVczifmcdX71syRq9xYVfmvyDKt8r9sDyk c0oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=V61v7o2qMnueojIDHZPqsNgrVDte2LSI7QH2SkLkZNo=; b=D13Q67n/edyXFjnGXCrJ6HJj+hTKFwVwLZ03hFjo8w66DYmZ45B0mUmkxiSastS9+I LMfYHXwAb3QioFL/Ctu9IVWq4UyynIFQ92/1czCG2p9yT5g4sfPiqesysZxD48FFbqOg 6qrYKtw54HPCk82pZ+WJB0CV1QeKEAm/PNLXd9jmJUd2B6YRiixzSOh6UIgkOOTBSF1F 9ndygpt97Q8Q9mRY9dG7RV3YZEUVQYtiY1OMTlVX2aOVy2s+qDPMrBn1+SgZh7hwnyBk lmnJ3YJ+PUhrlbCo9Gx2slh3ydP0f/WO49UhEq8XwUQ9WRK/SvHhN4jBhuDh/c2XiWQo i8Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iSkKnGD1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e24-20020a50a698000000b00467bbc3d62asi1710194edc.547.2022.12.22.18.12.34; Thu, 22 Dec 2022 18:12:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iSkKnGD1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235783AbiLWCKe (ORCPT + 67 others); Thu, 22 Dec 2022 21:10:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbiLWCKb (ORCPT ); Thu, 22 Dec 2022 21:10:31 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EED220BD9 for ; Thu, 22 Dec 2022 18:10:30 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id w15so3381324wrl.9 for ; Thu, 22 Dec 2022 18:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=V61v7o2qMnueojIDHZPqsNgrVDte2LSI7QH2SkLkZNo=; b=iSkKnGD11cub4SDAg2GZe0WUULRc3g0u1XlENGOVVCwXebdReZVkHL1WLa6m4/otJA w9JNwaVAovzNI0loDgLycfSkFCQ64rDkV0hG6gxxpg4RJLojaG/wQdAh0vs82G54DJS9 tTaxj0WirSFjEhx2fUepXewVtEwugtgojdo3Eo/Fm7a6f6TQ6z5c9q269Ds9APxKbdiA LGwZ+Ubor/WIzM9FLExydbBg/GTK6vV+CfFeFbB/tA4CKpnOGSjlLpSjhZBUpEAVM2xI epScqBw9fsgNkTFE+GHOLhp5k1ukiqjan+q107Wi0ip0Qc11hQL0CemSbpsCIc+67FsJ fpoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V61v7o2qMnueojIDHZPqsNgrVDte2LSI7QH2SkLkZNo=; b=Whmm3dgpRBcloApr8G9Xzw2UOWPhf2Arrtc2EfaDaNDwRVgYup4SiMdv52VdYZMd2S EuxHg2nuQkMBZ+3mAVngtzgKW3FzhOt58jVGCXPNP37FnZMWuS2hwv045x0HeeOYXeSx uoaObHiIa3E3yDE2GYHxHjpLIxL6JWfsXELdCLt0cP/67ogbujuxVnFmKY5LaPGmNm7x hdIYBkf37Kp5kQAOJi0cTxztc5kMegMS3+6ftRL5AF+m234i/L43/Hn2UEd8oTBrslHW rEMVUSjYnTu3YInA2QRS1ucv00RPYHbZjuNrvexhHN1jr/T1n0IgYo13L2HxJEqregfD eSMg== X-Gm-Message-State: AFqh2kq4+5SWVZYXskLnQx/IVhbm25NuW6qGdjYKc8FZUmyw7OF+kF/P xzIDL64ZlIraHgv+Be1ooK2rJg== X-Received: by 2002:a05:6000:16c4:b0:242:5083:abea with SMTP id h4-20020a05600016c400b002425083abeamr6224322wrf.69.1671761428736; Thu, 22 Dec 2022 18:10:28 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id j11-20020a5d452b000000b0022cc0a2cbecsm1849725wra.15.2022.12.22.18.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 18:10:28 -0800 (PST) From: Bryan O'Donoghue To: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, dianders@chromium.org, david@ixit.cz, krzysztof.kozlowski+dt@linaro.org, swboyd@chromium.org, konrad.dybcio@somainline.org, agross@kernel.org, andersson@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org Subject: [PATCH v6 00/18] mdss-dsi-ctrl binding and dts fixes Date: Fri, 23 Dec 2022 02:10:07 +0000 Message-Id: <20221223021025.1646636-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org V6: - Squashes a number of patches per Krzysztof's comments on bisectability - Adds in Acked-by Rob and Krzysztof V5: - Adds compat strings to bindings/display/msm/qcom,SoC-mdss.yaml - Dmitry - Re-orders simple fixes to the start of the series to allow backports - Dmitry - VDDA and drop of node-names - Krzysztof - Deprecates qcom,dsi-ctrl-6g-qcm2290 - Krzysztof, Dmitry - Expands set of updated files to include new msm8953 - bod - Converts to agreed compat string qcom,SoC-dsi-ctrl hence - - qcom,mdss-dsi-ctrl-msm8996 + - qcom,msm8996-dsi-ctrl - Adds RB where indicated for the compat strings. V4: - Moves the update of the example from patch #5 to patch #4 V3: - Moves declaration of mdss-dsi-ctrl into compat string declaration patch - Krzysztof, Dmitry - Renames qcm-2290 compat string to agreed compat "qcom,socname-dsi-ctrl" Dmirty, Krzysztof - Adds empty line after if clause in yaml control flow section - Dmirty - Adds Rb/Ack - Krzysztof, Dmitry, Doug, David - vdd* Looking into this some more, I don't believe vdd, vdda, vddio ought to be required properties. Its up to the PCB manufacturer and the panel in-use how that panel is powered. Powering the panel is not something that even necessarily needs to be done from the dsi-ctrl driver. Originally marking vdd* as required in the .txt was an error, its not a SoC level dtsi requirement. - clock-names Rather than replicate the clock-name in each if block I listed them with a specific description from a similar reference in usb/qcom,dwc3.yaml. https://lore.kernel.org/linux-arm-msm/eb80681f-2e0b-605f-0444-ec65562f74b8@linaro.org/ V2: https://www.spinics.net/lists/linux-arm-msm/msg116326.html - Moves the DSI PHY changes to a different later series. There are enough dsi-controller-main changes to justify its own standalone series. - The original phy-name binding change given discussion with Rob and Krzysztof became its own standalone series that has since been merged. https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg403214.html - Retains the drop of power-domain from yaml as a required property. I dug into the available dtsi. The apq8064 doesn't appear to have any GDSC which can be attached as a power-domain, which means the power-domain requirement is not universal across the various silicon versions. - Adds Dmitry's RB to power-domain drop - For the clock declarations I've * I noticed that the simple change I had worked for msm8939 but subsquently broke other dtsi which drove a bigger change to document the clocks on a per compatible basis. * Added compat strings in yaml. * Moved the allOf down later in the file to acomodate the if/then. * Number of clocks validated on a per compatible basis * The driver code which doesn't care about the number of clocks can still operate on the mdss-dsi-ctrl compat but the dts checks will validate against the compat string and yaml. - vdd descriptions Took the previous text I missed from the .txt file - Krzysztof, Dmitry Adds vdd, vdda and vddio to the required list. This exposes warnings in existing dtsi but the previous .txt declared these regulators as required. - Krzysztof V1: This series fixes up a number of dtbs checks which are being flagged adding in the msm8939 dtsi. When converting from .txt to .yaml a number of the parameters for the older msm8916 silicon were not transmitted into the yaml. Adding in the msm8939 which is a near 1:1 copy of the msm8916 in terms of dtsi triggers a rake of dtbs checks as a result. https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg403211.html Bryan O'Donoghue (18): dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint dt-bindings: msm: dsi-controller-main: Fix power-domain constraint dt-bindings: msm: dsi-controller-main: Fix description of core clock dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl arm64: dts: qcom: msm8953: Add compat qcom,msm8953-dsi-ctrl arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl arm64: dts: qcom: sdm630: Add compat qcom,sdm660-dsi-ctrl arm64: dts: qcom: sdm660: Add compat qcom,sdm660-dsi-ctrl arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl .../display/msm/dsi-controller-main.yaml | 249 ++++++++++++++++-- .../bindings/display/msm/qcom,mdss.yaml | 16 +- .../display/msm/qcom,msm8998-mdss.yaml | 8 +- .../display/msm/qcom,sc7180-mdss.yaml | 6 +- .../display/msm/qcom,sc7280-mdss.yaml | 6 +- .../display/msm/qcom,sdm845-mdss.yaml | 8 +- .../display/msm/qcom,sm8250-mdss.yaml | 8 +- arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +- arch/arm/boot/dts/qcom-msm8974.dtsi | 3 +- arch/arm64/boot/dts/qcom/msm8916.dtsi | 3 +- arch/arm64/boot/dts/qcom/msm8953.dtsi | 4 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +- arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +- arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +- arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 +- arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +- arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +- 18 files changed, 292 insertions(+), 52 deletions(-) -- 2.38.1