Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp1010502rwj; Thu, 22 Dec 2022 19:10:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXsYrNKwILKMf72U0fhpEF/MT1PFp9aITkTABTjg50eAQl6Ypm4kkdXJajK3Vdav1FyK1BS/ X-Received: by 2002:a05:6402:5285:b0:45c:834b:eb5f with SMTP id en5-20020a056402528500b0045c834beb5fmr7856423edb.42.1671765011903; Thu, 22 Dec 2022 19:10:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671765011; cv=none; d=google.com; s=arc-20160816; b=m6H47+Zz4EVQ4GtvZVtDYTyj3cKWNhUQUmjmgBHEwVChkMFfBJnV/PevSkyHK6HZsA 3gUV+1JJG0zOoDSoReVOSET7l7M4D+264DGKLUJ3mtH4sXM6m6IZpHKRuXTHyPRhAZFI SO8wl4+5aOa5xhvbe1Q2SEkPUcRdcEX+X+TOZDRRx3aKTsSdD+S4PziTPMfWTHMO80SO i1+NuL/grRFBJjqga0p41W2MHUKLej8H1hwvc3xXg2DqdlkftMqq8DMWeFDGqmGB+doj sQi8SfBhhBC7eRPVE6PptPOUq+527qkvFKJ9lrckrXneda0kdmr3dvSB+iAxPdy3A+eo 9Uxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:dkim-signature:from; bh=aTZp5bOGz4cs6GlFGSVsQyW2xPw/kIrGfYKJMSAAvD0=; b=LEX8DVQYK57SHnfQ0EebM7/0eyi+r/xEWJhnaiCrNnxVQEFgK5+aK2SqQm08lWTJ4O naxWAiZUdLQeWwZjgaLYFHb5Wknvn2qdZ5cSfhf8O8ifuy+CieATAntICNloqczBa8gZ Z/vdFg4IkJnNZAqya4EX6z1hVkIICjKXpKZ6AQyHukp5Jc1A9kyAM1noSNx8i4hldBV9 1076pUZqRW7wyTXBsAPoOOZmCrHwTxUsp82PHPxBRB4whDGiYlT9ywtDmS8Y7sqHb42X D2phtUN1xfTFlJfJUPCyqq3UG3IBNfPyh89zhfME9JIX2ethA5vGKvYmcSGOmGkWuZY/ MZdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=V57zR7NV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ba26-20020a0564021ada00b0046ac017b01bsi1853822edb.324.2022.12.22.19.09.55; Thu, 22 Dec 2022 19:10:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=V57zR7NV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235913AbiLWCyD (ORCPT + 67 others); Thu, 22 Dec 2022 21:54:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbiLWCx4 (ORCPT ); Thu, 22 Dec 2022 21:53:56 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DD2F21813; Thu, 22 Dec 2022 18:53:50 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671764028; bh=ipHZgib+Lby6GodEXoPKlNcMMUGuBYXzjHfoe9lgkqQ=; h=From:Subject:Date:To:Cc:From; b=V57zR7NVxVnHAK6Oz4c1V6nN+1UiHYX48OjoLrRy2jhbJPXGnMP7IN2EVBkfyb3B8 Kl0SPxsPbXhrR/SfTB9z+RyYkD6aiPXwubReL6t57UA7Wk5o/IqyRlek5EfcbkQLXD mkmhjB5FVqPFYRMTRAecjXoXIqzEIBIeYXt9a2Ms= Subject: [PATCH 0/2] HID: i2c-hid: use standard debugging APIs Date: Fri, 23 Dec 2022 02:53:34 +0000 Message-Id: <20221223-hid-dbg-v1-0-f641e80263eb@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAC8YpWMC/x2M0QqDMAwAf0XyvMAaUcZ+RfbQJtEGpJOWDUH8d 4OPdxx3QNNq2uDdHVD1b82+xSE8OuAcy6Jo4gz0JApEPWYTlLQgCwcZRnmxKnidYlNMNRbO3pff urrcqs623/vpc54XWJQVwG4AAAA= To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671764024; l=1180; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=ipHZgib+Lby6GodEXoPKlNcMMUGuBYXzjHfoe9lgkqQ=; b=TG7tPdchLgspc33yI9e12sHfbf7zDVwCH5El/E3t/LqYCDQX4yBCp8VCBOuRbyy1BXDfyGi2mqfs PtVWoscXDFG64zJ/PusGL9nUVh8GXAfI47MCB98L6CAcRwpr0pOj X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When trying to debug i2c-hid I was not able to use the builtin debug mechanism because the "debug" module parameter is not writable. We can change i2c-hid to use the standard kernel debugging APIs which are more discoverable and have more features. There is a bit of a stilistic conflict between consistently using i2c_hid_dbg() and consistently using dev_(). The second patch aligns debugging on i2c_hid_dbg(). If this is unneeded, feel free to drop it. It would also be easy to just use dev_dbg() everywhere for consistency. To: Jiri Kosina To: Benjamin Tissoires Cc: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Thomas Weißschuh --- Thomas Weißschuh (2): HID: i2c-hid: switch to standard debugging APIs HID: i2c-hid: use uniform debugging APIs drivers/hid/i2c-hid/i2c-hid-core.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) --- base-commit: 8395ae05cb5a2e31d36106e8c85efa11cda849be change-id: 20221223-hid-dbg-cdc1d56d8cee Best regards, -- Thomas Weißschuh