Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp14334rwj; Thu, 22 Dec 2022 19:46:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXs78nVxzLk5JqkEq2QWMnjmPMKsXSsm7/LEZK4rGVvkRa+iBQwsR8tCvlbCAWLJKcRPZZJb X-Received: by 2002:a17:907:a0cc:b0:78d:f454:37a6 with SMTP id hw12-20020a170907a0cc00b0078df45437a6mr7056792ejc.73.1671767173823; Thu, 22 Dec 2022 19:46:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671767173; cv=none; d=google.com; s=arc-20160816; b=yaMEHFcgYWVm1ehgAnCb20Yt8xsLq5H9rIJSNPjzFW3tayZnkoMbDeAbF1p9cJ/+FX /LOS7WxNuTOVM2AC2VpdKvNTim8FIVki9ZpkObwu1ksK+Z/Qf2OFVtaXW9EoL4U/WpSq i4NLZwPX4vMIboWjDrbLCfEtyNcrgaZZLvjyoCRgDyqFrx6+wTMlpQi+m2xK4lIMOqFu 27VqXkUwOVmuLA3aoUHjlTd7smTSFF6D8qMzCjGJ2J3oyJO5rJeKPVjxblVQTlgK/9AU QEJos5e5xyTTyApF/HNapcgtCmvngShI3k9D9Sh2sq4DGR5cavMsqQJln1oBQWKPLWuz dsmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=RuL3T58dm14XC/lC3byQ6CMhm3xRshn/ItkIEICi6wE=; b=pp8OzUDorttDBjUrnZtQsvia4QogxNUhJvKMSUmPjK3A3J6EMSt2F2wqdo3TMjPer+ r9JM1e4wJgp4lyzj42tOQu50oPM3AglcuWsXy+VcCFKIcbyo8yNCErqlFBIUQXfgD4o2 kFVqldlLvXJ+7VvmxVywmLXb0EJiGFB7ZwH1ELMBpxTJaFNWFN8FD+bRHufEzWo3TMlc BJS3mePzGJpWg2ngGS7+QyEhVm4DY6XroNUpwJYlXOm+7KkCfId9ZaSm0PkXlBTtWeXX OP3Zc4D7jS0SZEWOK8i2NHlCVbKx5dyN2+JrDUWlbCmm2YKBBbNmiqh/6xDzQKi8Pls8 aYpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=Ed1YIJRu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w5-20020a056402268500b0046bef95b2e6si2026911edd.492.2022.12.22.19.45.58; Thu, 22 Dec 2022 19:46:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=Ed1YIJRu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbiLWCxz (ORCPT + 67 others); Thu, 22 Dec 2022 21:53:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbiLWCxy (ORCPT ); Thu, 22 Dec 2022 21:53:54 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3292D21269; Thu, 22 Dec 2022 18:53:50 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671764028; bh=B99KsiMvt1tHeatg1X68sSjUpUUP66/qiYRoMzEGvSg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Ed1YIJRuwxAWxH+Jlch5EZIqTvS9nUgRMrj7OWwj17Yrqj1N9Yodo6ryVWSKu83jZ 7aQlNa3PlMPBz/IY5i3IF57cQPJBETE6NITo/wp5mcJQPxRuJCCqLWTq6AjJMw9MxE mK2MHr6RW2mUBT0OahxHXpdYkWA9cfqX5yDUbzhQ= Date: Fri, 23 Dec 2022 02:53:35 +0000 Subject: [PATCH 2/2] HID: i2c-hid: use uniform debugging APIs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-Id: <20221223-hid-dbg-v1-2-f641e80263eb@weissschuh.net> References: <20221223-hid-dbg-v1-0-f641e80263eb@weissschuh.net> In-Reply-To: <20221223-hid-dbg-v1-0-f641e80263eb@weissschuh.net> To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671764024; l=1238; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=B99KsiMvt1tHeatg1X68sSjUpUUP66/qiYRoMzEGvSg=; b=mQnHRn/UVse5r6MZaKGtGUi7cQMTj6a4EGaSfTS1kuP4EBYXIefrXWIcTajmWpHcC+sSZZliL1Qg 0wGv6Np5DJrSoVBGM7lynSwM8FGNPYdSsriDIY5K0a+L2M+uy8Zu X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only two locations in i2c-hid are using the standard dev_dbg() APIs. The rest are all using the custom i2c_hid_dbg(), which in turn uses dev_dbg(). Signed-off-by: Thomas Weißschuh --- drivers/hid/i2c-hid/i2c-hid-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c index b4ed21f25600..c83c93716782 100644 --- a/drivers/hid/i2c-hid/i2c-hid-core.c +++ b/drivers/hid/i2c-hid/i2c-hid-core.c @@ -850,7 +850,7 @@ static int i2c_hid_init_irq(struct i2c_client *client) unsigned long irqflags = 0; int ret; - dev_dbg(&client->dev, "Requesting IRQ: %d\n", client->irq); + i2c_hid_dbg(ihid, "Requesting IRQ: %d\n", client->irq); if (!irq_get_trigger_type(client->irq)) irqflags = IRQF_TRIGGER_LOW; @@ -994,7 +994,7 @@ int i2c_hid_core_probe(struct i2c_client *client, struct i2chid_ops *ops, /* Make sure there is something at this address */ ret = i2c_smbus_read_byte(client); if (ret < 0) { - dev_dbg(&client->dev, "nothing at this address: %d\n", ret); + i2c_hid_dbg(ihid, "nothing at this address: %d\n", ret); ret = -ENXIO; goto err_powered; } -- 2.39.0