Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Dec 2022 12:23:48 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 05/13] cpufreq: amd-pstate: optimize driver working
 mode selection in amd_pstate_param()
Message-ID: <Y6UtVGvVWJgMU5Db@amd.com>
References: <20221219064042.661122-1-perry.yuan@amd.com>
 <20221219064042.661122-6-perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221219064042.661122-6-perry.yuan@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1IPPGJTXb9qYach2fwo73tYByQzvImceU3kYwMHuxCzMwxWs9otr0+mLF0R4?=
 =?us-ascii?Q?XJZkOJlFmyY5acHISUtxlscYO0Z61sd2z9byRrAppF+8W4bfwU8PoMueqAQ/?=
 =?us-ascii?Q?mpKxiAgji3OGE7ix4vZsaLbAS4xQ2E43+o7jnwzdjcDUR4smuGwOyKH7BqxM?=
 =?us-ascii?Q?DHyGVzyDWjW89FyRsXr1dk+OjERPEkP1V32soanuB2cZWlr3pEtIXBS0rihP?=
 =?us-ascii?Q?J+N4oJi5+uqJ2BqJuvFC/UDh9pNTlPYTjEG94nVcW3dksnOr+Wn6Z5my/A3e?=
 =?us-ascii?Q?qw7KyZBCVH6n4IqozgsWB06dMIqmM2G3ENACgyT6BoskEqEEUarsE3sxXDuI?=
 =?us-ascii?Q?q5GSR1ZP0C3kI3Cn6Yrb7rWJUH6xhAWEEizL8OUw/Xbg4lgvniUVk5yaFIyH?=
 =?us-ascii?Q?zWk9XTkvSchOtJgaz7fm0M/u1ZMTvKITsCt9+3jlIDf1lQkXkwUGa4czckkn?=
 =?us-ascii?Q?dXrIIJe+SScDuyN2CL5JeSyGOw0/E8qMnmfIfqAc24VIlj172hGs7vOxucSd?=
 =?us-ascii?Q?EyY9MOJvuEWHq90tRGU7m42KPEqjIQcABqUzLcFDPnNQcV1EZeOJ27RWdK0p?=
 =?us-ascii?Q?VF5Yncc5D+9st6RHnlxj6lsCSV7KJib5gmoqDPT/nPNgVxrdYJ3QtHf63RCD?=
 =?us-ascii?Q?EAAMWDJLOZJPHPDjypXW3KWRgoRTZSGCY8yBvUpVEm+JB5PA3TgHzo3DgV4A?=
 =?us-ascii?Q?K9ZHR8XKcG55KSa06h3n6hzxBc69ydNdtt2FFNJCdiEDUNCfKFuiVB5DxK8/?=
 =?us-ascii?Q?udGJbAzcWNEMBHHrBmKx8bz2Qsulj/s0O1D3KhI1xRCOJWeR9agbSZhSV13q?=
 =?us-ascii?Q?ualLvRlnlwGP+MP/xzx1koXGLO59QVzNlE6CLGDkvx0EGz2jt9zQGyPEzWrN?=
 =?us-ascii?Q?WFTE+VmOJXPtOGamwKkOsCJ8JtsKLy683SbkENJGMJaEYv9CMb72uA51o6ST?=
 =?us-ascii?Q?lPBM+QBuy7fZiG1L+zRtdVE0ejEbS1dFwXINJLwPChvMMCX2oPo7AtNIKNo9?=
 =?us-ascii?Q?KG9NejNvLX+kZahI1NwJ352mtf78vYoHuNTjOjf289V88HAEGZVu9uCSgf1k?=
 =?us-ascii?Q?nxMJxEFTVSTGBAd7aoWP4BIagpJ6BN3cbMIATbfQyaAlesSQtVeLZGB+Pqjg?=
 =?us-ascii?Q?YtNxHPtR1eruBq6BzRezBVZ20qrPYxKWImMF1sStjhrSHmmp44hxID4OBMeg?=
 =?us-ascii?Q?ZOOsPeJcmjGq3H2CHxPd7LRCK/wJnKmblePsIpUI0bBVqwH76TBdPY/kZ30V?=
 =?us-ascii?Q?s0/pbT9Gl4YuAdS5eFHy1B5ksgX/rppCZszPjrXp+fnhKw4P0mYh6Aoe289P?=
 =?us-ascii?Q?PKJesQVnIVQ2zoI3duOTjCmNLbFKmRom6+l38IhE66YsFUFzQMkY35/JhS4P?=
 =?us-ascii?Q?W3GAHOllnvGAqBN73dWRRjREL0y9/DwKaLokSIQ+TZmtMG0uzfBRlHVIJs/Q?=
 =?us-ascii?Q?XaeTrt2dSMtBqVllGFvvwVCswYUcmoZR8xPb0hE6Hrlk45KB60mwUfpFHRqx?=
 =?us-ascii?Q?CnkxI7FhmWaswPCuXgzkZTpb+y7wMrA+sI61OJS4UW9NrNp5lMk4388AisE8?=
 =?us-ascii?Q?SbquLdsAaqbIvPHR7Y4iQl9FqCWkVNE6BXAkpktS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d84cf289-7839-45f3-7ce7-08dae49d89a7
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2022 04:24:09.9143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RtJ8qnucPKZMJNeiIp5zSTxd6QUqj1LOWfO3HfD+GI/2bHizuIHA8cA2c0GtPL2S8bIUOLjghWV87PyEHn+/KQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4544
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 19, 2022 at 02:40:34PM +0800, Yuan, Perry wrote:
> There are some other amd pstate driver working mode to be supported.
> Here we use cppc_state var to indicate which mode is enabled.
> This change will help to simplify the the amd_pstate_param() to choose
> which mode used for the following driver registeration.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>

The most of codes for this patch should be inherited by below patch:

https://lore.kernel.org/lkml/20221207154648.233759-2-wyes.karny@amd.com/

So I believe Wyes should be the author of this patch, please use git commit
--amend --author="Wyes Karny <wyes.karny@amd.com>" to update.

Thanks,
Ray

> ---
>  drivers/cpufreq/amd-pstate.c | 35 +++++++++++++++++++++++++++--------
>  include/linux/amd-pstate.h   | 29 +++++++++++++++++++++++++++++
>  2 files changed, 56 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index c17bd845f5fc..861a905f9324 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -60,7 +60,18 @@
>   * module parameter to be able to enable it manually for debugging.
>   */
>  static struct cpufreq_driver amd_pstate_driver;
> -static int cppc_load __initdata;
> +static int cppc_state = AMD_PSTATE_DISABLE;
> +
> +static inline int get_mode_idx_from_str(const char *str, size_t size)
> +{
> +	int i;
> +
> +	for (i=0; i < AMD_PSTATE_MAX; i++) {
> +		if (!strncmp(str, amd_pstate_mode_string[i], size))
> +			return i;
> +	}
> +	return -EINVAL;
> +}
>  
>  static inline int pstate_enable(bool enable)
>  {
> @@ -628,7 +639,7 @@ static int __init amd_pstate_init(void)
>  	 * enable the amd_pstate passive mode driver explicitly
>  	 * with amd_pstate=passive in kernel command line
>  	 */
> -	if (!cppc_load) {
> +	if (cppc_state == AMD_PSTATE_DISABLE) {
>  		pr_debug("driver load is disabled, boot with amd_pstate=passive to enable this\n");
>  		return -ENODEV;
>  	}
> @@ -671,16 +682,24 @@ device_initcall(amd_pstate_init);
>  
>  static int __init amd_pstate_param(char *str)
>  {
> +	size_t size;
> +	int mode_idx;
> +
>  	if (!str)
>  		return -EINVAL;
>  
> -	if (!strcmp(str, "disable")) {
> -		cppc_load = 0;
> -		pr_info("driver is explicitly disabled\n");
> -	} else if (!strcmp(str, "passive"))
> -		cppc_load = 1;
> +	size = strlen(str);
> +	mode_idx = get_mode_idx_from_str(str, size);
>  
> -	return 0;
> +	if (mode_idx >= AMD_PSTATE_DISABLE && mode_idx < AMD_PSTATE_MAX) {
> +		cppc_state = mode_idx;
> +		if (cppc_state == AMD_PSTATE_DISABLE)
> +			pr_info("driver is explicitly disabled\n");
> +
> +		return 0;
> +	}
> +
> +	return -EINVAL;
>  }
>  early_param("amd_pstate", amd_pstate_param);
>  
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index 1c4b8659f171..922d05a13902 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -74,4 +74,33 @@ struct amd_cpudata {
>  	bool	boost_supported;
>  };
>  
> +/**
> + * enum amd_pstate_mode - driver working mode of amd pstate
> + */
> +
> +enum amd_pstate_mode {
> +	/** @AMD_PSTATE_DISABLE: Driver mode is disabled */
> +	AMD_PSTATE_DISABLE = 0,
> +
> +	/** @AMD_PSTATE_PASSIVE: Drier mode is passive mode */
> +	AMD_PSTATE_PASSIVE = 1,
> +
> +	/** @AMD_PSTATE_ACTIVE: Driver mode is active mode */
> +	AMD_PSTATE_ACTIVE = 2,
> +
> +	/** @AMD_PSTATE_GUIDE: Driver mode is guided mode */
> +	AMD_PSTATE_GUIDE = 3,
> +
> +	/** @AMD_PSTATE_MAX */
> +	AMD_PSTATE_MAX = 4,
> +};
> +
> +static const char * const amd_pstate_mode_string[] = {
> +	[AMD_PSTATE_DISABLE]     = "disable",
> +	[AMD_PSTATE_PASSIVE]     = "passive",
> +	[AMD_PSTATE_ACTIVE]      = "active",
> +	[AMD_PSTATE_GUIDE]      = "guide",
> +	NULL,
> +};
> +
>  #endif /* _LINUX_AMD_PSTATE_H */
> -- 
> 2.34.1
>