Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221102160236.11696-1-iecedge@gmail.com> <20221114122255.72588f45@gandalf.local.home>
 <CAFA-uR8TakkW=KoA_9RXcyw00Zj8+nNn2erSZ4Y9ULNM8ne11g@mail.gmail.com>
 <20221114220216.05dd0541@gandalf.local.home> <20221116000707.a8a692e377d8daaf3764ee64@kernel.org>
 <20221115101837.37da9d1e@gandalf.local.home>
In-Reply-To: <20221115101837.37da9d1e@gandalf.local.home>
From:   Jianlin Lv <iecedge@gmail.com>
Date:   Fri, 23 Dec 2022 12:52:18 +0800
Message-ID: <CAFA-uR_Bhc8fdBXajKzSSXQ1Cf_iLirK0gS+TovPM9G7MLv=dg@mail.gmail.com>
Subject: Re: [PATCH] tracepoint: Allow livepatch module add trace event
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
        alison.schofield@intel.com, davidgow@google.com,
        thunder.leizhen@huawei.com, jianlv@ebay.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 15, 2022 at 11:17 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 16 Nov 2022 00:07:07 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>
> > BTW, now the kprobe_ftrace_handler() uses ftrace_test_recursion_trylock()
> > to avoid ftrace recursion, is that OK for this case?
>
> Note, the ftrace_test_recursion_trylock() only prevents "same context"
> recursion. That is, it will not let normal context recurse into normal
> context, or interrupt context recurse into interrupt context.
>
> It has the logic of breaking up into 4 levels:
>
>  1. normal
>  2. softirq
>  3. irq
>  4. NMI
>
> It allows the high levels to recurse into lower levels
>  (e.g. irq context into normal context)
>
> Thus, the code within the ftrace_test_recursion_trylock() must itself be
> re-entrant to handle being called from different contexts.
>
> -- Steve

hi, Steve
Any other comments for code changes?
Is it possible for this patch to be merged?

Regards,
Jianlin