Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0fb8a86a-ca92-8d5f-99da-6815b2d5ec3e@gmx.de>
Date:   Fri, 23 Dec 2022 08:55:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH linux-next] parisc: use strscpy() to instead of strncpy()
Content-Language: en-US
To:     yang.yang29@zte.com.cn, james.bottomley@hansenpartnership.com
Cc:     linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
        xu.panda@zte.com.cn
References: <202212231040562072342@zte.com.cn>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <202212231040562072342@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:f+izm0NQ4C4=;fBIsGrToJ65nYWTYBnipugSu+2R
 iOPAWPVCJtMM4/Dud1qnYdzlfu4uJTDbHPsWDL8pzLqIThuug4hbD9bI3nyCQEfzl8dVP+oU1
 7LPz2ECp1FJ/aSduL6giWKPHLhyN1kbcb6ZNUvDvg2nEt/y2kefhFP5GuL3y/32YrhKDwHWdu
 Xz32FNnVL8wW9zkuZXLvgk5hXnIEcdXip7aqdiyEpK1Qc1NpNIeeeSAXfvz7BUxYxmKHAUhYe
 pMkx+rZY761cDKcyTf6Rh56Gkr7EKl1mNL4Q5Sqz1pq4LOJLsHpGRGH9PcE6bolH1YLg5EkTX
 UpIuE6+sgCRdz2Yucg2/yX5GcclAyd/7eDMUMA9hnqzrBfSdmq7A0xY+WGMxbgDYd3lFLBbXt
 ZbvDrI9NdUE9A71gR5bj1IL8xyH6+geZ+VrKvqLwsGkoioioVj/gRJORVQXOE/1YN5u8kueBt
 +ycw972ozaUWxvxggFbdGc1iVZ0XBsOpwNKmKD9cBPnzXPcfTmNHGjdJLLemG/rhmPUfhSHF8
 4BUOidB/JLiU817rJ9fGpfVHOXFUSsKKAjf5lW0pe4/igFra3xgKuTTSGKgX6POiLLd9UuDFs
 T27/JSMGyQyqQj3FZ7X+rm8viqOdc/+9qYptzsy6ml1JFkwjxZFgzbP8tFzUHP3qdcOmgRCAB
 0TVrb3MxWzszlXVYAFFBYyGHc1NoK/PflLEkroNzxecDRgpLjAWXWwoxofr7cZTAlO4LhNsry
 JazrbasM9ogcGNk8HLTg0joB5xh7AY2N8zPTVfXZsGxFWSI9eebexXnyZE2RuMvIAfKSMY8Zk
 L5oWJOumtzaxfhxUqWKpVzMhrABipFoDstQqo6a2CuRFomcoaSfMqKJ08qCscvA8o4L7ygzmx
 3ht27OmqwOENYepMj7k2do4pf/daVtYuQh5CGkti+Ul1UnpNlPC/LGMeLVjnGVmWR21lYe8UR
 EoT08XFzFwo1wKjjPsXbCtQ0TcE=
Precedence: bulk

On 12/23/22 03:40, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.

Thanks for your patch, but....

> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
>   drivers/parisc/pdc_stable.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
> index d6af5726ddf3..403bca0021c5 100644
> --- a/drivers/parisc/pdc_stable.c
> +++ b/drivers/parisc/pdc_stable.c
> @@ -274,8 +274,7 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, =
const char *buf, size_t coun
>
>   	/* We'll use a local copy of buf */
>   	count =3D min_t(size_t, count, sizeof(in)-1);
> -	strncpy(in, buf, count);
> -	in[count] =3D '\0';
> +	strscpy(in, buf, count + 1);

could you resend it somewhat simplified, e.g.
strscpy(in, buf, sizeof(in));


>
>   	/* Let's clean up the target. 0xff is a blank pattern */
>   	memset(&hwpath, 0xff, sizeof(hwpath));
> @@ -388,8 +387,7 @@ pdcspath_layer_write(struct pdcspath_entry *entry, c=
onst char *buf, size_t count
>
>   	/* We'll use a local copy of buf */
>   	count =3D min_t(size_t, count, sizeof(in)-1);
> -	strncpy(in, buf, count);
> -	in[count] =3D '\0';
> +	strscpy(in, buf, count + 1);

same here

>
>   	/* Let's clean up the target. 0 is a blank pattern */
>   	memset(&layers, 0, sizeof(layers));
> @@ -756,8 +754,7 @@ static ssize_t pdcs_auto_write(struct kobject *kobj,
>
>   	/* We'll use a local copy of buf */
>   	count =3D min_t(size_t, count, sizeof(in)-1);
> -	strncpy(in, buf, count);
> -	in[count] =3D '\0';
> +	strscpy(in, buf, count + 1);

and here

>
>   	/* Current flags are stored in primary boot path entry */
>   	pathentry =3D &pdcspath_entry_primary;