Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221222072603.1175248-1-korantwork@gmail.com> <3d1834d9-7905-1225-741a-f298dd5b8a8e@linux.dev>
In-Reply-To: <3d1834d9-7905-1225-741a-f298dd5b8a8e@linux.dev>
From:   Xinghui Li <korantwork@gmail.com>
Date:   Fri, 23 Dec 2022 15:53:12 +0800
Message-ID: <CAEm4hYUeigWxcDVGpg05P-5Qkh=6bArmtPqVqxR6Yw4wod3WBA@mail.gmail.com>
Subject: Re: [PATCH] PCI: vmd: Do not disable MSI-X remapping in VMD 28C0 controller
To:     Jonathan Derrick <jonathan.derrick@linux.dev>
Cc:     nirmal.patel@linux.intel.com, lpieralisi@kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xinghui Li <korantli@tencent.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jonathan Derrick <jonathan.derrick@linux.dev> =E4=BA=8E2022=E5=B9=B412=E6=
=9C=8822=E6=97=A5=E5=91=A8=E5=9B=9B 17:15=E5=86=99=E9=81=93=EF=BC=9A
>
>
>
> On 12/22/22 12:26 AM, korantwork@gmail.com wrote:
> > From: Xinghui Li <korantli@tencent.com>
> >
> > Commit ee81ee84f873("PCI: vmd: Disable MSI-X remapping when possible")
> > disable the vmd MSI-X remapping for optimizing pci performance.However,
> > this feature severely negatively optimized performance in multi-disk
> > situations.
> >
> > In FIO 4K random test, we test 1 disk in the 1 CPU
> >
> > when disable MSI-X remapping:
> > read: IOPS=3D1183k, BW=3D4622MiB/s (4847MB/s)(1354GiB/300001msec)
> > READ: bw=3D4622MiB/s (4847MB/s), 4622MiB/s-4622MiB/s (4847MB/s-4847MB/s=
),
> > io=3D1354GiB (1454GB), run=3D300001-300001msec
> >
> > When not disable MSI-X remapping:
> > read: IOPS=3D1171k, BW=3D4572MiB/s (4795MB/s)(1340GiB/300001msec)
> > READ: bw=3D4572MiB/s (4795MB/s), 4572MiB/s-4572MiB/s (4795MB/s-4795MB/s=
),
> > io=3D1340GiB (1438GB), run=3D300001-300001msec
> >
> > However, the bypass mode could increase the interrupts costs in CPU.
> > We test 12 disks in the 6 CPU,
> Well the bypass mode was made to improve performance where you have >4
> drives so this is pretty surprising. With bypass mode disabled, VMD will
> intercept and forward interrupts, increasing costs.

We also find the more drives we tested, the more severe the
performance degradation.
When we tested 8 drives in 6 CPU, there is about 30% drop.

> I think Nirmal would want to to understand if there's some other factor
> going on here.

I also agree with this. The tested server is None io-scheduler.
We tested the same server. Tested drives are Samsung Gen-4 nvme.
Is there anything else you worried effecting test results?