Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp278559rwj; Fri, 23 Dec 2022 00:59:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXs1v7bND63yf0y5m/1/W+km13bvkiDIH+NH37Uf3+L7SbFIxRKJBtnA3M7wuRzJNfUg6Q8E X-Received: by 2002:a17:906:c79a:b0:82d:1c3c:fe7c with SMTP id cw26-20020a170906c79a00b0082d1c3cfe7cmr6578587ejb.22.1671785990720; Fri, 23 Dec 2022 00:59:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671785990; cv=none; d=google.com; s=arc-20160816; b=wBE4ELBp4Pp0EpYZqjwLk5GcaCuxXr4OZxrvS5g8JrAfeR98Dy6Gu3bzJHwSrXBxhc aU44VjzX8oQqH4vKIChwG/Py73NkXMjwpRcZ1fukcHe309jnJ9gNDdf6nO+UnoybPgdO U1A91VNwQGGtCfsaS5TCkZ5iJrpZDMyoAw7BvRPjS6ffu//aIm4k3yzGVNltRlFL4LVo pR/hGz//w0nG267aKkLmsTnGyOmywARrRyuIj0ozaIQbSv/UkMXSbwCizghjnxdfkxzc beTlcwefX6K/but1D4WOH5gV2z2X9uPLL3/cqtPQ8WWCYaCq6uZ0Mmhh8zsQNutus9yD Ooow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=saMXhQ6FaRFb79mAY11mIOCOiw3Mj/T5tk9AKBUTHeM=; b=tPIUD/tojqR7tHxnnBexvi1tUztwSpZMhl/GHTnNElJ2oncMjWnQlAwUNq6d2hi4Ar tbLJTRImXs+J8aqlxVi8ahnjQc2pxj7Afbwc4UKJtE89gDQP8y0soR7u1i4aG4kjKn8t DR2TjID9uTPy9CUGcpG3RqoPvjEdsR6GxdXKfi2npuNWSdwpsMGSl5Hn6E2z6o7YICGF XxJnVpwaWLXXfBkjI6EYPylE9I0a6sa+HyGmKlVtyjbtAlfOE8wckib6AItLabsQDrOV O+tmFnNoDPRYydzKWz23Y1RNaBzFV5YSk5fdHcCStqt4VoCOOpNo5rtvLGF0b5aFc519 VUgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X+1+Q9UQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf18-20020a1709077f1200b007f20a95eae0si2220727ejc.262.2022.12.23.00.59.34; Fri, 23 Dec 2022 00:59:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X+1+Q9UQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236082AbiLWIph (ORCPT + 67 others); Fri, 23 Dec 2022 03:45:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbiLWIpf (ORCPT ); Fri, 23 Dec 2022 03:45:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63DC9357B7 for ; Fri, 23 Dec 2022 00:45:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671785099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=saMXhQ6FaRFb79mAY11mIOCOiw3Mj/T5tk9AKBUTHeM=; b=X+1+Q9UQIRazUif3ENhNP/iRtLcjOi+ur838di2FLdoYDrpWiqP/vhAQHr+DXWfrmF6adq hRVBsbVD9Zd1SKmwMUhj/HouzONkvdDs8dTpWTz3pfTQl76+8Y+sFNo5refamMKvlHC6F9 9dhsSgPUWSrHDg978Sg6q2G1I0TKogw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-29-7UMb2DCJPEyVNDkLfBVJJw-1; Fri, 23 Dec 2022 03:44:58 -0500 X-MC-Unique: 7UMb2DCJPEyVNDkLfBVJJw-1 Received: by mail-wm1-f72.google.com with SMTP id bd6-20020a05600c1f0600b003d96f7f2396so456744wmb.3 for ; Fri, 23 Dec 2022 00:44:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=saMXhQ6FaRFb79mAY11mIOCOiw3Mj/T5tk9AKBUTHeM=; b=u1ub5EUXwXqNTH5/ec9ukykSp/Vn/e4tOdTKReK/Nn2bn4fOq4J4/8hsQfwpaqmfcF fpwrjLyVHoVnDeJ0XUaMruNOo6xaLCie63QbcT2gYT1O8JDMLJeBkoW//+JzEY9L2VIx pun2FwjJ0eUflE9DPd9cdYFXvAL3aA9L4LaXMZ/YtU0UWVw+wM237Y+OXnxRBgq5pVad GTZE9zBFn1VRz7LFL5AyxsuQGo1ve19OLnRDVWKeSz1p/8Xa4w30apAsIxRMneri6NY4 ghum+BGuA+PVyVxjG2w1f9nmfaANQ3gTYJ3wtpPlXO6fq+W3AAWBXOGeSLoZeP3WnuhP KXDw== X-Gm-Message-State: AFqh2kr8qBN7usHqsvp+tDHW3dIwdAiuWnh15z+gh/sQazUWywkqOpJt b7MBcf5JwCLOYMgPp473eoNmr5TZBdtVEgwmuh1thAOWZnHV0kdqzy1fkYhhDwKTXDKvWkmH1Mo 2ptg8Xvi2fG665S0iCn3GLapH X-Received: by 2002:a05:600c:4e04:b0:3d2:381f:2db5 with SMTP id b4-20020a05600c4e0400b003d2381f2db5mr6216509wmq.22.1671785097116; Fri, 23 Dec 2022 00:44:57 -0800 (PST) X-Received: by 2002:a05:600c:4e04:b0:3d2:381f:2db5 with SMTP id b4-20020a05600c4e0400b003d2381f2db5mr6216489wmq.22.1671785096950; Fri, 23 Dec 2022 00:44:56 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id o7-20020a05600c4fc700b003cf4ec90938sm4316705wmq.21.2022.12.23.00.44.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 00:44:56 -0800 (PST) Message-ID: Date: Fri, 23 Dec 2022 09:44:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Content-Language: en-US To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Ondrej Jirman , Robert Mader , Peter Robinson , =?UTF-8?Q?Kamil_Trzci=c5=84ski?= , Martijn Braam , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , Tom Fitzhenry , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20221222223830.2494900-1-javierm@redhat.com> <20221222223830.2494900-5-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/23/22 09:13, Krzysztof Kozlowski wrote: > On 22/12/2022 23:38, Javier Martinez Canillas wrote: [...] >> + >> + /* MIPI DSI panel 1.8v supply */ >> + vcc1v8_lcd: vcc1v8-lcd { > > Node names should be generic, so regulator suffix or prefix (looks like > other nodes already use suffix) > Indeed, Maya already pointed this out. I missed this when forward porting this patch from the pine64 downstream tree. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat