Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Dec 2022 17:05:26 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH 00/27] drm/i915/gvt: KVM: KVMGT fixes and page-track
 cleanups
Message-ID: <Y6VvVrYURd/an3Zp@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20221223005739.1295925-1-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221223005739.1295925-1-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+PQeDjW/fnuIZfDUX1nXeppf8JHgpRv9+ZtgTIn1SoiSvUuSdmfXAZfqOOIc?=
 =?us-ascii?Q?PgX9ET5DCjfDLLfUKjYWsbJ1lLOEWph3iV6tRRFlde1XFfkb7JaBKXleyvlF?=
 =?us-ascii?Q?Knz4Y2brlUZKzzU9+/v9bAjpIPWn2vrVe4sUVPxMOFCXG7gMtLN+vHNefwMB?=
 =?us-ascii?Q?WmrX2i5wbeFvN2xlz5eRFFy0nEqQcrD0sNBl7lcxxsiK0s1r/W6uJ6Kwtpyu?=
 =?us-ascii?Q?rJtGf4Dh1ImTkoqkO6GcEKaq/LfYkeJnW+K5HnC5uLshA/5PVdJrQVKsFw4y?=
 =?us-ascii?Q?Lob9AzKHSqneK8g8M+wNoWEbJx7enDG5YsYUFcn5JxmNREYHUpoDPuGxqP5U?=
 =?us-ascii?Q?vdaOZstR2FZBEW0pwrpbTLaA6kok3OzqtJa17Qc3CRulW1O05lK3GtO/XrHx?=
 =?us-ascii?Q?Qm5/X6TrdFka2WwcazlHB3FCYvJXuLsmTfJOnWD8HmSRVYtRQjhRyMjM2S08?=
 =?us-ascii?Q?C69zhyYMXswmHVmWDBSpVNBVJhzkCCNC+kUpTHR5PdUeJXjR8Q3XMrg28P3G?=
 =?us-ascii?Q?ys/c20Ip47K6E2Iq8/cBlv9O7Zy1DBZsj0Yfcsuj6N1zg0GL+/A/F9RZXTEJ?=
 =?us-ascii?Q?qAgJ8+8EfQX+mruV004oiifALgSJYKUaBt1iHPoua/NILz324P6HGy0sG6SL?=
 =?us-ascii?Q?cfY1snzloBBjlAHgk1x0lXChgSMloOZc7s2DXbjMuD8k9Z2sbmfLykSDkzFG?=
 =?us-ascii?Q?JR669Bz38Y0h+xEHfS+CJVWvorzjMyhshBBF8Cvd0W7qYIdPpsstLGFY+twY?=
 =?us-ascii?Q?yFOFJ6SQxWqygPTJfh0CkaNA+Ejv4lccf8DXzhhAox6fh3WE0TWLk6l5quVJ?=
 =?us-ascii?Q?R9fOC4LcdS4Dkhd37iyqU97noULyJIywNDm1vie1caWPVb66PWg3RFAEgnra?=
 =?us-ascii?Q?FS7gpBQp5idOCTUPzEuxEapsW7OWtQ0OnuZ6zMACzQgSPhwTieU7bgWpWpwU?=
 =?us-ascii?Q?+qibCExN9zPdfn4o0SXbIkwCz8k9yJbP9/bKm9XhyEe9QIlPfYocEh6rK7H3?=
 =?us-ascii?Q?3yVgIvGJ8B8HJaa25cTMpgk6+v4kExD8oTWcNhe+kxkWtczqTWmSEyUTThhY?=
 =?us-ascii?Q?wnkRHbu3FZhfxTxILa4UH3KAvAyxaRUa+bn1DarVJ1ux2ct4nKhXg/MP/j6l?=
 =?us-ascii?Q?LNw/48N2/yIuNTeoPRsstQ67dv1GC2P1DLzWomOzYJEGhNKVX0KC9xBdm7Xf?=
 =?us-ascii?Q?j3H4MQBzoEdrw7polqT5B0fH3j2Tmdfqf2Uhrm+1oAKIl67z/+WTh1rGlSks?=
 =?us-ascii?Q?52/MT1iS6EQ7gy6GHNlnZXIpYu0CM/UHMsS1D77xis+vqBNUwcbfW/J7X/fA?=
 =?us-ascii?Q?kS4PudaHaGYfEcn1W0VSU3CzMnxDt8BAXVei8fDbMMRK3lWiXqDBRZ8WC450?=
 =?us-ascii?Q?Q6vDxzEGWAlI2DnghY+hiNFPGXx1cZzVoAwzWq/yz7MIqT3jM3lnqQW8Qsku?=
 =?us-ascii?Q?iAFq3fur+OQsyonGtHPFpp4S3Y6qvAdVgZz6E61meK1VxzkPkmpIKyqPj/Rb?=
 =?us-ascii?Q?sWzPzToY9VXh0Ihwxn4iFU7CPwqO2mUznMrqo2MCo7b8TOskYPbXZhP9I6dg?=
 =?us-ascii?Q?4lCPKzjwC8FGFnvMjXVQhGhfjDBQpX+m+9yOhoxoQ7SbR/ZMUsr1meNsMxJp?=
 =?us-ascii?Q?Bg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6eb1eede-b9c6-434d-8488-08dae4c813ff
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2022 09:28:40.8494
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CK86Uytd5vr4+0rko7DYDHVqHJ8iuUGWet7I5z5qMAs6PmlgvFYL8ek71Xs3wrTKrgS/4WJEjUGZCtiyRch3/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5415
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 23, 2022 at 12:57:12AM +0000, Sean Christopherson wrote:
> Fix a variety of found-by-inspection bugs in KVMGT, and overhaul KVM's
> page-track APIs to provide a leaner and cleaner interface.  The motivation
> for this series is to (significantly) reduce the number of KVM APIs that
> KVMGT uses, with a long-term goal of making all kvm_host.h headers
> KVM-internal.  That said, I think the cleanup itself is worthwhile,
> e.g. KVMGT really shouldn't be touching kvm->mmu_lock.
> 
> Note!  The KVMGT changes are compile tested only as I don't have the
> necessary hardware (AFAIK).  Testing, and lots of it, on the KVMGT side
> of things is needed and any help on that front would be much appreciated.
hi Sean,
Thanks for the patch!
Could you also provide the commit id that this series is based on?
I applied them on top of latest master branch (6.1.0+,
8395ae05cb5a2e31d36106e8c85efa11cda849be) in repo
https://github.com/torvalds/linux.git, yet met some conflicts and I
fixed them manually. (patch 11 and patch 25).

A rough test shows that below mutex_init is missing.
But even with this fix, I still met guest hang during guest boots up.
Will look into it and have a detailed review next week.

diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
index a7ac2ec00196..c274b6a05555 100644
--- a/drivers/gpu/drm/i915/gvt/vgpu.c
+++ b/drivers/gpu/drm/i915/gvt/vgpu.c
@@ -331,6 +331,7 @@ int intel_gvt_create_vgpu(struct intel_vgpu *vgpu,
        vgpu->id = ret;
        vgpu->sched_ctl.weight = conf->weight;
        mutex_init(&vgpu->vgpu_lock);
+       mutex_init(&vgpu->gfn_lock);
        mutex_init(&vgpu->dmabuf_lock);
        INIT_LIST_HEAD(&vgpu->dmabuf_obj_list_head);
        INIT_RADIX_TREE(&vgpu->page_track_tree, GFP_KERNEL);


Thanks
Yan