Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Dec 2022 11:47:24 +0100
From:   Christian Brauner <brauner@kernel.org>
To:     Uros Bizjak <ubizjak@gmail.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] posix_acl: Use try_cmpxchg in get_acl
Message-ID: <20221223104724.uurfko6bqzpjv5n5@wittgenstein>
References: <20221221193540.10078-1-ubizjak@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221221193540.10078-1-ubizjak@gmail.com>
Precedence: bulk

On Wed, Dec 21, 2022 at 08:35:40PM +0100, Uros Bizjak wrote:
> Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old
> in get_acl. x86 CMPXCHG instruction returns success in ZF flag,
> so this change saves a compare after cmpxchg (and related move
> instruction in front of cmpxchg).
> 
> No functional change intended.
> 
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> ---

Looks ok to me. But it's not urgent so I'll circle back to this post
-rc1.

Thanks!
Christian