Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp726080rwj;
        Fri, 23 Dec 2022 07:21:09 -0800 (PST)
X-Google-Smtp-Source: AMrXdXvXi4I3zHvYjpuCKKCqVBXc3UPGp7DKfSgJBAVJMzHpUvEQMeoTs1zU48GVTifZHz+bri5U
X-Received: by 2002:a17:907:8c0d:b0:7c1:d50:6dd3 with SMTP id ta13-20020a1709078c0d00b007c10d506dd3mr8564821ejc.36.1671808869214;
        Fri, 23 Dec 2022 07:21:09 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1671808869; cv=none;
        d=google.com; s=arc-20160816;
        b=b1l5qB0eIluvXruQ2sEBiH6tgnoldqp5Rwv1GJm12fLnknsrqyArLf87LNQqMv0fO9
         lGxz4uWv9aE2UIYAq5X20rUnmAAa4cDvroOrCsjG6pyYtrpgW7hum2dENzebyEAqeUre
         TLMTGu5T1QsViE3xsux8XvLGWcnPAFxYAw2HAUvM7da/k0f1zzbbCbA183xxcWdrKjqB
         7TbBw1HV4Ze81sWduBCRLwaVYngKlf6TU+Ru7y1lvCL7F+hAALYPGxVcEMPtvG+BDZl4
         NUxp1VlInUsOQwDY5lafunaOHsVBlDyzA7dIIP7iGtQqdgYTehiRknbCS2/AsLJ/R9Sk
         II0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=z0e5IfMg99plUAUdI6uzi1BHGXiNthwW7ZGB4IMQKos=;
        b=l6D7KxVQQELWRB4QQkUraZkX12p2C1n06uGAuB4t+TnHGXvtIvIsW/UmA2pckghp6U
         Y+qzSFdcBXtHqfcD5t3wCtfiePyl1l9P39UlW9MhK8Xg4pjVsSG6Yrb8H/daGriI6LZb
         pNvhSz0XRfjUryWtYJpQdn1lkCc2yzmLliIqjdNFNDtIdgAY8m5PUbEu05+KH/OiztYk
         6oBdcOeFgMtZT00MYSTlBMgLiEbL+G98L5N4nDtVqMBHNQi6RVlqmPBI3H0KEp2fIgwb
         ymfgfoMhbUgRdOo7yWqggQTIgQrQYAG42/daXR60Scd3T9VDXMSn40Mp4cz3jmsjG+zj
         q8ng==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=3k8aJZpl;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id sa17-20020a1709076d1100b0082cbe0c28dfsi2714589ejc.980.2022.12.23.07.20.53;
        Fri, 23 Dec 2022 07:21:09 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=3k8aJZpl;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236265AbiLWPDt (ORCPT <rfc822;5losepatience@gmail.com>
        + 65 others); Fri, 23 Dec 2022 10:03:49 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44134 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236472AbiLWPDq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Dec 2022 10:03:46 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F64A31DCE;
        Fri, 23 Dec 2022 07:03:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type:
        MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=z0e5IfMg99plUAUdI6uzi1BHGXiNthwW7ZGB4IMQKos=; b=3k8aJZpl85LmCjJqqRvQ1Ffyzs
        h4rtHe033Xy24gMk4E5EC6NItcyogaTz2IMJRcCeRLXDIpmoVlmnmPbB+Frp+8HwKWJOjiA8Fgv90
        KX9SqaPgjskW6Lfux6yfNDfjjUg6Kk+COCY085AdHYG1HwoDMRG/oivXt9krKKa+ilCfxhrRhdojd
        Y/0GR2c7YCCCN+6LjSo4yoZMY59G9AgOVLG694FQDvXJ3dkKE1bS9Y8e+i9CnaImSO1ocRnEQTCBB
        jQW7f18HEsSOC60SXV2/LHZOYpOJIds7xPkL4W+2Hs16KacSWkbh6aRnnVrHU5YlTsDtO8cfVOMKf
        vD655liA==;
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1p8jaK-009Anr-0Q; Fri, 23 Dec 2022 15:03:44 +0000
Date:   Fri, 23 Dec 2022 07:03:43 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Li kunyu <kunyu@nfschina.com>
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: main: =?utf-8?Q?remove?=
 =?utf-8?B?IHVubmVjZXNzYXJ5IOKAmDDigJk=?= values from err
Message-ID: <Y6XDTzjzzQl6JnHK@bombadil.infradead.org>
References: <20221223083232.4189-1-kunyu@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221223083232.4189-1-kunyu@nfschina.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 23, 2022 at 04:32:32PM +0800, Li kunyu wrote:
> err is assigned before use, so it does not need to initialize the
> assignment.

Sorry no, for something so simple, it just smells like you are wanting
to incraese your commit count.

  Luis