Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Dec 2022 16:02:00 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     lars@metafoo.de, paul@crapouillou.net, jiasheng@iscas.ac.cn,
        oleksandr.kozaruk@ti.com, gg@slimlogic.co.uk, balajitk@ti.com,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>,
        Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] iio:adc:twl6030: Enable measurement of VAC
Message-ID: <20221223160200.1ae6df91@jic23-huawei>
In-Reply-To: <20221217221305.671117-1-andreas@kemnade.info>
References: <20221217221305.671117-1-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 17 Dec 2022 23:13:05 +0100
Andreas Kemnade <andreas@kemnade.info> wrote:

> VAC needs to be wired up to produce proper measurements,
> without this change only near zero values are reported.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Fixes: 1696f36482e7 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/twl6030-gpadc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index 40438e5b4970..32873fb5f367 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -952,7 +952,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>  	}
>  
>  	ret = twl_i2c_write_u8(TWL6030_MODULE_ID0,
> -				VBAT_MEAS | BB_MEAS | BB_MEAS,
> +				VBAT_MEAS | BB_MEAS | VAC_MEAS,
>  				TWL6030_MISC1);
>  	if (ret < 0) {
>  		dev_err(dev, "failed to wire up inputs\n");