Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Dec 2022 17:42:29 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Dan Carpenter <error27@gmail.com>
Cc:     Christoph Hellwig <hch@lst.de>, oe-kbuild@lists.linux.dev,
        Sagi Grimberg <sagi@grimberg.me>, lkp@intel.com,
        oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: drivers/nvme/host/auth.c:950 nvme_auth_init_ctrl() warn:
 missing error code? 'ret'
Message-ID: <20221223164229.GA31884@lst.de>
References: <202212222333.vrYfUBqM-lkp@intel.com> <20221223154754.GA30339@lst.de> <Y6XVnWCNx6cB7Itw@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y6XVnWCNx6cB7Itw@kadam>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Fri, Dec 23, 2022 at 07:21:49PM +0300, Dan Carpenter wrote:
> > -	if (!ctrl->opts->dhchap_secret && !ctrl->opts->dhchap_ctrl_secret)
> > +	if (!ctrl->host_key && !ctrl->ctrl_key)
> >  		return ret;
> 
> ret is uninitialized now.

Yes.  Should be a 'return 0'.

We really need to turn the maybe uninitialized warnings back on.