Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp911891rwj; Fri, 23 Dec 2022 09:39:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXuxxxF/l0PywYIRAAnP+33TLksOa33nuhm/W8EJShcN3qr8LVP/eY7cuigOtR9yG83EIwds X-Received: by 2002:a05:6a00:1c92:b0:576:f322:419f with SMTP id y18-20020a056a001c9200b00576f322419fmr10413668pfw.28.1671817151533; Fri, 23 Dec 2022 09:39:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671817151; cv=none; d=google.com; s=arc-20160816; b=VY5K1Acb9Yt8NYgWJ5D0cBnRR6lfwE4A0nUZ6L7msus4GOoJQblXUYhkiN2QRfpB1f Vipuu9Qdxhw5KgkyB87uyXX6tlsLLh8waNnZ82AbYPJBVfYnEDtVX/8tnxNHCglnekSQ XO//GjZ97Q8XYeIIJaCh81JTtkBKaHhbgJ9E5rAVPu77fcNm10tOiKV/n4mHEiO1Hj23 nc1LdjfAaN58uv+owYp2NyQ9F6voEoR+sCjDO9C1Q8OwHFgbsmimZOHekHFRxyrF5ye5 LRMoVrEGM69a47CzT4rvihk6cbJW9CeWjAyqh3FABbXssFKJFNqlVWPO/3YkSxXtJ+2N Uq+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Otc9hVPnb4uEiMojoyOvNAsTxJu3nDfQNUlQmeQ8aE0=; b=TyLO4yuuBsdxgSlzw6ypSgPPLEwsMaeFPgdK2l0k7InHYW+O8Pgqzc2DXhqNDm6qKo TZd44L6E7pfAx+eaO+9s9F8hSI/+AjrIVqHPoHBI+pXhBsZzEkTE68b49XpKjuGVQPpI jaX03pTatbwh7/HO0Ghl/pDt/3JaVTkfmwn85DPYpRgbXpXiD0YThthWRZSNkh52TAta VAvXZmBjTWr6VJUEplrU+GeG/5pgu4dH7IAHt3GPT2WToGj96iHzM3/FSMZC6H6TQjpw XE+ufIWWWt8PVWAG9CsxYRtMDksECt3IkYZR7nWb1RvF3atnwxEBt5np2KX/T6S+1KZO nocQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=L4E35C1b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y2-20020aa793c2000000b0056b81818621si3867965pff.157.2022.12.23.09.39.02; Fri, 23 Dec 2022 09:39:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=L4E35C1b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231922AbiLWQbf (ORCPT + 65 others); Fri, 23 Dec 2022 11:31:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231238AbiLWQbK (ORCPT ); Fri, 23 Dec 2022 11:31:10 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D639615A for ; Fri, 23 Dec 2022 08:31:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Otc9hVPnb4uEiMojoyOvNAsTxJu3nDfQNUlQmeQ8aE0=; b=L4E35C1bu1mLdsdwy2A24aW9i0 BlSAurOdUGmUVBZRuV5dLvXjsXHDhmw1dZhnP+Ux+dGYfGTUAdeshJ6BfmsbcJLh+YAq6rro4MOGt bN4ocBY1x3Ebl/ByzMhXiUwXjbQhTa9ghEEi7oPe5zrewdlqbVwQZLLvKt8mDCq7My+FLW886Kxoo XSagG2jM3FJFxlZ7XeaVmTHtj3m1LtWUpq1L6cJAElnMl5XRCYPuQp/g9foPFdlMi4lR6H6dSqDY3 6vVDJB+1tUM7sUvaDs9nLcboX1NnKEqRskCuOxMSRK6nso0WbYY7g0mPGYD3f908lBaOe7oRG6tGv LvYJpN0w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8kwt-009ztr-B2; Fri, 23 Dec 2022 16:31:07 +0000 Date: Fri, 23 Dec 2022 08:31:07 -0800 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv2 06/11] dmapool: move debug code to own functions Message-ID: References: <20221216201625.2362737-1-kbusch@meta.com> <20221216201625.2362737-7-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216201625.2362737-7-kbusch@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static inline void pool_check_block(struct dma_pool *pool, void *retval, > + unsigned int offset, gfp_t mem_flags) > +{ > +#ifdef DMAPOOL_DEBUG We normally keep the ifdef outside the function and provide stubs. Extra points for keeping all the debug helpers in a single ifdef block.