Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp921361rwj; Fri, 23 Dec 2022 09:48:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXudwmfvih+rCH4NsFsP2EwIJ6G2t/4Z18ZhSC8cnwXUbv3iVsYvnCYF2W6/XreIa0HR0a96 X-Received: by 2002:aa7:9255:0:b0:566:900e:1023 with SMTP id 21-20020aa79255000000b00566900e1023mr11637840pfp.3.1671817712413; Fri, 23 Dec 2022 09:48:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671817712; cv=none; d=google.com; s=arc-20160816; b=ibca4dHL+PR7nBb8Ahl72HxhCcWl2eby4KeQcJ/NQ5AE8jjbW375vHZ60mkta4eXLw S3p0Xdx1whepZeeVcnt/0VTRaO8oAoknIUVukQNfomHcTi8S+c5bj6YQeGj5K7eJbWSY iAaqRL3ONOhGNbkgv7nDRC/yrUi6g6PJrp3yRzYcxG3AzB0zO6i1binHMmdXegKdVuiQ 1c41jnYVScvMoj8/6cDPN64Kwo9/myhoIBp6Kb8iz9st7/f7QoSAlc1/cCVJhV1que6W W/7oM/GvRwOs8T1svRuvy5n/RdJTPKZMdVwBjlBrnkLfBc04yaiGK/Ib/LtgIMoZVwHa nSgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0cZ0mt91TyzNw0HU5DsG1MlYLdTdSBQN+CWQAWeWbAs=; b=G0L9DvMPFVp+fS2RGWOxItC6jf3JkNctjVl+Afb9azMe9dLnulrIum9J+R5H1hns2t PgES7g8PubPyOKVe5TuqVNAlyE//Hzr69XFhYkBcN4aNfEVQnrca3/iefcKckis8yzoS ZdBDEbNH3mpd5gKTXqxm3Z36Y1ZgTa5ZWbchnMrOt8i+fJZmidvpXTfRKH4sD66DWK9U 66YrgzMJii1QEZfzXl2G0Oq0lFK6Vh9zyhEnUX/dRk31HdcWhhOz2c7NRuOQyIuJxoWC 5Ggs7dJLi+r7H9YwH52VH6ep6jpjhODqWOoUiPwKknvUFBGU2YAgYkE6fb+r97xY4s/X YwSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="G7X/ycTh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a056a000ac500b00576950b449asi4057092pfl.351.2022.12.23.09.48.23; Fri, 23 Dec 2022 09:48:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="G7X/ycTh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231229AbiLWRRA (ORCPT + 65 others); Fri, 23 Dec 2022 12:17:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232613AbiLWRP2 (ORCPT ); Fri, 23 Dec 2022 12:15:28 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FF1CF58D for ; Fri, 23 Dec 2022 09:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=0cZ0mt91TyzNw0HU5DsG1MlYLdTdSBQN+CWQAWeWbAs=; b=G7X/ycThvePMUp6sX4GXGyf4gf laY9P5zoVQeWo7ULj06Z+TUMqp6dPpstZMJeTHWhP2EsHJE6FJNO+O2+RT0249LNp6jBi+H/+A6Wk d47u3JR71cla1iYa0R0mdrcPXBLIlF7RSA8PGgadPrI9kOsdwMs2VXv7t4NfZNYiKdta3WuBhckiI CSKzzo4A9ymV6Tmzyo+UHKRl7tqpQllT/s0mJA9lmSMhkVrAErZI0qqi+Wr8/Z0nmMFhuwAeV0Zcb rrw0t7vHaWMsg3fu2BPqxi9DC65J6FO1/Jk9PR+QED1vle+v6mhbOFBsVrPseVpaI11FDaeIgSvVY rWQjRLDg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8ldj-00AIpJ-NW; Fri, 23 Dec 2022 17:15:23 +0000 Date: Fri, 23 Dec 2022 09:15:23 -0800 From: Christoph Hellwig To: Tony Battersby Cc: Christoph Hellwig , Keith Busch , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Kernel Team , Keith Busch Subject: Re: [PATCHv2 11/11] dmapool: link blocks across pages Message-ID: References: <20221216201625.2362737-1-kbusch@meta.com> <20221216201625.2362737-12-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2022 at 12:08:54PM -0500, Tony Battersby wrote: > I previously recommended that they should be size_t because they are > counting the number of objects in the entire pool, which can be greater > than 2^32.?? See patch 4 "dmapool: cleanup integer types". Oh, ok. > ? However the > kernel test robot has complained that some of the printk format > specifiers need to be changed to match the size_t type. Yes, they do.