Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9d58b20-5ce5-ebfd-bcfa-523086b66739@cybernetics.com>
Date:   Fri, 23 Dec 2022 12:08:54 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCHv2 11/11] dmapool: link blocks across pages
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>,
        Keith Busch <kbusch@meta.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Matthew Wilcox <willy@infradead.org>,
        Kernel Team <kernel-team@meta.com>,
        Keith Busch <kbusch@kernel.org>
References: <20221216201625.2362737-1-kbusch@meta.com>
 <20221216201625.2362737-12-kbusch@meta.com> <Y6XeJ2mzd8p73J93@infradead.org>
From:   Tony Battersby <tonyb@cybernetics.com>
In-Reply-To: <Y6XeJ2mzd8p73J93@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/23/22 11:58, Christoph Hellwig wrote:
> On Fri, Dec 16, 2022 at 12:16:25PM -0800, Keith Busch wrote:
>>  	unsigned int size;
>>  	unsigned int allocation;
>>  	unsigned int boundary;
>> +	size_t nr_blocks;
>> +	size_t nr_active;
>> +	size_t nr_pages;
> Should these be unsigned int like the counters above?

I previously recommended that they should be size_t because they are
counting the number of objects in the entire pool, which can be greater
than 2^32.   See patch 4 "dmapool: cleanup integer types".  However the
kernel test robot has complained that some of the printk format
specifiers need to be changed to match the size_t type.

Tony Battersby
Cybernetics