Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Dec 2022 13:22:08 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        David Hildenbrand <david@redhat.com>,
        Michal Hocko <mhocko@suse.com>, Peter Xu <peterx@redhat.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Matthew Wilcox <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Rik van Riel <riel@surriel.com>,
        Will Deacon <will@kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Christian Brauner <brauner@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH] mm: remove zap_page_range and change callers to use
 zap_vma_page_range
Message-ID: <Y6YcAKT+vVIyWTkF@monkey>
References: <20221216192012.13562-1-mike.kravetz@oracle.com>
 <Y6XW3hMtB7PrTSM5@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y6XW3hMtB7PrTSM5@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zo7vqLWEY58VihFZ7RdJ3LXXgUP0NYY9ob7WJOLRG4RiD9Vg9eSvaLDc89Rw?=
 =?us-ascii?Q?jDx+JP6qF5BQopiOmm0hq8IfQiLtSsOXyHzFG7mS3JA6eMkQ8Y0uH6W04k6S?=
 =?us-ascii?Q?Mn7vS4dLcMYGhTEGN3yRZtP2ncGISH8X8z9LPSFkmUTnsxpwj8y7dOYt0Db9?=
 =?us-ascii?Q?6+3G2WCxnYcatwTz4NWaI2DnUd6bbhb+nRF4W+4a8nDZhJ/12eZx4E855p+Z?=
 =?us-ascii?Q?8rWCILuOfgZbPR7/GYzHlddAsjyyAW48uxRFi1HtLP6mOXXU7di9F5ErM0RQ?=
 =?us-ascii?Q?NOX7he4jyVvXZq5kL4oLtg2G3G7/UTRIfOeuMYbrKVY04WgA3kKGXEj6WZCA?=
 =?us-ascii?Q?tG3vxJjY7ucNvfvj2OEpjjfJruVTQ9jUyzxJIw7t55gv9cvnskIPks+aVgjM?=
 =?us-ascii?Q?/KH7Qod5fXnZqK9GlbYACQVNgelUkiKFatHWil7iJ+PmzYMwFvElcUryUKHT?=
 =?us-ascii?Q?q35bOVBPsZJGtiHhMmx4c23iRKaREmXAsDEuIsgpKKl7F9P61Z+TrhxFbep1?=
 =?us-ascii?Q?1aN7zmahiEpzBhld2jDd6i6LhvO+UBm5qJYR/jBDOflDnyajUsR76F2lGnys?=
 =?us-ascii?Q?bYZOKzcgHgTNz2b8H9FhYpSED5atoDM/oqANCuW0tvGFnD5ws2cvCLO2Ev10?=
 =?us-ascii?Q?KHDd+wwSx+4sOHFVI7kb8n9K6Gmu4geVCb//xTrOX20dkZb/xx7DKc3p090q?=
 =?us-ascii?Q?GDACvbj+sPXMrpmxdvHvKvsNlfDxHykWxI4Mk65bqAAAcgTTmq3W9yCi6H9m?=
 =?us-ascii?Q?ghe/F6gkNzLkZVP1thj6WjAZ5VnnjrpIoQAJgPXX/SQ2Etl0Zi2BAokbqHUG?=
 =?us-ascii?Q?w71ig5qtNGahHWtQA3zz6ZsPx/x72H5EfNzW7ao19uaZ+hQSRwSajr17HrEw?=
 =?us-ascii?Q?KEqBiqXxIfCCKdktTsdQnGtJuHldSnkxmZXzaUYlfOqXDeDDiSvTmAQJVaGB?=
 =?us-ascii?Q?iFobxZLIC3Mtnxc6qK7V8NmhYgj5tsZJwzPhHbTe1b2FCJQUSMuQ4Sx0Slw7?=
 =?us-ascii?Q?eg7onm9lJYIIsbkpF6aF9aTGHtLIWIssdPL5+UNa+4E/mn7ynJxtfC5O5DAc?=
 =?us-ascii?Q?UICwGtZ++VTnjlKaR/JI7HqzkS2/zw+d/9XWsTf7OqDimAQPncGOhe1IKXWS?=
 =?us-ascii?Q?vrQfTBve9IA71Txwu5F+OVz5vkF/Iyh4Qu8tire/3L879FhRfV3s+EZ/VnRB?=
 =?us-ascii?Q?qR2t24whSmM+Myigqj9UX29TiBJvGltCsu7lKiFysBwXvMojYhomj/uzbnRg?=
 =?us-ascii?Q?cHkBOkMCOVoOR4Fwa7Z6zqbtV1dKwji8qQiis2zsPdnw4Fh58bYecv3sFn36?=
 =?us-ascii?Q?49YJXSMPc+OzaeF6gTb7qPi66Ihxr/Gljbp6ELFrm7yrM0X3GEMVccwgis7H?=
 =?us-ascii?Q?HZQ/FNTO2m/MymYsry1kIDUL3TgS63ngZmMk2DiuLdtHWJzOw35hD9x9TjlS?=
 =?us-ascii?Q?n57xVSeU5elzFFAcmfiw0XS9fx5Apawgmw0msbnvDpBCsC9JbcCESh4CL12H?=
 =?us-ascii?Q?XaAALMaK0VNl42tbxvdcrWBSaKFONtYx9nhc+NQFPKmbC5DTQ2/3Tsn1nb2f?=
 =?us-ascii?Q?SJ2xvz1OVTTpZywzcrHYwH5vEIvKlNghQLZHHzN1nvHzLVWshtzkuC5rzCCg?=
 =?us-ascii?Q?SQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c5ac313-d715-4560-c032-08dae52bc100
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2022 21:22:11.3096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hJUt25Q0xuyN3JdiX8QD5hMDg7x/LjPCT7S9F4XuKYCEWP2yYZo6ZKshB3BQkeuWxntv2yIpAJwTja2CzP8cCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6522
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-23_08,2022-12-23_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2212230178
X-Proofpoint-GUID: TindufSzVaaX12-dPvfre_Qe4CneRmZ_
X-Proofpoint-ORIG-GUID: TindufSzVaaX12-dPvfre_Qe4CneRmZ_
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/23/22 08:27, Christoph Hellwig wrote:
> >  		unsigned long size = vma->vm_end - vma->vm_start;
> >  
> >  		if (vma_is_special_mapping(vma, vdso_info[VDSO_ABI_AA64].dm))
> > -			zap_page_range(vma, vma->vm_start, size);
> > +			zap_vma_page_range(vma, vma->vm_start, size);
> >  #ifdef CONFIG_COMPAT_VDSO
> >  		if (vma_is_special_mapping(vma, vdso_info[VDSO_ABI_AA32].dm))
> > -			zap_page_range(vma, vma->vm_start, size);
> > +			zap_vma_page_range(vma, vma->vm_start, size);
> >  #endif
> 
> So for something called zap_vma_page_range I'd expect to just pass
> the vma and zap all of it, which this and many other callers want
> anyway.
> 
> > +++ b/arch/s390/mm/gmap.c
> > @@ -722,7 +722,7 @@ void gmap_discard(struct gmap *gmap, unsigned long from, unsigned long to)
> >  		if (is_vm_hugetlb_page(vma))
> >  			continue;
> >  		size = min(to - gaddr, PMD_SIZE - (gaddr & ~PMD_MASK));
> > -		zap_page_range(vma, vmaddr, size);
> > +		zap_vma_page_range(vma, vmaddr, size);
> 
> And then just call zap_page_range_single directly for those that
> don't want to zap the entire vma.

Thanks!

This sounds like a good idea and I will incorporate in a new patch.

-- 
Mike Kravetz