Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221212045558.69602-1-gch981213@gmail.com> <20221212045558.69602-3-gch981213@gmail.com>
 <c592dd31-5e9a-c2a2-1c70-46b7cffa9c5d@linaro.org> <Y6XjHNCLXY9s1IOF@duo.ucw.cz>
In-Reply-To: <Y6XjHNCLXY9s1IOF@duo.ucw.cz>
From:   Chuanhong Guo <gch981213@gmail.com>
Date:   Sat, 24 Dec 2022 13:52:27 +0800
Message-ID: <CAJsYDV+Dth6BFhXhhZsWuJvySh92=5++_TA50ZDj+DrHUN1niw@mail.gmail.com>
Subject: Re: [PATCH v4 2/3] dt-bindings: leds: add worldsemi,ws2812b
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-leds@vger.kernel.org, Lee Jones <lee@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Stanislav Jakubek <stano.jakubek@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Johan Hovold <johan+linaro@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi!

On Sat, Dec 24, 2022 at 1:19 AM Pavel Machek <pavel@ucw.cz> wrote:
> > In general I am fine with it, although there is still question for
> > adding more multi-color defines in binding headers to replace this
> > property - GRB/RBG/GBR and even more for RGBW.
> >
> > Pavel, Lee, any thoughts from your side?
>
> This really needs to mention the name this hardware is known as -- I
> believe it is NeoPixel.

I'll do so in the next version. I'm actually waiting for an answer to the
comment from Krzysztof (whether I should change color-index) before
sending v5 :)

-- 
Regards,
Chuanhong Guo