Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Dec 2022 13:24:39 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@infradead.org>,
        Thomas Maier <balagi@justmail.de>, linux-block@vger.kernel.org
Subject: Re: [PATCH] pktcdvd: remove driver.
Message-ID: <Y6bvh48kTTzbMX6M@kroah.com>
References: <20221202182758.1339039-1-gregkh@linuxfoundation.org>
 <20221224095353.w32xhmyzlft6qi4v@pali>
 <Y6bObzIoHrJMotI3@kroah.com>
 <20221224101139.sgvhr2n3pbrs4agm@pali>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221224101139.sgvhr2n3pbrs4agm@pali>
Precedence: bulk

On Sat, Dec 24, 2022 at 11:11:39AM +0100, Pali Roh?r wrote:
> On Saturday 24 December 2022 11:03:27 Greg Kroah-Hartman wrote:
> > On Sat, Dec 24, 2022 at 10:53:53AM +0100, Pali Roh?r wrote:
> > > On Friday 02 December 2022 19:27:58 Greg Kroah-Hartman wrote:
> > > > Way back in 2016 in commit 5a8b187c61e9 ("pktcdvd: mark as unmaintained
> > > > and deprecated") this driver was marked as "will be removed soon".  5
> > > > years seems long enough to have it stick around after that, so finally
> > > > remove the thing now.
> > > 
> > > Why to remove? This driver is still widely used, userspace in active
> > > maintenance and in last two years userspace software received more fixes
> > > for CD-RW support and pktcdvd.
> > 
> > It was marked as "please remove" back in 2016, why wasn't that changed
> > if people were actually using this?
> 
> And how should I know it if I was informed about it just today?

Using the "Why was I not informed?" defense isn't usually the best way
to discuss things when we have 800+ maintainers and 4000+ developers
here :)

> > > Just now community person informed me that somebody is going to remove
> > > kernel support.
> > 
> > Isn't there better ways to support the hardware needed than this driver?
> 
> Is there any other driver in kernel which provide block layer for it?
> I do not know about any other.

What about the venerable sg.c driver (enabled with CONFIG_CHR_DEV_SG)?
Does that not work properly for your specific hardware?

Anyway, have a nice holiday!

greg k-h