Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <66ef2f70-9405-fe09-7927-143084286d1b@gmail.com>
Date:   Sun, 25 Dec 2022 00:03:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
To:     Nicolas Frayer <nfrayer@baylibre.com>, nm@ti.com,
        ssantosh@kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        grygorii.strashko@ti.com, khilman@baylibre.com,
        mkorpershoek@baylibre.com
References: <20221221200513.676744-1-nfrayer@baylibre.com>
Content-Language: en-US
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>
Subject: Re: [PATCH] soc: ti: k3-ringacc: Add try_module_get() to
 k3_dmaring_request_dual_ring()
In-Reply-To: <20221221200513.676744-1-nfrayer@baylibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Nicolas,

On 21/12/2022 22:05, Nicolas Frayer wrote:
> When the k3 ring accelerator driver has been modified to add module build
> support, try_module_get() and module_put() have been added to update the
> module refcnt. One code path has not been updated and it has introduced
> an issue where the refcnt is decremented by module_put() in
> k3_ringacc_ring_free() without being incremented previously.
> Adding try_module_get() to k3_dmaring_request_dual_ring() ensures the
> refcnt is kept up to date.

Good catch!
I had never had my hands on a device with DMSS (BCDMA/PKDMA) and the
original module support was developed and tested on devices with UDMA.

can you add the fixes tag along with my reviewed by tag?

Fixes: c07f216a8b72 ("soc: ti: k3-ringacc: Allow the driver to be built as module")
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> ---
>   drivers/soc/ti/k3-ringacc.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c
> index e01e4d815230a..8f131368a7586 100644
> --- a/drivers/soc/ti/k3-ringacc.c
> +++ b/drivers/soc/ti/k3-ringacc.c
> @@ -406,6 +406,11 @@ static int k3_dmaring_request_dual_ring(struct k3_ringacc *ringacc, int fwd_id,
>   
>   	mutex_lock(&ringacc->req_lock);
>   
> +	if (!try_module_get(ringacc->dev->driver->owner)) {
> +		ret = -EINVAL;
> +		goto err_module_get;
> +	}
> +
>   	if (test_bit(fwd_id, ringacc->rings_inuse)) {
>   		ret = -EBUSY;
>   		goto error;
> @@ -421,6 +426,8 @@ static int k3_dmaring_request_dual_ring(struct k3_ringacc *ringacc, int fwd_id,
>   	return 0;
>   
>   error:
> +	module_put(ringacc->dev->driver->owner);
> +err_module_get:
>   	mutex_unlock(&ringacc->req_lock);
>   	return ret;
>   }

-- 
Péter