Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 25 Dec 2022 06:16:56 +0000
From:   Wei Yang <richard.weiyang@gmail.com>
To:     Wei Yang <richard.weiyang@gmail.com>
Cc:     Liam.Howlett@oracle.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] maple_tree: should get pivots boundary by type
Message-ID: <20221225061656.o7bl66m7oez4q67m@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20221112234308.23823-1-richard.weiyang@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221112234308.23823-1-richard.weiyang@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

May I ask who would pick this?

On Sat, Nov 12, 2022 at 11:43:08PM +0000, Wei Yang wrote:
>We should get pivots boundary by type.
>
>Fixes: 54a611b60590 (Maple Tree: add new data structure)
>Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
>Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
>
>---
>* kernel build looks good
>---
> lib/maple_tree.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/lib/maple_tree.c b/lib/maple_tree.c
>index 73e2e6434e2f..2123d1930a9b 100644
>--- a/lib/maple_tree.c
>+++ b/lib/maple_tree.c
>@@ -669,12 +669,13 @@ static inline unsigned long mte_pivot(const struct maple_enode *mn,
> 				 unsigned char piv)
> {
> 	struct maple_node *node = mte_to_node(mn);
>+	enum maple_type type = mte_node_type(mn);
> 
>-	if (piv >= mt_pivots[piv]) {
>+	if (piv >= mt_pivots[type]) {
> 		WARN_ON(1);
> 		return 0;
> 	}
>-	switch (mte_node_type(mn)) {
>+	switch (type) {
> 	case maple_arange_64:
> 		return node->ma64.pivot[piv];
> 	case maple_range_64:
>-- 
>2.33.1

-- 
Wei Yang
Help you, Help me