Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp889335rwl; Sun, 25 Dec 2022 09:04:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXvj9GYMrst8EH1CuXbs8p5Ak2b71U660Ds3t8hfEXHMfJ48BJ+mHiISSfbczI5elqHKbwDx X-Received: by 2002:a62:168e:0:b0:56c:a75d:43e6 with SMTP id 136-20020a62168e000000b0056ca75d43e6mr18477376pfw.1.1671987886921; Sun, 25 Dec 2022 09:04:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671987886; cv=none; d=google.com; s=arc-20160816; b=PQ3Jj2gCIn1O4bbq+SkvoM47PXq3+JxVdVzzlkakeCU/tNnx/E72nehHFVXPr3K3p3 9tiJFciS04dR/rpTqDrSnzaH4JPZYvkHRx9/ehYm11aodGDeJm3X5uS7Znut4mziuhtq QCcwxws1CIJMlytC+AN3PhwL7L17eSvqapTwpCJVoJv1bvdwANy1DKiIHMKLkCoBBQYS rcIPgCGapv8rLfWHqDgGa03ZsXMuuQsTAgDgN2S4VDPDyFcxu2N0o8N0Qoh/76aOvSdG fc33HR2Q/AZ2v104DncO8nS+zrMc5yS30vOxdpu006s+H6HCSXu2WpWnIbL1SE/BNkcj 1QNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Cba7a4CNg3T6ktAC4rnAyxADOxp4yPgdrX7lNI9dXpg=; b=F9NRj7VoxGeTM1mnOt3WTixxo2WBKSAkC76TBcFk/wQ8pnIC25sorDsM41vOBjgVBl 3C3fjcax5T+md6gRe09CqXSk9mXXBSsgIcB62Yp53mGRrYteaU+iV+tXZyLUxTbOmQ7q QltMqHB+/EE2EoJ4k/Gz0VF0XoTLC1xuQLKoXMjh46c8W5OVwjBQlRid/30bNR9Bc5VS WuYri/0g60hNYM52hbeYQ5vbK6aFWvqW+fCtjnAL/ibboZJThq7GNUURUZ8xXjGVgtXg Oo2e/3yzr8WynvwUR1K/K+Gzl2W8wVRF3kfGrhlv/E/E15iRh8Y22n4RBm5Burx186Vk sQXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="H0Aj/Vin"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a056a00124d00b0053e15843f1fsi9451070pfi.131.2022.12.25.09.04.38; Sun, 25 Dec 2022 09:04:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="H0Aj/Vin"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229540AbiLYRBe (ORCPT + 66 others); Sun, 25 Dec 2022 12:01:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231230AbiLYRBa (ORCPT ); Sun, 25 Dec 2022 12:01:30 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B923F2675; Sun, 25 Dec 2022 09:01:28 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id p13-20020a05600c468d00b003cf8859ed1bso6489533wmo.1; Sun, 25 Dec 2022 09:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cba7a4CNg3T6ktAC4rnAyxADOxp4yPgdrX7lNI9dXpg=; b=H0Aj/Vinm/zwqMAF2JdMoqdNwUcHXNSZjxw25hpLmoeQGxLZI7rhyg8fk0QBLTcJYY mhF6/2ucKw07Yr2DZfM/rhjEMG5/43flkqnOFoERH2L96XanqNyYJKepIbnkeaD3Ka7w SubIsAasXZO5nNE1TplUqh1R3/ESoKEjY5AQHJAvM1wDD5HwkMK7NcYLPO7p4MeJUvkh owE1G92lGsAMkFtAdTB63cc9dh9y5xlVzoaCtZk8WycsKUGODr1cvElxx3BX31vQkI6q lBT4InUeoVf4s+fXggMZaDHCanExMhRcx1fvLgmrsmLG9iKRb8v79wxlBSCy7qXu5cjb tWlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cba7a4CNg3T6ktAC4rnAyxADOxp4yPgdrX7lNI9dXpg=; b=nnr4PlGcu1w6ll0EUz3rQCV2AdOpdUsKDj6FqFhT+f8seQJK0BraJWasrLujvYAKsM T1TNHx2qMhwxU7OyCoAmORigkExn6KHVkuHIxoVONDwVZTXI92lJzsmLkzI0Agl05/VM uIt0WsI/06AN00xqn/iBTpUG7a2JyW3Smi3pgZggcXF6PknsLQ8CVkECuYbJANAUcyLL L5UaNqh676/nLnVzgWSJd3yknHAuQFSZYSvTNcxcSVZ2HerV2QRJWD82T9UcF7PnEAwG 1IoYE6EzJDYDNRK9GkLWqlgYGrMJxyWLNoyHIYh7ZKeTa9KBI3h4AxeS+0zeQ+Aqjvcf srEg== X-Gm-Message-State: AFqh2kpv4+FD3/8my4Y2HtytgyJwaVyvroxxO7dwjQ3noacBdzh5LRiI iAtwdHTe/Ekdl608A0HUdIWNVoF2aP0= X-Received: by 2002:a05:600c:5008:b0:3cf:6f4d:c25d with SMTP id n8-20020a05600c500800b003cf6f4dc25dmr11618497wmr.21.1671987687086; Sun, 25 Dec 2022 09:01:27 -0800 (PST) Received: from localhost.localdomain (188.red-83-35-57.dynamicip.rima-tde.net. [83.35.57.188]) by smtp.gmail.com with ESMTPSA id k2-20020a05600c1c8200b003d974076f13sm5812308wms.3.2022.12.25.09.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Dec 2022 09:01:26 -0800 (PST) From: Angel Iglesias To: linux-iio@vger.kernel.org Cc: Angel Iglesias , Jonathan Cameron , Lars-Peter Clausen , Paul Cercueil , "Rafael J. Wysocki" , Ulf Hansson , linux-kernel@vger.kernel.org Subject: [PATCH 5/5] iio: pressure: bmp280: Add nvmem operations for BMP580 Date: Sun, 25 Dec 2022 18:00:53 +0100 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pressure sensor BMP580 contains a non-volatile memory that stores trimming and configuration params. That memory provides an programmable user range of three 2-byte words. Signed-off-by: Angel Iglesias diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c index 005dbaf18607..4e0d89a71eab 100644 --- a/drivers/iio/pressure/bmp280-core.c +++ b/drivers/iio/pressure/bmp280-core.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -1628,8 +1629,140 @@ static const int bmp580_odr_table[][2] = { [BMP580_ODR_0_125HZ] = {0, 125000}, }; +const int bmp580_nvmem_addrs[] = { 0x20, 0x21, 0x22 }; + +static int bmp580_nvmem_read(void *priv, unsigned int offset, void *val, + size_t bytes) +{ + struct bmp280_data *data = priv; + u16 *dst = val; + int ret, addr; + + pm_runtime_get_sync(data->dev); + mutex_lock(&data->lock); + + /* Set sensor in standby mode */ + ret = regmap_update_bits(data->regmap, BMP580_REG_ODR_CONFIG, + BMP580_MODE_MASK | BMP580_ODR_DEEPSLEEP_DIS, + BMP580_ODR_DEEPSLEEP_DIS | + FIELD_PREP(BMP580_MODE_MASK, BMP580_MODE_SLEEP)); + if (ret) { + dev_err(data->dev, "failed to change sensor to standby mode\n"); + return ret; + } + /* Wait standby transition time */ + usleep_range(2500, 3000); + + while (bytes >= sizeof(u16)) { + addr = bmp580_nvmem_addrs[offset / sizeof(u16)]; + + ret = regmap_write(data->regmap, BMP580_REG_NVM_ADDR, + FIELD_PREP(BMP580_NVM_ROW_ADDR_MASK, addr)); + if (ret) { + dev_err(data->dev, "error writing nvm address\n"); + goto exit; + } + + ret = bmp580_cmd(data, BMP580_NVM_READ_CMD); + if (ret) + goto exit; + + ret = regmap_bulk_read(data->regmap, BMP580_REG_NVM_DATA_LSB, &data->le16, + sizeof(data->le16)); + if (ret) { + dev_err(data->dev, "error reading nvm data regs\n"); + goto exit; + } + + *dst++ = le16_to_cpu(data->le16); + bytes -= sizeof(u16); + offset += sizeof(u16); + } +exit: + /* Restore chip config */ + data->chip_info->chip_config(data); + mutex_unlock(&data->lock); + pm_runtime_mark_last_busy(data->dev); + pm_runtime_put_autosuspend(data->dev); + return ret; +} + +static int bmp580_nvmem_write(void *priv, unsigned int offset, void *val, + size_t bytes) +{ + struct bmp280_data *data = priv; + u16 *buf = val; + int ret, addr; + + pm_runtime_get_sync(data->dev); + mutex_lock(&data->lock); + + /* Set sensor in standby mode */ + ret = regmap_update_bits(data->regmap, BMP580_REG_ODR_CONFIG, + BMP580_MODE_MASK | BMP580_ODR_DEEPSLEEP_DIS, + BMP580_ODR_DEEPSLEEP_DIS | + FIELD_PREP(BMP580_MODE_MASK, BMP580_MODE_SLEEP)); + if (ret) { + dev_err(data->dev, "failed to change sensor to standby mode\n"); + return ret; + } + /* Wait standby transition time */ + usleep_range(2500, 3000); + + while (bytes >= sizeof(u16)) { + addr = bmp580_nvmem_addrs[offset / sizeof(u16)]; + + ret = regmap_write(data->regmap, BMP580_REG_NVM_ADDR, BMP580_NVM_PROG_EN | + FIELD_PREP(BMP580_NVM_ROW_ADDR_MASK, addr)); + if (ret) { + dev_err(data->dev, "error writing nvm address\n"); + goto exit; + } + data->le16 = cpu_to_le16(*buf++); + + ret = regmap_bulk_write(data->regmap, BMP580_REG_NVM_DATA_LSB, &data->le16, + sizeof(data->le16)); + if (ret) { + dev_err(data->dev, "error writing LSB NVM data regs\n"); + goto exit; + } + + ret = bmp580_cmd(data, BMP580_NVM_WRITE_CMD); + if (ret) + goto exit; + + /* Disable programming mode bit */ + ret = regmap_update_bits(data->regmap, BMP580_REG_NVM_ADDR, + BMP580_NVM_PROG_EN, 0); + if (ret) { + dev_err(data->dev, "error resetting nvm write\n"); + goto exit; + } + + bytes -= sizeof(u16); + offset += sizeof(u16); + } +exit: + /* Restore chip config */ + data->chip_info->chip_config(data); + mutex_unlock(&data->lock); + pm_runtime_mark_last_busy(data->dev); + pm_runtime_put_autosuspend(data->dev); + return ret; +} + static int bmp580_preinit(struct bmp280_data *data) { + struct nvmem_config config = { + .dev = data->dev, + .priv = data, + .name = "bmp580_nvmem", + .word_size = sizeof(u16), + .stride = sizeof(u16), + .size = 3 * sizeof(u16), + .reg_read = bmp580_nvmem_read, + .reg_write = bmp580_nvmem_write, + }; unsigned int reg; int ret; @@ -1653,8 +1786,8 @@ static int bmp580_preinit(struct bmp280_data *data) dev_err(data->dev, "preinit: nvm error on powerup sequence\n"); return ret; } - - return 0; + /* Register nvmem device */ + return PTR_ERR_OR_ZERO(devm_nvmem_register(config.dev, &config)); } static int bmp580_chip_config(struct bmp280_data *data) diff --git a/drivers/iio/pressure/bmp280.h b/drivers/iio/pressure/bmp280.h index 27d2abc17d01..e2a093a4f767 100644 --- a/drivers/iio/pressure/bmp280.h +++ b/drivers/iio/pressure/bmp280.h @@ -101,6 +101,9 @@ #define BMP580_FILTER_63X 6 #define BMP580_FILTER_127X 7 +#define BMP580_NVM_ROW_ADDR_MASK GENMASK(5, 0) +#define BMP580_NVM_PROG_EN BIT(6) + #define BMP580_TEMP_SKIPPED 0x7f7f7f #define BMP580_PRESS_SKIPPED 0x7f7f7f -- 2.39.0