Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221224155138.447912-1-masahiroy@kernel.org>
In-Reply-To: <20221224155138.447912-1-masahiroy@kernel.org>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Sun, 25 Dec 2022 19:37:00 +0100
Message-ID: <CANiq72=jDGX+8XobCTFs1-ut38cxQd0m7kEMg7U1Vn+NxtMTwA@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] .gitinogre: update the command to check tracked
 files being ignored
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alex Gaynor <alex.gaynor@gmail.com>, Andrew Davis <afd@ti.com>,
        Kees Cook <keescook@chromium.org>,
        Miguel Ojeda <ojeda@kernel.org>,
        Wedson Almeida Filho <wedsonaf@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Dec 24, 2022 at 4:51 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> The -c was implied for older git versions, but we need to make it
> explicit now.

Perhaps add a `Link:` to Git's commit b338e9f66873 ("ls-files: error
out on -i unless -o or -c are specified")

    https://git.kernel.org/pub/scm/git/git.git/commit/?id=b338e9f668737e08201c990450b8c3d744f63162

> We never know what are locally added to $GIT_DIR/info/exclude or
> $XDG_CONFIG_HOME/git/ignore.

Perhaps we could say "global exclusion file" instead (since it could
be the one from `core.excludesFile` too).

> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

By the way, in the commit title: "gitinogre" -> "gitignore"

Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Cheers,
Miguel