Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <590af263-8278-5fb3-10c1-341b609a77ec@linaro.org>
Date:   Mon, 26 Dec 2022 10:12:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v4 1/3] mtd: spi-nor: Extend SFDP 4byte address
 instruction lookup table with new octal modes as per JEDEC JESD216F
Content-Language: en-US
To:     Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Cc:     greg.malysa@timesys.com,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <pratyush@kernel.org>,
        Michael Walle <michael@walle.cc>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        "open list:SPI NOR SUBSYSTEM" <linux-mtd@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20221202135539.271936-1-nathan.morrison@timesys.com>
 <20221202135539.271936-2-nathan.morrison@timesys.com>
From:   Tudor Ambarus <tudor.ambarus@linaro.org>
In-Reply-To: <20221202135539.271936-2-nathan.morrison@timesys.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Looks good.

On 02.12.2022 15:55, Nathan Barrett-Morrison wrote:
> This adds the new bit fields for
> reading: 1S-1S-8S, 1S-8S-8S, 1D-8D-8D
> programming: 1S-1S-8S, 1S-8S-8S
> 

We usually aim to have ~60 chars for the subject line and 75 chars per
line for the commit message. If you want to reword both, fine, otherwise
I'll do it when applying.

> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
> ---
>   drivers/mtd/spi-nor/sfdp.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
> index 2257f1b4c2e2..e4e87815ba94 100644
> --- a/drivers/mtd/spi-nor/sfdp.c
> +++ b/drivers/mtd/spi-nor/sfdp.c
> @@ -953,11 +953,16 @@ static int spi_nor_parse_4bait(struct spi_nor *nor,
>   		{ SNOR_HWCAPS_READ_1_1_1_DTR,	BIT(13) },
>   		{ SNOR_HWCAPS_READ_1_2_2_DTR,	BIT(14) },
>   		{ SNOR_HWCAPS_READ_1_4_4_DTR,	BIT(15) },
> +		{ SNOR_HWCAPS_READ_1_1_8,       BIT(20) },
> +		{ SNOR_HWCAPS_READ_1_8_8,       BIT(21) },
> +		{ SNOR_HWCAPS_READ_1_8_8_DTR,   BIT(22) },
>   	};
>   	static const struct sfdp_4bait programs[] = {
>   		{ SNOR_HWCAPS_PP,		BIT(6) },
>   		{ SNOR_HWCAPS_PP_1_1_4,		BIT(7) },
>   		{ SNOR_HWCAPS_PP_1_4_4,		BIT(8) },
> +		{ SNOR_HWCAPS_PP_1_1_8,         BIT(23) },
> +		{ SNOR_HWCAPS_PP_1_8_8,         BIT(24) },
>   	};
>   	static const struct sfdp_4bait erases[SNOR_ERASE_TYPE_MAX] = {
>   		{ 0u /* not used */,		BIT(9) },