Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6cf1bb06-86b5-2c55-aec2-e2c414a05b66@riseup.net>
Date:   Mon, 26 Dec 2022 10:22:02 -0300
MIME-Version: 1.0
Subject: Re: [PATCH] HID: uclogic: Use KUNIT_EXPECT_MEMEQ
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        jikos@kernel.org
Cc:     benjamin.tissoires@redhat.com, mairacanal@riseup.net,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221226125736.18053-1-jose.exposito89@gmail.com>
Content-Language: en-US
From:   =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>
In-Reply-To: <20221226125736.18053-1-jose.exposito89@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/26/22 09:57, José Expósito wrote:
> Commit b8a926bea8b1 ("kunit: Introduce KUNIT_EXPECT_MEMEQ and
> KUNIT_EXPECT_MEMNEQ macros") introduced a new macro to compare blocks of
> memory and, if the test fails, print the result in a human friendly
> format. For example, this is the output of a test failure:
> 
>   Expected res == params->expected, but
>       res ==
>        01  02  aa  00  00  00  03  bb  00 <00> 00  04  05
>       params->expected ==
>        01  02  aa  00  00  00  03  bb  00 <01> 00  04  05
> 
> Use this new macro to replace KUNIT_EXPECT_EQ + memcmp.
> 
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>

Reviewed-by: Maíra Canal <mairacanal@riseup.net>

Best Regards,
- Maíra Canal

> ---
>   drivers/hid/hid-uclogic-rdesc-test.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-uclogic-rdesc-test.c b/drivers/hid/hid-uclogic-rdesc-test.c
> index b429c541bf2f..90bf4e586e01 100644
> --- a/drivers/hid/hid-uclogic-rdesc-test.c
> +++ b/drivers/hid/hid-uclogic-rdesc-test.c
> @@ -197,8 +197,7 @@ static void hid_test_uclogic_template(struct kunit *test)
>   					   params->param_list,
>   					   params->param_num);
>   	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, res);
> -	KUNIT_EXPECT_EQ(test, 0,
> -			memcmp(res, params->expected, params->template_size));
> +	KUNIT_EXPECT_MEMEQ(test, res, params->expected, params->template_size);
>   	kfree(res);
>   }
>