Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <32ddf1f8-eda1-da00-a3dc-901c4ee61217@linaro.org>
Date:   Mon, 26 Dec 2022 16:22:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] [v2] mtd: cfi: allow building spi-intel standalone
Content-Language: en-US
From:   Tudor Ambarus <tudor.ambarus@linaro.org>
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <pratyush@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Michael Walle <michael@walle.cc>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Takahiro Kuwano <Takahiro.Kuwano@infineon.com>,
        Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Mauro Lima <mauro.lima@eclypsium.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221220141352.1486360-1-arnd@kernel.org>
 <cae6328b-5204-a1ab-810d-8fb64e466453@linaro.org>
 <20221220165701.5696df1a@xps-13>
 <026225c6-f17f-e9da-b7c0-5d3473a97e89@linaro.org>
In-Reply-To: <026225c6-f17f-e9da-b7c0-5d3473a97e89@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 21.12.2022 08:49, Tudor Ambarus wrote:
> 
> 
> On 20.12.2022 17:57, Miquel Raynal wrote:
>> Hi Tudor,
>>
> 
> Hi,
> 
>> tudor.ambarus@linaro.org wrote on Tue, 20 Dec 2022 17:44:49 +0200:
>>
>>> Hi, Arnd,
>>>
>>> On 20.12.2022 16:13, Arnd Bergmann wrote:
>>>> From: Arnd Bergmann <arnd@arndb.de>
>>>>
>>>> When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver
>>>> fails to build, as it includes the shared CFI header:
>>>>
>>>> include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix 
>>>> selected. No NOR chip support can work. [-Werror=cpp]
>>>>      62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip 
>>>> support can work.
>>>>
>>>> linux/mtd/spi-nor.h does not actually need to include cfi.h, so
>>>> remove the inclusion here to fix the warning. This uncovers a
>>>> missing #include in spi-nor/core.c so add that there to
>>>> prevent a different build issue.
>>>>
>>>> Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM")
>>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Looks good to me. I'll let the linux-0day bot run over it and apply it
>>> once -rc1 is out.
>>
>> The issue sometimes produces build errors, shall I send it through a
>> fixes PR instead?
>>
> 
> Yes, that I was thinking about.
> 

Seems that I shouldn't push to mtd/fixes, so:
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>