Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9bffccfa-ed01-e1a0-8619-75670a340167@amd.com>
Date:   Mon, 26 Dec 2022 08:26:00 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v9 1/4] crypto: ccp - Name -1 return value as
 SEV_RET_NO_FW_CALL
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>,
        Dionna Glaze <dionnaglaze@google.com>,
        Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Peter Gonda <pgonda@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Joerg Roedel <jroedel@suse.de>, Ingo Molnar <mingo@redhat.com>,
        Andy Lutomirsky <luto@kernel.org>,
        John Allen <john.allen@amd.com>,
        "David S. Miller" <davem@davemloft.net>
References: <20221207010210.2563293-1-dionnaglaze@google.com>
 <20221207010210.2563293-2-dionnaglaze@google.com> <Y6R4RC45WXs3Micd@zn.tnic>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <Y6R4RC45WXs3Micd@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmZ5RWxjZHh2MmkwdkprUG5MN2grWVpVaWZOR25FbjI4YmJkOWlnMnA2RGl5?=
 =?utf-8?B?bS9uYlVrUCtwRFdTNUFsbVgwQXg2N2FKZTU0ZUIwUFJwcGcxQTJpYmdCeGVo?=
 =?utf-8?B?TTRnNE1EMVJNOEtOZDVUa3MxV2JWdGtOSVFnN3RxbmJrL3o2bnZVUXpDeWVz?=
 =?utf-8?B?VG54RXBPaVRHdFZqK2dtUWEvYXJHSFNkdi9qd09vMFp2VUI5ZnlYTEZ3OWtj?=
 =?utf-8?B?aUxKYm94WU5kam51bkxpZVA0MW1sM2YyczVHMU5UdXJYb2lxS3F1cCsxWjlk?=
 =?utf-8?B?N3VWdmkxNnNhc29VcVVrQ3hzNHJ2SjN1OUpDelJnYXZDUklzRDhHZEY2amNt?=
 =?utf-8?B?N1FIcFk4MkxCMWg2WDNkSE9TVGtJQkllYnpTb1I0TXhDUk1OVlJwSmJDMWhr?=
 =?utf-8?B?RHdZL21TcS8raTBHNk4xM3FXU0lhREUvMVVNTFpkcXBiSE1CYUI1U1dtQmZV?=
 =?utf-8?B?Y3VkTDhjTmY5WVpxMmRtNU9DYzRJSHdjN0NJNXBIQUtRcVRYVHEwRks5bEtS?=
 =?utf-8?B?NHp0NVVKUWI3dHNxRHh0MTFoQ0dYK1V6QW1YVUViQkRnU1kvK1RicEh3dElL?=
 =?utf-8?B?TmUyRjN1Zyt6Y2w1OWE0aDhlS0d6UlJEdlRmNjhEZU5wKy92MkVFNnZCNkIr?=
 =?utf-8?B?WVVjL1hKK2RSMGlkMmtzVkdrczZoMExGREdnd0lINVVUWlcvb3F4SkpzbDZX?=
 =?utf-8?B?VDBPTFUzWWhQYURBYVIyTHRmNEVzcnc5QW43MFA4ZForaGlMR2FhS0RQL1dK?=
 =?utf-8?B?UXNvQzE2Nnh6TUh5RGZreTF2eWtaeVo0ZXpTb0k0eWlkNGE1d2hpc3QwNGtl?=
 =?utf-8?B?NEVTYk5iUXVWVzFGU2oweFlxNnlDbHlZd1FkR1o1UkV0T0Z3eXk4V29IcDk5?=
 =?utf-8?B?dk93azhYbTA4UkI4d2dmb0xzcCt0eEh3Y2RNYWxnS2Z0YjZqeDV2b1RtMGdQ?=
 =?utf-8?B?azdqcnhYamZ1d1ZTb2Z2aGdpV21FOUdXZDBVczhNODZ3S0FFQUhWNmp3Wlo1?=
 =?utf-8?B?ZlM0bE9abU9SN3dXM013VStOVngxWU5CR3k0L09SY1hlazE0eGc3MmVKTllF?=
 =?utf-8?B?QWd2TnRjTXRiMGo5KzNMUktwME1lV1Q4MzI5Um41YVhweU1lSHo3QVZWMWtk?=
 =?utf-8?B?ejlFTW5XcnpJWkh4Ri83R09OeGpCTjczaHdOVFlKUWFMWE5sMDlnbmR4UnQ1?=
 =?utf-8?B?VGR3WTV6dWN5SlQxU09vME4xeCt3YzBlTkRlU2hlQmJVb2swK1BheWdRdzBX?=
 =?utf-8?B?OUV4NVBEdFNyUU9aS0l3MVN3SWplV2pBY2liVHMza0ozUGtna05QU2JwWk9D?=
 =?utf-8?B?bXUzaUtTOFNncEV6bndGUWc2THNPWXAwL2prNGJWSkpYcTdTNFJnK0l3OCtx?=
 =?utf-8?B?c3VYOWxVSFNZN2lpUXJFakUxcFM5d3dLNmUvTUVVYkR5QldEdStzMmxadExG?=
 =?utf-8?B?UWkzWkpvT09Kam1OMGNvNWtmcU1KNWZYMTZNMVVtMlJGa29pZXN4bXR0Ym1K?=
 =?utf-8?B?Uy9rd2NLMDVWTWg5dVJ0QUNDdUlObno5VHFDVmV4aktuUTFHLzlGYkdyZEpV?=
 =?utf-8?B?cVlxZGVMckpMT1BpejI4N3VDZ3RzZWI5cm5Kc2ZnNTQ1WC9qQTM5SUUyZjJC?=
 =?utf-8?B?elgxbDF0UGlmMDJXeXpkVXFRZW1xMHBHR1h1VjR5eXZ2bDJOWGs0ekRCamFZ?=
 =?utf-8?B?V0lCckVtaDFvUUZISVdRQ3BNZ05SalptaHNoeUEvKzhyVkZzVTRoQURueDlR?=
 =?utf-8?B?WmYyRkw3c2hSQXFvYmNBN0cra3FlSkcrdXIvNzQ2OS9TeHNCTUowcGR6UFd0?=
 =?utf-8?B?SDh4c0cxRWJlSlZ0MCtEZ0xBNHJsZnJaU3NqcmwrcklEbC82TFozT3lzS3o5?=
 =?utf-8?B?N0dYQVZTV1dEVlJtZzZWK1M4R2NydGZMNlZRakdFZWhqYnU0QTZTdEVlcWx4?=
 =?utf-8?B?bnM1aXRtVEhJOWZydXdteW5LTTdFaVU1eitMdVVkZGIxZTRCTGYrcGpQQnhq?=
 =?utf-8?B?bXE2Q24wKzVkSzZnN0RiVHZ6UXdGMk9ybmpTcWx1R3NEQ21wemlSMzZSeGRC?=
 =?utf-8?B?V2M4MEdpcnB4NUhkcy9QOGJ1T1pTWXdQeVhZVTRUenNnTXp3K2FhMy9Hd2tq?=
 =?utf-8?Q?gXRjc5/bO1eVuHoktqLtmx9iR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b05dcc79-4a5d-46e7-cadc-08dae74d1df3
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Dec 2022 14:26:02.8610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fMJD2Gk3CTwZ1GKJhq/daT4mJKirE/AtVrE/iYgcsYD2r9WeSHIYdpEUDLTQifF6gu4gIXfft7ZPdMU1jKNwCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4222
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/22/22 09:31, Borislav Petkov wrote:
> On Wed, Dec 07, 2022 at 01:02:07AM +0000, Dionna Glaze wrote:
>> From: Peter Gonda <pgonda@google.com>
>>
>> The PSP can return a "firmware error" code of -1 in circumstances where
>> the PSP is not actually called. To make this protocol unambiguous, the
>> value is named SEV_RET_NO_FW_CALL.
>>
>> Cc: Thomas Lendacky <Thomas.Lendacky@amd.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Joerg Roedel <jroedel@suse.de>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Andy Lutomirsky <luto@kernel.org>
>> Cc: John Allen <john.allen@amd.com>
>> Cc: Herbert Xu <herbert@gondor.apana.org.au>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Borislav Petkov <bp@alien8.de>
>>
>> Signed-off-by: Peter Gonda <pgonda@google.com>
>> Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
>> ---
>>   Documentation/virt/coco/sev-guest.rst |  2 +-
>>   drivers/crypto/ccp/sev-dev.c          | 22 ++++++++++++++--------
>>   include/uapi/linux/psp-sev.h          |  7 +++++++
>>   3 files changed, 22 insertions(+), 9 deletions(-)
> 
> Looks good, did some minor touch ups ontop, see below.
> 
> @Tom: Ack/Rev-by?

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> 
> @Herbert: ok to carry this through tip?
> 
> Thx.
>