Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221226063625.1913-1-anand@edgeble.ai> <20221226063625.1913-4-anand@edgeble.ai>
 <d0eafc59-6718-f904-132a-1a6dbd083878@gmail.com>
In-Reply-To: <d0eafc59-6718-f904-132a-1a6dbd083878@gmail.com>
From:   Anand Moon <anand@edgeble.ai>
Date:   Mon, 26 Dec 2022 20:52:02 +0530
Message-ID: <CACF1qnecc1J2hzuPSNf8g8Wchy1c+nsGeBZ2yo79=0QjF93QcA@mail.gmail.com>
Subject: Re: [PATCHv2 linux-next 4/4] ARM: dts: rockchip: rv1126: Enable
 Ethernet for Neu2-IO
To:     Johan Jonker <jbx6244@gmail.com>
Cc:     Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Johan,

Thanks for your review comments.

On Mon, 26 Dec 2022 at 18:16, Johan Jonker <jbx6244@gmail.com> wrote:
>
>
>
> On 12/26/22 07:36, Anand Moon wrote:
> > Rockchip RV1126 has GMAC 10/100/1000M ethernet controller.
> > Enable ethernet node on Neu2-IO board.
> >
> > Signed-off-by: Anand Moon <anand@edgeble.ai>
> > ---
> > drop SoB of Jagan Teki
> > ---
> >  arch/arm/boot/dts/rv1126-edgeble-neu2-io.dts | 37 ++++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rv1126-edgeble-neu2-io.dts b/arch/arm/boot/dts/rv1126-edgeble-neu2-io.dts
> > index dded0a12f0cd..bd592026eae6 100644
> > --- a/arch/arm/boot/dts/rv1126-edgeble-neu2-io.dts
> > +++ b/arch/arm/boot/dts/rv1126-edgeble-neu2-io.dts
> > @@ -22,6 +22,43 @@ chosen {
> >       };
> >  };
> >
> > +&gmac {
> > +     clock_in_out = "input";
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&rgmiim1_pins &clk_out_ethernetm1_pins>;
> > +     phy-mode = "rgmii";
> > +     phy-handle = <&phy>;
>
> > +     assigned-clocks = <&cru CLK_GMAC_SRC>, <&cru CLK_GMAC_TX_RX>,
> > +                     <&cru CLK_GMAC_ETHERNET_OUT>;
>
> align
>
Ok,
> > +     assigned-clock-parents = <&cru CLK_GMAC_SRC_M1>, <&cru RGMII_MODE_CLK>;
> > +     assigned-clock-rates = <125000000>, <0>, <25000000>;
> > +     phy-supply = <&vcc_3v3>;
> > +     tx_delay = <0x2a>;
> > +     rx_delay = <0x1a>;
> > +     status = "okay";
> > +};
> > +
> > +&mdio {
>
> > +     phy: phy@0 {
>
> use ethernet-phy
>
Ok,
> no '#phy-cells' here
>
> > +             compatible = "ethernet-phy-id001c.c916",
> > +                            "ethernet-phy-ieee802.3-c22";
>
> align
>
Ok,
> > +             reg = <0x0>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&eth_phy_rst>;
> > +             reset-assert-us = <20000>;
> > +             reset-deassert-us = <100000>;
> > +             reset-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_LOW>;
> > +     };
> > +};
> > +
> > +&pinctrl {
>
> > +     ethernet {
>
> Maybe use a node name more in line with where it is used.
Ok,
>
> > +             eth_phy_rst: eth-phy-rst {
> > +                     rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>;
> > +             };
> > +     };
> > +};
> > +
> >  &sdmmc {
> >       bus-width = <4>;
> >       cap-mmc-highspeed;

Thanks
-Anand