Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Dec 2022 09:38:16 -0800
From:   Lucas De Marchi <lucas.de.marchi@gmail.com>
To:     Florian Weimer <fweimer@redhat.com>
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmod: configure.ac: In _Noreturn check, include
 <stdlib.h> for exit
Message-ID: <20221226173816.ii5hf3zt3pg52ww2@ldmartin-desk2.lan>
References: <877cyq6kh9.fsf@oldenburg.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <877cyq6kh9.fsf@oldenburg.str.redhat.com>
Precedence: bulk

On Sat, Dec 17, 2022 at 05:52:34PM +0100, Florian Weimer wrote:
>Otherwise, an implicit functiona declaration is used, causing
>a C99 compatibility issue.
>
>Signed-off-by: Florian Weimer <fweimer@redhat.com>

applied, thanks

Lucas De Marchi

>
>---
> configure.ac | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/configure.ac b/configure.ac
>index 6989e93..12e0518 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -68,7 +68,8 @@ AC_COMPILE_IFELSE(
>
> AC_MSG_CHECKING([whether _Noreturn is supported])
> AC_COMPILE_IFELSE(
>-	[AC_LANG_SOURCE([[_Noreturn int foo(void) { exit(0); }]])],
>+	[AC_LANG_SOURCE([[#include <stdlib.h>
>+	_Noreturn int foo(void) { exit(0); }]])],
>         [AC_DEFINE([HAVE_NORETURN], [1], [Define if _Noreturn is available])
> 	 AC_MSG_RESULT([yes])],
> 	[AC_MSG_RESULT([no])])
>
>base-commit: 6c5f2f13689e6a4668f87171752d7818bed4b602
>