Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     paolo.valente@linaro.org, jack@suse.cz,
        Yu Kuai <yukuai1@huaweicloud.com>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        yukuai3@huawei.com, yi.zhang@huawei.com
In-Reply-To: <20221226030605.1437081-1-yukuai1@huaweicloud.com>
References: <20221226030605.1437081-1-yukuai1@huaweicloud.com>
Subject: Re: [PATCH] block, bfq: fix uaf for bfqq in bfq_exit_icq_bfqq
Message-Id: <167208188642.23141.13167280199462782271.b4-ty@kernel.dk>
Date:   Mon, 26 Dec 2022 12:11:26 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Mon, 26 Dec 2022 11:06:05 +0800, Yu Kuai wrote:
> Commit 64dc8c732f5c ("block, bfq: fix possible uaf for 'bfqq->bic'")
> will access 'bic->bfqq' in bic_set_bfqq(), however, bfq_exit_icq_bfqq()
> can free bfqq first, and then call bic_set_bfqq(), which will cause uaf.
> 
> Fix the problem by moving bfq_exit_bfqq() behind bic_set_bfqq().
> 
> 
> [...]

Applied, thanks!

[1/1] block, bfq: fix uaf for bfqq in bfq_exit_icq_bfqq
      commit: 246cf66e300b76099b5dbd3fdd39e9a5dbc53f02

Best regards,
-- 
Jens Axboe