Date: Fri, 17 Aug 2007 18:40:34 +0200
From: Adrian Bunk <bunk@kernel.org>
To: "Nelson, Shannon" <shannon.nelson@intel.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       "Williams, Dan J" <dan.j.williams@intel.com>, ssatyam@cse.iitk.ac.in
Subject: Re: [-mm PATCH] DMA engine kconfig improvements (rev2)
Message-ID: <20070817164033.GA32595@stusta.de>
References: <20070817001025.5634.54557.stgit@localhost.localdomain> <20070817004819.GB3786@stusta.de> <BAE9DCEF64577A439B3A37F36F9B691C02E18CCD@orsmsx418.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <BAE9DCEF64577A439B3A37F36F9B691C02E18CCD@orsmsx418.amr.corp.intel.com>
User-Agent: Mutt/1.5.16 (2007-06-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1989
Lines: 61

On Fri, Aug 17, 2007 at 08:59:29AM -0700, Nelson, Shannon wrote:
> >From: Adrian Bunk [mailto:bunk@kernel.org] 
> >Sent: Thursday, August 16, 2007 5:48 PM
> >To: Nelson, Shannon
> >Cc: akpm@linux-foundation.org; linux-kernel@vger.kernel.org; 
> >Williams, Dan J; ssatyam@cse.iitk.ac.in
> >Subject: Re: [-mm PATCH] DMA engine kconfig improvements (rev2)
> >
> >On Thu, Aug 16, 2007 at 05:10:25PM -0700, Shannon Nelson wrote:
> >> From: Adrian Bunk <bunk@stusta.de>
> >> 
> >> This patch contains the following changes to the DMA engine menus:
> >>...
> >> - make it clear in the INTEL_IOATDMA help text that this 
> >driver is for
> >>   rare hardware the user most likely doesn't has
> >>...
> >> +config INTEL_IOATDMA
> >> +	tristate "Intel I/OAT DMA support"
> >> +	depends on PCI && X86
> >> +	select DMA_ENGINE
> >> +	select DCA
> >> +	help
> >> +	  Enable support for the Intel(R) I/OAT DMA engine present
> >> +	  in recent chipsets.
> >>...
> >
> >It seems the string "Xeon" somehow got lost, or is it now also 
> >available with other hardware?
> >
> >"in recent Intel Xeon chipsets"?
> >
> >cu
> >Adrian
> 
> Good catch - however, it is probably best not to limit these things.

Since the effects of CONFIG_NET_DMA are considered big enough to warrant 
all these #ifdef's in the net code it should be made clear for the user 
that this is only for hardware he most likely doesn't has.

And it's not about any kind of kconfig dependency, it's simply about the 
help text.

> sln

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/