Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp2491087rwl; Mon, 26 Dec 2022 16:17:19 -0800 (PST) X-Google-Smtp-Source: AMrXdXvLqKXel+e4O9W3URLi13srjsj1YuJbdR58YPlZl73mAsTe8sfqI+hh0klxnDM1JpUKDErm X-Received: by 2002:a05:6a20:659d:b0:b0:275d:3036 with SMTP id p29-20020a056a20659d00b000b0275d3036mr24381546pzh.24.1672100239571; Mon, 26 Dec 2022 16:17:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672100239; cv=none; d=google.com; s=arc-20160816; b=g9fvT/omkIXHqc94lwn6GFoLzGLoEX9ue/sEP7VN22i+1K6u5YZ4WaThbOxkJ2cDnK uAMBsBEFDreRY29iyKMlmpv4Pr9IXTyV5jy/kLdPLjTAHQlcOeuu4Eh4da0cjPAQro6v ClA5s5Y8oKGjwNrnmFCoLc7GZJlsKb3a6xdExPOO9A7HY+qT9KaKUGN3wszd3zaBmQ2A Vwi2feiv4tKrap/XwgGEwocZwkKyrmgUPdazEXgPTATyVXqTLbIb2pwPbkfPY47EKsJV dPl9HrGWZ3Xfzi+AstPC8m2NygSPCNWns1Da9uS22TMBFvYcd9T+H6azBG5gKPxVpZ/p GBDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=XTFeeqkp8E8DV13l6J+Ks626TIBwyIrqrqVeV3UZPaU=; b=mfYi2fSgIjNJ5k+B/HxQ2eXzHJ7HhmCsABaP6h6k2bRRqiiwLnpitIxZI+pbWj83t5 jVuVPG8F0RA8B8iY0lrb6tkR4gaRtaeQ27zCRpnmsgwa2vT+pc4j02yvc01REzCXmT6R FguaGvbSGP0a06b5Xy4nV4FHjLHBt48YRMWQvYc2h6pUpew+WiuhTBNkY6M8ic5Qq0ew w7pVMKPO0ZzooILgrkBA9wa+pAk/0MyqhndJWv4BOzjh354gH8kPRAdm49OytpPCnUxu mW+kvW8pqQnTdTymIvIGm+W41jzHZIy7E/o70S5gqBpKNEV5FggQSHy0g53b/hG8Vxh+ q0yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HXAWrpyk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i26-20020a63585a000000b00478162cf8e3si12799858pgm.81.2022.12.26.16.17.11; Mon, 26 Dec 2022 16:17:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HXAWrpyk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232542AbiLZXxL (ORCPT + 66 others); Mon, 26 Dec 2022 18:53:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232495AbiLZXxK (ORCPT ); Mon, 26 Dec 2022 18:53:10 -0500 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00260DDD; Mon, 26 Dec 2022 15:53:08 -0800 (PST) Received: by mail-qk1-x734.google.com with SMTP id k2so5641293qkk.7; Mon, 26 Dec 2022 15:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XTFeeqkp8E8DV13l6J+Ks626TIBwyIrqrqVeV3UZPaU=; b=HXAWrpykVRZ6geWMUlrEDnGh0fm4i3u5r+KXp46P8GKtl3mLhTm53go2AdKTNb/dZ8 66y58OufmEBItcDHs2ehWCVwu5RaRbiKStBt+wPMQdfpv7VHJKnsHqbLVy9Au1Eexsop LrYz05UR8tBLtWxlUKE3VsoLhewEbf1o+3PFF2rkaxXFVNUuYww7DE3WLbfENzlxFjHW Px8IRDktM+SpVePPjJxLqfvQCCa+Y5Q4u3z345rQ+IXun+kkaeTW9QGVjkG8vEUae6uD YhgZkNd3LHPScOPwFm8FS07UR1Egu9Ahklr5akXwnMzUAq4WVgU6TrDxKU+R6v4D5GB4 gWFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XTFeeqkp8E8DV13l6J+Ks626TIBwyIrqrqVeV3UZPaU=; b=cacTFNV7Iw7SwmImu26xInXutJm3436by1kkgpBkFdaV2FXOkqwKHhYJbNfb44b3ck OwiCji979zcOh0PB36Kr88JHq2I5jSEJytCqeyQPoZJf95CYupg4rScxsyO0C69P9emv QFMO2uijyg3PNcjc9W+WbV9T8SWDCSHmd7THJRpKI/QcJcw1sg1LeiqH9FMBFMS+on0K mH8B1HnJzMuyWkPUSoDsYDIozaVmFoTPHOc1pvCtCfmAOEVA3ufqOnRrZz7jKK2/3HcP RhZGY7zbW8MiIM0QgRic1rVsXUJDEZSxBrHLxKPP6OJeHY17FK5YAm54BcPO/S9BQB8U gfng== X-Gm-Message-State: AFqh2kr94ihKZRAHdDj7jHAWKkBAbG8X+i61KqGCuxu7t87fjBDkbBpF XY1NxJhb8BglpECjHgYhbj5nomFJDspVRuPKwuw= X-Received: by 2002:a37:592:0:b0:6ff:9cee:cdb7 with SMTP id 140-20020a370592000000b006ff9ceecdb7mr1024293qkf.327.1672098787872; Mon, 26 Dec 2022 15:53:07 -0800 (PST) MIME-Version: 1.0 References: <18b5fa1e-7d1e-4560-c98b-d7ac5fc87c3a@gmx.com> <0036622d-53f7-eaba-f720-6dd9bdca28ad@gmx.com> <41734bdb-2df0-6596-01b6-76a7dfd05d64@gmx.com> In-Reply-To: From: Mikhail Gavrilov Date: Tue, 27 Dec 2022 04:52:57 +0500 Message-ID: Subject: Re: [6.2][regression] after commit 947a629988f191807d2d22ba63ae18259bb645c5 btrfs volume periodical forced switch to readonly after a lot of disk writes To: Qu Wenruo Cc: wqu@suse.com, dsterba@suse.com, Btrfs BTRFS , Linux List Kernel Mailing Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 27, 2022 at 4:36 AM Qu Wenruo wrote: > > > Please be aware that, this newer version may cause extra kernel > warnings, if it found any uninitialized btrfs_tree_parent_check > structure at submit time. > > But there are completely valid cases we can do that, thus it may cause > much larger dmesg output, and you should not rely on the kernel warning > to determine if the bug is triggered. > The kernel failed to built with v2 patch. Here list of compilatore error messages: fs/btrfs/disk-io.c: In function =E2=80=98btrfs_submit_metadata_bio=E2=80=99= : fs/btrfs/disk-io.c:5413:2: error: unterminated argument list invoking macro "WARN_ON" 5413 | } | ^ CC net/ipv4/icmp.o fs/btrfs/disk-io.c:851:17: error: =E2=80=98WARN_ON=E2=80=99 undeclared (fir= st use in this function) 851 | WARN_ON(!memcmp(&check, &bbio->parent_check, | ^~~~~~~ fs/btrfs/disk-io.c:851:17: note: each undeclared identifier is reported only once for each function it appears in fs/btrfs/disk-io.c:851:24: error: expected =E2=80=98;=E2=80=99 at end of in= put 851 | WARN_ON(!memcmp(&check, &bbio->parent_check, | ^ | ; ...... fs/btrfs/disk-io.c:851:17: error: expected declaration or statement at end of input 851 | WARN_ON(!memcmp(&check, &bbio->parent_check, | ^~~~~~~ fs/btrfs/disk-io.c:851:17: error: expected declaration or statement at end of input fs/btrfs/disk-io.c:845:22: warning: unused variable =E2=80=98ret=E2=80=99 [= -Wunused-variable] 845 | blk_status_t ret; | ^~~ fs/btrfs/disk-io.c:844:40: warning: unused variable =E2=80=98check=E2=80=99= [-Wunused-variable] 844 | struct btrfs_tree_parent_check check =3D {0}; | ^~~~~ fs/btrfs/disk-io.c:842:31: warning: unused variable =E2=80=98fs_info=E2=80= =99 [-Wunused-variable] 842 | struct btrfs_fs_info *fs_info =3D inode->root->fs_info; | ^~~~~~~ HDRTEST usr/include/linux/loadpin.h fs/btrfs/disk-io.c: At top level: fs/btrfs/disk-io.c:63:13: warning: =E2=80=98btrfs_destroy_ordered_extents= =E2=80=99 declared =E2=80=98static=E2=80=99 but never defined [-Wunused-function] 63 | static void btrfs_destroy_ordered_extents(struct btrfs_root *root); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:64:12: warning: =E2=80=98btrfs_destroy_delayed_refs=E2= =80=99 declared =E2=80=98static=E2=80=99 but never defined [-Wunused-function] 64 | static int btrfs_destroy_delayed_refs(struct btrfs_transaction *tra= ns, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:66:13: warning: =E2=80=98btrfs_destroy_delalloc_inodes= =E2=80=99 declared =E2=80=98static=E2=80=99 but never defined [-Wunused-function] 66 | static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:67:12: warning: =E2=80=98btrfs_destroy_marked_extents=E2= =80=99 declared =E2=80=98static=E2=80=99 but never defined [-Wunused-function] 67 | static int btrfs_destroy_marked_extents(struct btrfs_fs_info *fs_in= fo, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:70:12: warning: =E2=80=98btrfs_destroy_pinned_extent=E2= =80=99 declared =E2=80=98static=E2=80=99 but never defined [-Wunused-function] 70 | static int btrfs_destroy_pinned_extent(struct btrfs_fs_info *fs_inf= o, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:72:12: warning: =E2=80=98btrfs_cleanup_transaction=E2=80= =99 declared =E2=80=98static=E2=80=99 but never defined [-Wunused-function] 72 | static int btrfs_cleanup_transaction(struct btrfs_fs_info *fs_info)= ; | ^~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:73:13: warning: =E2=80=98btrfs_error_commit_super=E2=80= =99 declared =E2=80=98static=E2=80=99 but never defined [-Wunused-function] 73 | static void btrfs_error_commit_super(struct btrfs_fs_info *fs_info)= ; | ^~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:828:13: warning: =E2=80=98should_async_write=E2=80=99 de= fined but not used [-Wunused-function] 828 | static bool should_async_write(struct btrfs_fs_info *fs_info, | ^~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:161:13: warning: =E2=80=98btrfs_supported_super_csum=E2= =80=99 defined but not used [-Wunused-function] 161 | static bool btrfs_supported_super_csum(u16 csum_type) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:130:12: warning: =E2=80=98verify_parent_transid=E2=80=99= defined but not used [-Wunused-function] 130 | static int verify_parent_transid(struct extent_io_tree *io_tree, | ^~~~~~~~~~~~~~~~~~~~~ fs/btrfs/disk-io.c:75:13: warning: =E2=80=98btrfs_free_csum_hash=E2=80=99 d= efined but not used [-Wunused-function] 75 | static void btrfs_free_csum_hash(struct btrfs_fs_info *fs_info) | ^~~~~~~~~~~~~~~~~~~~ CC kernel/notifier.o make[3]: *** [scripts/Makefile.build:252: fs/btrfs/disk-io.o] Error 1 make[3]: *** Waiting for unfinished jobs.... --=20 Best Regards, Mike Gavrilov.