Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760964AbXHQRM1 (ORCPT ); Fri, 17 Aug 2007 13:12:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756210AbXHQRMT (ORCPT ); Fri, 17 Aug 2007 13:12:19 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:60555 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753817AbXHQRMT (ORCPT ); Fri, 17 Aug 2007 13:12:19 -0400 Date: Fri, 17 Aug 2007 13:12:16 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Andreas Jellinghaus [c]" cc: linux-kernel@vger.kernel.org, Subject: Re: [linux-usb-devel] why was MODALIAS removed from usb kernel events? [u] In-Reply-To: <200708171705.35793.aj@ciphirelabs.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1779 Lines: 57 On Fri, 17 Aug 2007, Andreas Jellinghaus [c] wrote: > I need some kernel event that has both DEVICE and MODALIAS set. > up to including kernel 2.6.21 this seems to come from > drivers/usb/core/driver.c if I read the code correctly, and then > it was removed. > > udevmonitor --kernel --environment shows one event with both on 2.6.21 plain, > but not on 2.6.22 plain. Does this patch improve matters? Alan Stern Index: 2.6.22/drivers/usb/core/message.c =================================================================== --- 2.6.22.orig/drivers/usb/core/message.c +++ 2.6.22/drivers/usb/core/message.c @@ -1344,6 +1344,30 @@ static int usb_if_uevent(struct device * usb_dev = interface_to_usbdev(intf); alt = intf->cur_altsetting; +#ifdef CONFIG_USB_DEVICEFS + /* If this is available, userspace programs can directly read + * all the device descriptors we don't tell them about. Or + * act as usermode drivers. + */ + if (add_uevent_var(envp, num_envp, &i, + buffer, buffer_size, &length, + "DEVICE=/proc/bus/usb/%03d/%03d", + usb_dev->bus->busnum, usb_dev->devnum)) + return -ENOMEM; +#endif + + if (add_uevent_var(envp, num_envp, &i, + buffer, buffer_size, &length, + "BUSNUM=%03d", + usb_dev->bus->busnum)) + return -ENOMEM; + + if (add_uevent_var(envp, num_envp, &i, + buffer, buffer_size, &length, + "DEVNUM=%03d", + usb_dev->devnum)) + return -ENOMEM; + if (add_uevent_var(envp, num_envp, &i, buffer, buffer_size, &length, "INTERFACE=%d/%d/%d", - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/