Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rolf Eike Beer <eike-kernel@sf-tec.de>
To:     james.bottomley@hansenpartnership.com, yang.yang29@zte.com.cn
Cc:     deller@gmx.de, linux-parisc@vger.kernel.org,
        linux-kernel@vger.kernel.org, xu.panda@zte.com.cn,
        yang.yang29@zte.com.cn
Subject: Re: [PATCH linux-next v2] parisc: use strscpy() to instead of strncpy()
Date:   Tue, 27 Dec 2022 08:47:05 +0100
Message-ID: <2298026.kkTNVCUfUN@daneel.sf-tec.de>
In-Reply-To: <202212261840048448622@zte.com.cn>
References: <202212261840048448622@zte.com.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2316597.IaFIOm8ydW"; micalg="pgp-sha1"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart2316597.IaFIOm8ydW
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"; protected-headers="v1"
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: james.bottomley@hansenpartnership.com, yang.yang29@zte.com.cn
Date: Tue, 27 Dec 2022 08:47:05 +0100
Message-ID: <2298026.kkTNVCUfUN@daneel.sf-tec.de>
In-Reply-To: <202212261840048448622@zte.com.cn>
References: <202212261840048448622@zte.com.cn>

Am Montag, 26. Dezember 2022, 11:40:04 CET schrieb yang.yang29@zte.com.cn:
> From: Xu Panda <xu.panda@zte.com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
> 
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
> change for v2
>  - sizeof(in) is better and simplified, thanks for Helge Deller.
> ---
>  drivers/parisc/pdc_stable.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
> index d6af5726ddf3..d3075445260b 100644
> --- a/drivers/parisc/pdc_stable.c
> +++ b/drivers/parisc/pdc_stable.c
> @@ -274,8 +274,7 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry,
> const char *buf, size_t coun
> 
>  	/* We'll use a local copy of buf */
>  	count = min_t(size_t, count, sizeof(in)-1);
> -	strncpy(in, buf, count);
> -	in[count] = '\0';
> +	strscpy(in, buf, sizeof(in));

What is "count" now needed for? Looks like a write only variable at least in 
these hunks.

Eike
--nextPart2316597.IaFIOm8ydW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQSaYVDeqwKa3fTXNeNcpIk+abn8TgUCY6qi+QAKCRBcpIk+abn8
TreFAJsGRGXqTM4D8ib9NJdGgqNbpJTmUgCeNNVn9q3szniJshUbN+h2L4zJ5sI=
=oo7x
-----END PGP SIGNATURE-----

--nextPart2316597.IaFIOm8ydW--